From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5985C425A5; Fri, 15 Sep 2023 15:44:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29050402EC; Fri, 15 Sep 2023 15:44:45 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2068.outbound.protection.outlook.com [40.107.244.68]) by mails.dpdk.org (Postfix) with ESMTP id 0031140041 for ; Fri, 15 Sep 2023 15:44:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DM2/Kg6LHH010eC7R2EZMLAqOs0eIdKKCiIQ/j4Ub/0/NJX77tnPocs0VY0kjVJtcjOnctTeNac0fyJbtUs1xaEMBm+ePzWYpnQQaHBp8DvHCZ6W16krH0daFS4kUyEKvf7iDJc8w3ttIfQuisDFQE8s6k1EJyeSWVHAf81XCPv42zwumxoUrDc64AgsGnxFsH1WJARtpNwImNYJaHdMX5kPriaIm93RTdVXHc1jkTGJcmBDkp6bx0IsBDQiEeNwqp+8at64dilknolwybZMsd86mDdSPP56Ww6SwTRDItI8M6SQuN2dF9wlDvSZADPcnq9QdaXB4xsypDrWC4Gn3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HavuwrhD4YyZBD23cr853Z7AsNdBz0B14E4gkTlLM2E=; b=jwOVTBQVlCBkSA1h/YghnzZdRizZSGwMm4ZKpSTHaLT2Xl1WAKg9zPrtNin7/OkTbNby8MK6Kt1XD/MSaWqd81FiA8E6lNuNSHU+fMG1eOSUn86PmVEP4YcDMNoBhfX/8ku27giRQtDgyQtzdr6ijhU0EkKve8nMFzEwmtl6KeQVwH1b+DIpl5HR6tmWMcY44sseLnDqhhdUIOyFitTW1W20oiG1d4rt5KIJtPXT/YKzrcYO1iQxEkc+7UT6gsOodlXDgY3O2mf2ymBGzUhZtHWTS8Bxj9i++sCTvG3kfH/vW0XELQFXjs4eVxZFFyTiQ0jpeRhCD/ptn6hLoUV23w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HavuwrhD4YyZBD23cr853Z7AsNdBz0B14E4gkTlLM2E=; b=e9+T79CdRALNRfZ8aLJbNbCQtqPsgZ47ezKPKR2EQVRa7laR/pzTtXwM7wnO9sFdylhvsQgrQU4+sNTjQWRmXVMFrw5+Baatfgq7O/CSgJn0gp+d6tyUX8M1pY9oPMZXF929hN6pGfM80/Vi9pTfOHvdu8pp+BKcWevsEQxpP4Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CO6PR12MB5393.namprd12.prod.outlook.com (2603:10b6:5:356::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.21; Fri, 15 Sep 2023 13:44:41 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.021; Fri, 15 Sep 2023 13:44:41 +0000 Message-ID: Date: Fri, 15 Sep 2023 14:44:35 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/27] net/nfp: standard the comment style Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, =?UTF-8?Q?Niklas_S=C3=B6derlund?= References: <20230830021457.2064750-1-chaoyong.he@corigine.com> <20230915091551.1459606-1-chaoyong.he@corigine.com> <20230915091551.1459606-8-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230915091551.1459606-8-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0054.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CO6PR12MB5393:EE_ X-MS-Office365-Filtering-Correlation-Id: 690e7487-6c55-432f-ce73-08dbb5f1e9ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CEGYSTUjoT/qD16bCcffk3+adsgp6grbdIsA0WkNeHXey/o8Pfx8OmqG6C9yo/M0tAW8z4l4DGJGjfB8W4+A8wfyumfYaAqI9Q0VbSzxWgiTpq25L/SYJ10ut41hGXwiJPQ+ISRPHsBJv4w0BbDWD6rTcBtrqHrWi3bXRr+6uxjj8WJI4RtEFaN9WmQJvC/jyG2Yr3mk4aS4hMzuJHJt4ZtTo+2IVxwk1w//WS7i2eQC31e5vVsxw9IlIfZZSwyGdHOIfOUyUHzxDJztyKFJuanRK5LRRdJGP9zhUajvWXVYAyfpF7Pv1tjjmzESqCpts8M/kpuZvx3T5ggasKRhIUnn0s0JaE6+tNoE+Fry3GPUX787e4NspvitYOAiFDDmb2je+tx9kOzYv6Lx8dcjneEa6WVrp7EhV+nrx9vy1wpsXKikEfMySd4scQmf6TtHvE4e22HckRq/Sg2MmSzoFkVuDfLT8a/jeVrCW+DYf0K290ugZ1r0YjnKf/AGPjNLSWB09KTaOV31xiYqgySW/UCArrB97pye+W0wgIV4dNImPUzHcubeAavmpepqc9dCZLl3vRxJbKkJwVR5h6xfFasx1PDDPl6joTo5plJvM7Mlx2ObrxJqn5vMT9nEC5+feyQNVbuohCRc/KlNKF15gg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(39860400002)(396003)(376002)(366004)(1800799009)(186009)(451199024)(6506007)(6666004)(53546011)(6486002)(6512007)(478600001)(26005)(2616005)(4744005)(2906002)(44832011)(66476007)(66556008)(66946007)(8676002)(316002)(4326008)(5660300002)(8936002)(41300700001)(86362001)(31696002)(36756003)(38100700002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkxPQ2ppQXNPdTNENkNacFBBSjNrTFNtUE1lS3NxWnJKRm9DQjlUNXFyOXhV?= =?utf-8?B?Mjh1VzczTnkzTzhZME1DTGl1SUExcDRKTHdtcUtBODNUK090dUdkeFRjM0Ft?= =?utf-8?B?eDhuK1lNMFcvSzBsYTlNejF5dWpRKzNMQjJoWk40cWxhV05ta3ZRL01lZSti?= =?utf-8?B?ZUgyNERsNVVLMDM4TkQzSlhTRDlwbXFneU1SR0daMHdtQkhURUdOditBNEJs?= =?utf-8?B?WkVIWkxZWThRam50elk1SGpwMUNXOUxKczdqeHhmV21GQkYzYTBTdFFGbDJL?= =?utf-8?B?MDNjT0xrSDZJTjhuY0lXNG9HbnRHdUZzd2xKaVF6Sk5EekNwRG4wQUh3Mlpi?= =?utf-8?B?N2FRcGdic0lya3gzQk0zOGpGRTY0L24vNVFhRXcvMkFSS1NOSnlJV3BSQXUv?= =?utf-8?B?ODcyOFpxclV5L1AvZ0VzN29PNFFtOFkvZnVkb0NCNXU2L1I4ZElhRGdDVjJL?= =?utf-8?B?Z0tTN3UzdEYrRzE2cWZJcWhJbVgwaVVCb0R1cEt2d1NXQUFxMDEwVmc5aEZa?= =?utf-8?B?L2FmSVRNcExRcUVreFlRVUk1YlJHRDJqZGNVSkNrV2VKS2JaZ3IzZTkrRnFT?= =?utf-8?B?dWRXVkoxczN0QThuL3cxKzNXdU1rRC8vdUpUeUdtclNtclFvbmtwbXVuRXJ4?= =?utf-8?B?djkwem9yU0tTcXJzQm1DUUJMUDQ0VlBpVzE2Y1Z0QS9rMklqdG1OcnozN0c4?= =?utf-8?B?VWNZcENnakp6TlptQlBxWUFrRklnendSRVZhTjY1amJHc05QRzRrN2hGMFVT?= =?utf-8?B?eHcvZzIzVWtTWnV6ZEpqYlF4STV6dlN5UzBZb1JOb2tDU3BDNmlRcU00RWh0?= =?utf-8?B?eEhJYTFPRFN1Z21nMXU2UkZjS25EMVNMQ3c5WUJLV21MZWszMC9CeEZFMHRS?= =?utf-8?B?M293eW9LSVlnUUprdzExNzdDZFdJSStKMnZvMjVNU3d1cWdUT2Z0NmhCLzJG?= =?utf-8?B?ZGs5U2xJVTNqdkxnOThSR2dJZjBwc0xBKzEvYWc0SkthbW1UdklrWGRrZUVq?= =?utf-8?B?d255ZjM3MEdIR212Q2NNSjkwNDJkL1RGZS8xYlZYZ0wrZ3FtV1dPYzZTR3Z0?= =?utf-8?B?a1FiVWhLQ2hHdUdJNEcreWZ0YUE4YXhyaTJTbUJWVEc4cHArejV2cklXVU5y?= =?utf-8?B?QkFDVHdITy85bWhtV1NjV1ZOTWpmUUsyZHBZWWRuaXU3ZFB4aWtncG15bmNN?= =?utf-8?B?a1dZUm9sbmdkR1JvUlBKcTd6Rmk2YWpiNUwwL1ZCYkJiWlpINTNHT3BlSXlp?= =?utf-8?B?Umg4NW00amVCY0VLRDBheGVmTG9RRk1MUnZWOFh1Z0VpRmF2Y0lCeWsyaU9O?= =?utf-8?B?NTFtT0h3dnMwSkZTT1dlVjMrS0NGc0lxRGx0d2t6UUxlRlBVRms4cDVpT3Jw?= =?utf-8?B?blViU1o1OUtNSy91V09OV3RkRWtCK21RdlptVTRxTEpsK0VKMUlCY1h4Q25R?= =?utf-8?B?UHlOUWNlM1ZVZjRzZW9wMG5RNnMvQStJK1NYazA1ay9FNnVsR29xYVIvRzVw?= =?utf-8?B?aGRhU2UzYnRWWnMvNkExWjRuM0pVaDJrWnlEQngwK3hqZXBFdWxOTGU2T09R?= =?utf-8?B?TWc3aHQwd2w4TUNNK0xCN0xPVVI5MmdsMDk0Y2hLUjFvdmdSaFN2R3RwNkpo?= =?utf-8?B?UE5xUC9EZUQ2RVpuUU94YlRxa3NjeFJpZDd0dGloV1N5SncyTXFvdmFQR0Jr?= =?utf-8?B?WG02T2p3MDFCTlJLL2NNYzhMS3p4Z3A2a0FSUmU2Sll4dGNXRmtsejFpYkhN?= =?utf-8?B?RjY2aWNia25saGRQOVBOOURVMFA0QndxVFdxd3BlMS9ld2Q0STAzZit1Kzlv?= =?utf-8?B?NVU5WDhSZUprRXIvNmJYbThTZDRQZFhIM2dJeFBIa0NXc250NWlQbWhaS21q?= =?utf-8?B?aThiUDQrZG1jWkp0cUJ1WlZ3cUJJd2NlOFhvSzcyMWVVenc5andHblUxZ2FY?= =?utf-8?B?MVd2TEdzT3FWUWhiZ29OQjZIZ05Yb1RnZHJmTHpKVFdYNGZyN3U4dGhHWU9a?= =?utf-8?B?RkxBRHFUTkM3VW0yR1lXbSt6T3NFSFp2c29qYUdzeTV1MnZmMDhpblgvbk5x?= =?utf-8?B?Wk9MdkNCcW5pblliRjRTVDhnMEtwelpqYUVDZVg2M1Y2QzJ6ZnpRMkcrTFhB?= =?utf-8?Q?iQ2xYfrYukvfS6Zl4oOtSZR9J?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 690e7487-6c55-432f-ce73-08dbb5f1e9ba X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 13:44:41.8089 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fYyIP32lCCslyUrGK1TauQy+Rn/A4ay2coPGYgIFdSmlcZot5LRQBSJDPOJ9MoWC X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5393 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/15/2023 10:15 AM, Chaoyong He wrote: > Follow the DPDK coding style, use the kdoc comment style. > Also add some comment to help understand logic. > > Signed-off-by: Chaoyong He > Reviewed-by: Niklas Söderlund <...> > > -/* > - * Set the model id > - * > - * @param cpp NFP CPP operations structure > - * @param model Model ID > - */ > void nfp_cpp_model_set(struct nfp_cpp *cpp, uint32_t model); > As I see some comments are removed in this patch, there is no enforced comment style for internal functions, for API doxygen comments must provided. Of course consistency matters, but if comments are removed because of the syntax, I think better option to keep them with their own syntax.