DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/virtio: remove unnecessary forward declaration
@ 2019-01-23 17:29 Rami Rosen
  2019-02-08 17:34 ` Maxime Coquelin
  2019-02-08 18:06 ` Maxime Coquelin
  0 siblings, 2 replies; 3+ messages in thread
From: Rami Rosen @ 2019-01-23 17:29 UTC (permalink / raw)
  To: dev; +Cc: stable, maxime.coquelin, tiwei.bie, zhihong.wang, Rami Rosen

This minor cleanup patch removes an unecessary forward
declaration of virtio_intr_enable() in net/virtio PMD.

Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 drivers/net/virtio/virtio_ethdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index ee5a98b..d8fd288 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -71,7 +71,6 @@ static int virtio_mac_addr_add(struct rte_eth_dev *dev,
 static int virtio_mac_addr_set(struct rte_eth_dev *dev,
 				struct ether_addr *mac_addr);
 
-static int virtio_intr_enable(struct rte_eth_dev *dev);
 static int virtio_intr_disable(struct rte_eth_dev *dev);
 
 static int virtio_dev_queue_stats_mapping_set(
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/virtio: remove unnecessary forward declaration
  2019-01-23 17:29 [dpdk-dev] [PATCH] net/virtio: remove unnecessary forward declaration Rami Rosen
@ 2019-02-08 17:34 ` Maxime Coquelin
  2019-02-08 18:06 ` Maxime Coquelin
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2019-02-08 17:34 UTC (permalink / raw)
  To: Rami Rosen, dev; +Cc: stable, tiwei.bie, zhihong.wang



On 1/23/19 6:29 PM, Rami Rosen wrote:
> This minor cleanup patch removes an unecessary forward
s/unecessary/unnecessary/

> declaration of virtio_intr_enable() in net/virtio PMD.
> 
> Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
> Cc: stable@dpdk.org
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>   drivers/net/virtio/virtio_ethdev.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index ee5a98b..d8fd288 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -71,7 +71,6 @@ static int virtio_mac_addr_add(struct rte_eth_dev *dev,
>   static int virtio_mac_addr_set(struct rte_eth_dev *dev,
>   				struct ether_addr *mac_addr);
>   
> -static int virtio_intr_enable(struct rte_eth_dev *dev);
>   static int virtio_intr_disable(struct rte_eth_dev *dev);
>   
>   static int virtio_dev_queue_stats_mapping_set(
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

I'll fix the typo while applying.

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/virtio: remove unnecessary forward declaration
  2019-01-23 17:29 [dpdk-dev] [PATCH] net/virtio: remove unnecessary forward declaration Rami Rosen
  2019-02-08 17:34 ` Maxime Coquelin
@ 2019-02-08 18:06 ` Maxime Coquelin
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2019-02-08 18:06 UTC (permalink / raw)
  To: Rami Rosen, dev; +Cc: stable, tiwei.bie, zhihong.wang



On 1/23/19 6:29 PM, Rami Rosen wrote:
> This minor cleanup patch removes an unecessary forward
> declaration of virtio_intr_enable() in net/virtio PMD.
> 
> Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
> Cc: stable@dpdk.org
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>   drivers/net/virtio/virtio_ethdev.c | 1 -
>   1 file changed, 1 deletion(-)
> 

Applied to dpdk-next-virtio/master.

Thanks,
Maxime

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-08 18:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-23 17:29 [dpdk-dev] [PATCH] net/virtio: remove unnecessary forward declaration Rami Rosen
2019-02-08 17:34 ` Maxime Coquelin
2019-02-08 18:06 ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).