From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/tap: fix invalid queue file descriptor
Date: Mon, 30 Jan 2017 21:23:17 +0000 [thread overview]
Message-ID: <b436f73c-08a1-77ee-3286-b9c10a5c5d16@intel.com> (raw)
In-Reply-To: <180E842F-5344-4E7D-B46E-6A58232A680F@intel.com>
On 1/30/2017 8:57 PM, Wiles, Keith wrote:
>
>> On Jan 30, 2017, at 2:54 PM, Yigit, Ferruh <ferruh.yigit@intel.com> wrote:
>>
>> From: Keith Wiles <keith.wiles@intel.com>
>>
>> Rx and Tx queues share the common tap file descriptor, but save this
>> value separately.
>>
>> Setting up Rx/Tx queue sets up both queues, release_queue close the
>> tap file but update file descriptor only for that queue.
>>
>> This makes other queue's file descriptor invalid.
>>
>> As a workaround, prevent release_queue callback to be called by default.
>>
>> This is done by separating Rx/Tx setup functions, so that each only
>> setup its own queue, this prevents rte_eth_rx/tx_queue_setup() calling
>> release_queue before setup_queue.
>>
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
(Just a reminder, defect still exists when app call
rte_eth_rx/tx_queue_setup() multiple times)
prev parent reply other threads:[~2017-01-30 21:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 2:12 [dpdk-dev] [PATCH] net/tap: driver closing tx interface on queue setup Keith Wiles
2017-01-30 11:00 ` Ferruh Yigit
2017-01-30 14:34 ` Wiles, Keith
2017-01-30 17:42 ` Ferruh Yigit
2017-01-30 18:20 ` Wiles, Keith
2017-01-30 19:31 ` Ferruh Yigit
2017-01-30 14:38 ` Pascal Mazon
2017-01-30 15:04 ` Wiles, Keith
2017-01-30 17:19 ` Ferruh Yigit
2017-01-30 20:54 ` [dpdk-dev] [PATCH v2] net/tap: fix invalid queue file descriptor Ferruh Yigit
2017-01-30 20:57 ` Wiles, Keith
2017-01-30 21:23 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b436f73c-08a1-77ee-3286-b9c10a5c5d16@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).