From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D622B3237 for ; Mon, 30 Jan 2017 22:23:23 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 30 Jan 2017 13:23:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,312,1477983600"; d="scan'208";a="219428596" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by fmsmga004.fm.intel.com with ESMTP; 30 Jan 2017 13:23:21 -0800 To: "Wiles, Keith" References: <20170129021205.36860-1-keith.wiles@intel.com> <20170130205445.7527-1-ferruh.yigit@intel.com> <180E842F-5344-4E7D-B46E-6A58232A680F@intel.com> Cc: "dev@dpdk.org" From: Ferruh Yigit Message-ID: Date: Mon, 30 Jan 2017 21:23:17 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <180E842F-5344-4E7D-B46E-6A58232A680F@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/tap: fix invalid queue file descriptor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2017 21:23:24 -0000 On 1/30/2017 8:57 PM, Wiles, Keith wrote: > >> On Jan 30, 2017, at 2:54 PM, Yigit, Ferruh wrote: >> >> From: Keith Wiles >> >> Rx and Tx queues share the common tap file descriptor, but save this >> value separately. >> >> Setting up Rx/Tx queue sets up both queues, release_queue close the >> tap file but update file descriptor only for that queue. >> >> This makes other queue's file descriptor invalid. >> >> As a workaround, prevent release_queue callback to be called by default. >> >> This is done by separating Rx/Tx setup functions, so that each only >> setup its own queue, this prevents rte_eth_rx/tx_queue_setup() calling >> release_queue before setup_queue. >> >> Signed-off-by: Keith Wiles >> Signed-off-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks. (Just a reminder, defect still exists when app call rte_eth_rx/tx_queue_setup() multiple times)