From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03A6EA04B5; Thu, 1 Oct 2020 10:26:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A1F61D9EA; Thu, 1 Oct 2020 10:26:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id AD2EC1D9C2 for ; Thu, 1 Oct 2020 10:26:22 +0200 (CEST) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601540780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BqevDEG+xjeiBnMsGAajHlI2NVW3Zne+md5rMNReU/w=; b=ZANn72DdhidATOiZEuoMNlsaXnVYIa2VR12h/YqlwmVskhOJe3+ReZXq5+WAPu/spgsLp7 9q3ztNbOZRZYAkvN8QfHLs3xlTvVY4BYfXV8DP/SXIdBrZf/SspBmQh5nB7SQIhhXM7DYn j8qK7JDXcgouHfROG9H1Xm9CUkXkcxA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-447-uVy-GosTOqWP8EyT_0PsVw-1; Thu, 01 Oct 2020 04:26:16 -0400 X-MC-Unique: uVy-GosTOqWP8EyT_0PsVw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B42B91084C80; Thu, 1 Oct 2020 08:26:14 +0000 (UTC) Received: from [10.36.110.36] (unknown [10.36.110.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 24EF219D7D; Thu, 1 Oct 2020 08:26:11 +0000 (UTC) To: "Zhang, Roy Fan" , "Xia, Chenbo" , "Liu, Changpeng" , "dev@dpdk.org" Cc: "matan@mellanox.com" , "Zawadzki, Tomasz" , "Yigit, Ferruh" References: <1598944057-32690-1-git-send-email-changpeng.liu@intel.com> <8e0e8343-4e85-71f3-8c85-07eb1cff6079@redhat.com> <06542643-cc20-5e3e-26ae-7100005dc97d@redhat.com> <24b547af-2cda-36db-cb66-e5523d169556@redhat.com> <0f8b9daf-3ed7-0ede-8c0c-f2a1bcef9ca4@redhat.com> <42d0c319-314f-80ea-f3d7-21eaf567c2fa@redhat.com> <30e718ae-5b06-cd9a-63d5-34977f1df56c@redhat.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: Date: Thu, 1 Oct 2020 10:26:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fan, On 10/1/20 10:07 AM, Zhang, Roy Fan wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Thursday, October 1, 2020 8:55 AM >> To: Zhang, Roy Fan ; Xia, Chenbo >> ; Liu, Changpeng ; >> dev@dpdk.org >> Cc: matan@mellanox.com; Zawadzki, Tomasz ; >> Yigit, Ferruh >> Subject: Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is >> configured >> >> >> >> On 9/30/20 6:37 PM, Zhang, Roy Fan wrote: >>> Hi Chenbo and Maxime, >>> >>> Thanks for replying the email. >>> >>> >>>> -----Original Message----- >>>> From: Maxime Coquelin >>>> Sent: Wednesday, September 30, 2020 4:37 PM >>>> To: Xia, Chenbo ; Zhang, Roy Fan >>>> ; Liu, Changpeng ; >>>> dev@dpdk.org >>>> Cc: matan@mellanox.com; Zawadzki, Tomasz >> ; >>>> Yigit, Ferruh >>>> Subject: Re: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring >> is >>>> configured >>>> >>>> Hi, >>>> >>>> On 9/30/20 4:48 AM, Xia, Chenbo wrote: >>>>> Hi Fan & Maxime, >>>>> >>>>> I am thinking that should we move set_features outside of new_device >>>> callback >>>>> for crypto device? I see that net and blk devices both set features >> between >>>> register >>>>> and start, and personally I think this makes sense that device features >> are >>>> set >>>>> before device start and ready. How do you think 😊? >>> >>> The reason it is set inside rte_vhost_crypto_create() is logically speaking >>> the user shouldn't expect to have to set the feature flags even after the >> create >>> function is called - and what I know in the application the only way to know >> the >>> vid for the first time is when new_device() is invoked. So if there is away to >> know >>> the vid before new_device() is invoked I am happy to change the sample >> app. >> >> I think the Vhost-crypto API should be fixed. >> The good news is that it is still experimental, so we can fix it without >> worries (BTW, except the DPDK example, are there other application using >> the Vhost-crypto API?). >> >> The .new_device() callback is called when the Virtio device is ready, >> meaning when the backend can start processing the virtqueues. So feature >> negotiation should have taken place before that. >> >> I'm surprised it worked before, because doesn't the features negotiation >> takes place before the memory table are set? If so, how can the first >> virtqueue can be tested as ready if the vring address is not set? >> >> One other issue here, which is triggering the issue is that given how >> the registration is done, VIRTIO_DEV_BUILTIN_VIRTIO_NET flag is set for >> Vhost-crypto, which shouldn't happen. Even before last release rework, >> you should have faced issues when more than 2 queues where in used: >> > > Vhost-crypto was not working since 20.05. Changpeng's patch which set the > Number of queues to one made it working again so we waited it merged. But the patch introducing the regression was introduced in v20.08, I'm confused. > However the patch was rejected by you. Indeed, I rejected the patch because it would break net backends. > I suppose there is another way - adding a new API called > "rte_vhost_crypto_set_feature(const char *socket)" so we don't have to > rely on rte_vhost_crypto_create() to set the feature flags > > what do you think? The set_features thing is just another problem. The main problem is that VIRTIO_DEV_BUILTIN_VIRTIO_NET gets set for crypto backend, which does not make sense. I proposed a fix below to be able to differentiate between builtin net and crypto backends below, but I think you missed it. Please check below. > Regards, > Fan > >> static int >> vhost_user_set_features(struct virtio_net **pdev, struct VhostUserMsg >> *msg, >> int main_fd __rte_unused) >> { >> ... >> if ((dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET) && >> !(dev->features & (1ULL << VIRTIO_NET_F_MQ))) { >> /* >> * Remove all but first queue pair if MQ hasn't been >> * negotiated. This is safe because the device is not >> * running at this stage. >> */ >> while (dev->nr_vring > 2) { >> struct vhost_virtqueue *vq; >> >> vq = dev->virtqueue[--dev->nr_vring]; >> if (!vq) >> continue; >> >> dev->virtqueue[dev->nr_vring] = NULL; >> cleanup_vq(vq, 1); >> cleanup_vq_inflight(dev, vq); >> free_vq(dev, vq); >> } >> } >> >> As VIRTIO_NET_F_MQ is never negotiated with crypto devices, it means you >> can not have more than two queues. >> >>>> >>>> Indeed, we cannot consider the device to be ready (and so call >>>> .new_device callback) if features haven't been negotiated. >>>> >>>> I agree, rte_vhost_driver_set_features() has to be called before >>>> .new_device(), and that's the reason why it takes socket's path and not >>>> vid as input. >>> >>> Different than vhost_blk, vhost_crypto lies in the library and needs to be >>> able to be treated evenly as virtio_net. Without the new_device() calling >>> rte_vhost_crypto_create() the feature flag cannot be set. Without setting >>> the feature flag the device is always treated as virtio_net device, hence it >>> cannot pass the virtio_is_ready() check as the number of queues virtio >>> crypt uses is only 1 instead of 2 (required by virtio_net). >> >> OK, so we are aligned, we need to find a proper solution. I think you >> need a specific driver start function that does not set >> VIRTIO_DEV_BUILTIN_VIRTIO_NET. >> >> First we can change that VIRTIO_DEV_BUILTIN_VIRTIO_NET flag by a new >> field in the device without breaking the API: >> >> enum virtio_backend_type { >> VIRTIO_DEV_UNKNOWN = 0, /* Likely external */ >> VIRTIO_DEV_BUILTIN_NET, >> VIRTIO_DEV_BUILTIN_CRYPTO, >> }; >> >> struct virtio_net { >> ... >> enum virtio_backend_type type; >> }; >> >> >> Then, introduce a new API to start crypto backend that would be called >> instead of rte_vhost_driver_start(): >> >> int >> rte_vhost_crypto_driver_start(const char *path) >> { >> >> return vhost_driver_start(path, VIRTIO_DEV_BUILTIN_CRYPTO); >> } >> >> >> int >> rte_vhost_driver_start(const char *path) >> { >> >> return vhost_driver_start(path, VIRTIO_DEV_BUILTIN_NET); >> } >> >> And then propagate the info down to vhost_new_device(). >> >> Does that make sense? Note that it does not fix the set_feature thing, which would also need to be fixed. But it should revert the behaviour for crypto backends back to pre-v20.08, as Changpeng patch did. >> Note that issue has been reported during v20.11 cycle was it was >> introduced in v20.08. It means it has not been tested. Does Intel QE has >> some Vhost crypto tests? >> Thanks, >> Maxime