From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C05F0A0093; Sat, 21 May 2022 00:09:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE01B427F8; Sat, 21 May 2022 00:09:46 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2065.outbound.protection.outlook.com [40.107.101.65]) by mails.dpdk.org (Postfix) with ESMTP id 4A046427F2; Sat, 21 May 2022 00:09:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TC0dGxrYHGdmhKtw0M5EaIs3s0FYFhwlAFFOiNOFk055iDuVAxzq2fAGz0OryzCeKU/8kG1w+plKWo8o2+TvChQH01YjOmyGOAiFvQcsQ/JUQlGe5t2SnFJvh8bEsm0JvfOEIgvE/N9zNB9tZzOIHFzMHOZ/UGD4LvQU1Z93AszIApDysY7+gIb8x1su1aIIrZTxlQvN2T/hhdeOaD5WOdoyi7Rq66xjbNrwB7UCA+Wod2MB1BMdFacebozwh6ak1y3zrT3sgoWJGIXrF0eybM9wxAwm5F2Xj/l4nFiq3uoXiuAsZVLyZ7H6JAe9byu+ZvlaXiyN2IcD43wAd+aorA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hRmSlSgF/ZvzL1aYbk8sBO316cSi8OR2ldHfpOczGJE=; b=jt6h+vJs5LiHUHdyI79ypLXEVjdDYo1SHguDd2im899vRsm9sP1SOaLliA3QL4PW/BMlrVWFKcVc2bITt14RRDBL4YA8zf0DWQFxAM64NPP7snSwTbUQ0j7QasYFuyWZEmhk8cB2RjsJOHlcHCsQUIdshkiVXURWuPoxoZPHWJldCO3fV/KdrwF//H8s6Yykoy9PG4EXnMbQcEZh0LSzfFSNuXObp5sAHCe64nNn/KDPx7hWiAdD6m9yDqZCa8VampThnnxA8Sab/HxOUZF0/lk7yHj7LqROgHRC7FmWOWM9JxvIqlxdcn7p0/DOBWMb1oy3rCKkHNZTB5k9acaXZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.80.198) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hRmSlSgF/ZvzL1aYbk8sBO316cSi8OR2ldHfpOczGJE=; b=lP/UY13XX1kvtnofQCaUPzuvQSPZYYCkq/Q+c5NkE5FATmUYmyNFcQyPc3Ltv5LPRiWRfwRVuaM2Xwikx6WDTa8AQYx8oEmd8+Vs1M9dKQPI6NAZaDSLlh43oLV1MPCMTgjBZHO08hhLwZ9viZYj9VGYeFw36W/7vBXLgJ0Fp7I= Received: from BN6PR1101CA0015.namprd11.prod.outlook.com (2603:10b6:405:4a::25) by CO6PR02MB7521.namprd02.prod.outlook.com (2603:10b6:303:ad::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Fri, 20 May 2022 22:09:42 +0000 Received: from BN1NAM02FT062.eop-nam02.prod.protection.outlook.com (2603:10b6:405:4a:cafe::a3) by BN6PR1101CA0015.outlook.office365.com (2603:10b6:405:4a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.18 via Frontend Transport; Fri, 20 May 2022 22:09:42 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.80.198) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.80.198 as permitted sender) Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT062.mail.protection.outlook.com (10.13.2.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Fri, 20 May 2022 22:09:41 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 20 May 2022 23:09:40 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 20 May 2022 23:09:40 +0100 Envelope-to: yuying.zhang@intel.com, mingxia.liu@intel.com, dev@dpdk.org, xiaoyun.li@intel.com, aman.deep.singh@intel.com, stable@dpdk.org Received: from [10.71.116.2] (port=29656) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nsAoW-0005sV-SA; Fri, 20 May 2022 23:09:40 +0100 Message-ID: Date: Fri, 20 May 2022 23:09:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] app/testpmd: change a magic number to macro Content-Language: en-US To: "Zhang, Yuying" , "Liu, Mingxia" , "dev@dpdk.org" CC: "Li, Xiaoyun" , "Singh, Aman Deep" , "stable@dpdk.org" References: <20220329071452.1524865-1-mingxia.liu@intel.com> <20220331023333.1632745-1-mingxia.liu@intel.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bcc2a6c8-0b81-411a-dfed-08da3aad70a5 X-MS-TrafficTypeDiagnostic: CO6PR02MB7521:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 2 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NTOIrPnSvxk2yjpWNBTc8GcOPYysNNUakV7j3nsBU6vi2xR3V2iq3qmSdki8OBPAq3bmGQWdqdQAhkABWwqhG8NZgVFQL9oxw01ycwPCPKYvVI87tmnESd+CcGFROkd8DKAGApWmS7ucDKqqDN2bUySGTcQkbwvHNQlTLUm2wx8nGSnwmYibhMVMf+8zluRzvy5szvwlZ4UQ+Sgq9kB+vV9F67OiscZcfy6hUIW/ADSWP5/Hdc2h9HUz+FO5Z+LFFErqkTRr88vtHQ8n3yFrkteNIcrJFVd+o/4YlyvQdJScS5fGHNSH5FdLNJ1/4oklqfirS7Xkmktj0qtqKSHKDDQGn9RKeYQqb3XiYACd3Bxp8qPi0WCYXp9Y97fIpg7BWsyveomsJZEMEpzXggv4MtyDSEEjKaYiJSNRuWr3cY5J0aj3cC/uEUrp9MxqEmWLh3twLrJIozxvNq3Z++nV4vwaibWJnEVR+K/2Jymr2oF31ZVrhsGbqX3OxrY0QYUnXdAaUQiiiqPcSlw5FCmfp6iBkg/rA0ndE2FzI7ISW7TR7p7t0q/nBbSkhy5NvJxKzJunWjWNvkzWGWnmjO5MMktUjyyCmq8WDG2Oafh+HlbizrsXSpGbAfxWwY2MCudX4GhjiLKhOx0pzk39Uz44DGFqHoQzgY45hrin3rqzGT+XaHDrvrJy/1HYUoU81zcNffU3aN5VZmUpwbhC74e12CB2ZSdOHJGSowHZoITmjyY= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(8936002)(9786002)(82310400005)(35950700001)(7636003)(356005)(86362001)(5660300002)(31696002)(2906002)(44832011)(70586007)(4744005)(2616005)(53546011)(54906003)(110136005)(26005)(508600001)(36756003)(8676002)(336012)(83380400001)(40460700003)(70206006)(316002)(4326008)(31686004)(47076005)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2022 22:09:41.8300 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bcc2a6c8-0b81-411a-dfed-08da3aad70a5 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT062.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR02MB7521 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/1/2022 9:50 AM, Zhang, Yuying wrote: > Hi Mingxia, > > LGTM. > >> -----Original Message----- >> From: Liu, Mingxia >> Sent: Thursday, March 31, 2022 10:34 AM >> To: dev@dpdk.org >> Cc: Li, Xiaoyun ; Singh, Aman Deep >> ; Zhang, Yuying ; >> Liu, Mingxia ; stable@dpdk.org >> Subject: [PATCH v2] app/testpmd: change a magic number to macro >> >> From: mingxial >> >> Add macro MIN_TOTAL_NUM_MBUFS (1024) to indicate what the value of >> total-num-mbufs should bigger than. >> >> Fixes: c87988187fdb ("app/testpmd: add --total-num-mbufs option") >> Cc: stable@dpdk.org >> >> Signed-off-by: mingxial > > Acked-by: Yuying Zhang > Updated sign off as: Signed-off-by: Mingxia Liu Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.