From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E65C5101B for ; Mon, 18 Sep 2017 15:13:11 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2017 06:13:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,412,1500966000"; d="scan'208,217";a="1196254447" Received: from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.79]) ([10.237.221.79]) by fmsmga001.fm.intel.com with ESMTP; 18 Sep 2017 06:13:09 -0700 To: Ferruh Yigit , David C Harton , konstantin.ananyev@intel.com Cc: dev@dpdk.org References: <20170914124202.16132-1-dharton@cisco.com> <20170914125041.31060-1-dharton@cisco.com> From: Radu Nicolau Message-ID: Date: Mon, 18 Sep 2017 14:13:08 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] ixgbe: eliminate duplicate filterlist symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 13:13:12 -0000 On 9/14/2017 2:38 PM, Ferruh Yigit wrote: > On 9/14/2017 1:50 PM, David C Harton wrote: >> From: David Harton >> >> Some compilers generate warnings for duplicate symbols for the >> set of filter lists current defined in ixgbe_ethdev.h. >> This commits moves the definition and declaration to the source >> file that actually uses them and provides a function to >> initialize the values akin to its flush function. >> >> Signed-off-by: David Harton > Reviewed-by: Ferruh Yigit > > (title needs to be "net/ixgbe: ...", but this can be fixed while applying) > Reviewed-by: Radu Nicolau