DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: fix uninitialized members of mpls
@ 2020-01-30 16:59 Ori Kam
  2020-01-31 11:07 ` Ferruh Yigit
  2020-02-04 11:49 ` [dpdk-dev] " Ferruh Yigit
  0 siblings, 2 replies; 7+ messages in thread
From: Ori Kam @ 2020-01-30 16:59 UTC (permalink / raw)
  To: Wenzhuo Lu, Jingjing Wu, Bernard Iremonger
  Cc: dev, orika, ferruh.yigit, viacheslavo, stable

Some of the memebers of the mpls struct are not initialized.
this commit init the uninitialized members.

Coverity issue: 325735
Fixes: 3e77031be855 ("app/testpmd: add MPLSoGRE encapsulation")
Cc: stable@dpdk.org

Signed-off-by: Ori Kam <orika@mellanox.com>
---
 app/test-pmd/cmdline_flow.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index e99e24c..c2cc4c5 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -4576,7 +4576,9 @@ static int comp_set_raw_index(struct context *, const struct token *,
 	struct rte_flow_item_gre gre = {
 		.protocol = rte_cpu_to_be_16(ETHER_TYPE_MPLS_UNICAST),
 	};
-	struct rte_flow_item_mpls mpls;
+	struct rte_flow_item_mpls mpls = {
+		.ttl = 0,
+	};
 	uint8_t *header;
 	int ret;
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-02-04 11:49 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-30 16:59 [dpdk-dev] [PATCH] app/testpmd: fix uninitialized members of mpls Ori Kam
2020-01-31 11:07 ` Ferruh Yigit
2020-02-02  8:23   ` Ori Kam
2020-02-03 10:21     ` Ferruh Yigit
2020-02-03 17:46       ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-02-04  7:50         ` Ori Kam
2020-02-04 11:49 ` [dpdk-dev] " Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).