From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 94F842C54; Tue, 30 Oct 2018 11:19:37 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE0803117B5D; Tue, 30 Oct 2018 10:19:36 +0000 (UTC) Received: from [10.36.112.50] (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BADB25D75C; Tue, 30 Oct 2018 10:19:34 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: stephen@networkplumber.org, stable@dpdk.org References: <20181029052808.16520-1-tiwei.bie@intel.com> <20181029052808.16520-2-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: Date: Tue, 30 Oct 2018 11:19:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181029052808.16520-2-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 30 Oct 2018 10:19:37 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 1/6] net/virtio-user: do not stop stopped device again X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 10:19:37 -0000 On 10/29/18 6:28 AM, Tiwei Bie wrote: > Without this change, virtio-user still works, but it will show > annoying error messages like this on shutdown: > > vhost_kernel_set_backend(): VHOST_NET_SET_BACKEND fails, Operation not permitted > vhost_kernel_ioctl(): VHOST_RESET_OWNER failed: Operation not permitted > > Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost") > Fixes: 12ecb2f63b12 ("net/virtio-user: support memory hotplug") > Cc: stable@dpdk.org > > Reported-by: Stephen Hemminger > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_user/virtio_user_dev.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Maxime Coquelin Thanks, Maxime