From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 69CF41B293; Wed, 17 Apr 2019 09:54:53 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C448385A03; Wed, 17 Apr 2019 07:54:52 +0000 (UTC) Received: from [10.36.112.28] (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FE215D9D4; Wed, 17 Apr 2019 07:54:50 +0000 (UTC) To: Mohammad Abdul Awal , dev@dpdk.org Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, stable@dpdk.org References: <20190411144840.19942-1-mohammad.abdul.awal@intel.com> From: Maxime Coquelin Message-ID: Date: Wed, 17 Apr 2019 09:54:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190411144840.19942-1-mohammad.abdul.awal@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 17 Apr 2019 07:54:52 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3] vhost: fix null pointer checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 07:54:53 -0000 On 4/11/19 4:48 PM, Mohammad Abdul Awal wrote: > Null value for parameters will cause segfault. > > Fixes: d7280c9fff ("vhost: support selective datapath") > Fixes: 72e8543093 ("vhost: add API to get MTU value") > Fixes: a277c71598 ("vhost: refactor code structure") > Fixes: ca33faf9ef ("vhost: introduce API to fetch negotiated features") > Fixes: eb32247457 ("vhost: export guest memory regions") > Fixes: 40ef286f23 ("vhost: export vhost vring info") > Fixes: bd2e0c3fe5 ("vhost: add APIs for live migration") > Fixes: 0b8572a0c1 ("vhost: add external message handling to the API") > Fixes: b4953225ce ("vhost: add APIs for datapath configuration") > Fixes: 5fbb3941da ("vhost: introduce driver features related APIs") > Fixes: 292959c719 ("vhost: cleanup unix socket") > Cc:stable@dpdk.org > > Signed-off-by: Mohammad Abdul Awal > --- > v3: fixed per review comments > > v2: fixed per review comments > > lib/librte_vhost/socket.c | 8 +++++++- > lib/librte_vhost/vdpa.c | 5 ++++- > lib/librte_vhost/vhost.c | 16 ++++++++-------- > 3 files changed, 19 insertions(+), 10 deletions(-) Applied to dpdk-next-virtio/master. Thanks, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A4D82A00E6 for ; Wed, 17 Apr 2019 09:54:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7BD731B3EE; Wed, 17 Apr 2019 09:54:54 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 69CF41B293; Wed, 17 Apr 2019 09:54:53 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C448385A03; Wed, 17 Apr 2019 07:54:52 +0000 (UTC) Received: from [10.36.112.28] (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FE215D9D4; Wed, 17 Apr 2019 07:54:50 +0000 (UTC) To: Mohammad Abdul Awal , dev@dpdk.org Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, stable@dpdk.org References: <20190411144840.19942-1-mohammad.abdul.awal@intel.com> From: Maxime Coquelin Message-ID: Date: Wed, 17 Apr 2019 09:54:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190411144840.19942-1-mohammad.abdul.awal@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 17 Apr 2019 07:54:52 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3] vhost: fix null pointer checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417075445.gEYnrurCuZvBxJnsE2RjPyk-YuKd9FXp98LSbagM8jE@z> On 4/11/19 4:48 PM, Mohammad Abdul Awal wrote: > Null value for parameters will cause segfault. > > Fixes: d7280c9fff ("vhost: support selective datapath") > Fixes: 72e8543093 ("vhost: add API to get MTU value") > Fixes: a277c71598 ("vhost: refactor code structure") > Fixes: ca33faf9ef ("vhost: introduce API to fetch negotiated features") > Fixes: eb32247457 ("vhost: export guest memory regions") > Fixes: 40ef286f23 ("vhost: export vhost vring info") > Fixes: bd2e0c3fe5 ("vhost: add APIs for live migration") > Fixes: 0b8572a0c1 ("vhost: add external message handling to the API") > Fixes: b4953225ce ("vhost: add APIs for datapath configuration") > Fixes: 5fbb3941da ("vhost: introduce driver features related APIs") > Fixes: 292959c719 ("vhost: cleanup unix socket") > Cc:stable@dpdk.org > > Signed-off-by: Mohammad Abdul Awal > --- > v3: fixed per review comments > > v2: fixed per review comments > > lib/librte_vhost/socket.c | 8 +++++++- > lib/librte_vhost/vdpa.c | 5 ++++- > lib/librte_vhost/vhost.c | 16 ++++++++-------- > 3 files changed, 19 insertions(+), 10 deletions(-) Applied to dpdk-next-virtio/master. Thanks, Maxime