From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55735A0032; Fri, 21 Oct 2022 11:51:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47EDF42BA6; Fri, 21 Oct 2022 11:51:27 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2041.outbound.protection.outlook.com [40.107.220.41]) by mails.dpdk.org (Postfix) with ESMTP id 1D5CC42BA4 for <dev@dpdk.org>; Fri, 21 Oct 2022 11:51:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X7jvix+lsrpN4jdBWpF8YdYfx7UJbRMWFPqO0bl+AiUQoDvieSZBL2UODRSzbzwbyM1jd7RiwVhkLx94da5RHjEdbuwN0SjrmASxdqsW6RfmX6+nMuzFCx+wweduIhTLoK+4+Sopyvt+C137dVo/vzJmBFFBqmUlWGNzF0mKJIFwZYbRBCJhssZU/KkM2ct6LKtUvlFtoj7ri/FrajCHGfa72XDqjuJkgxnMslCowXFCtZNHi118Rz6lL+Aoxz4Ac+Afg4z7FAsoNII/UIRE3C5ZIBa0Yoq2QqNtzkAoGjmv3jsyV90bZ+Q/kkAPzaYUupQTT/ZKk/7SSjW1zIsURw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=09KPpMY5kNYo6CaMkZNxKArDAvBviaWPRhVSQrSZaXQ=; b=QFlCJVfz8KyyXpJUvoXldKpW2j6/dM8LIH6iImMfR3yHO8OHvhQ4eg61ER3Pzq/04b4Jb9viQI6Jfg08OUXcpPp0D/PsMuVsalOEcPoNZ2F45OYym4ZoBAXNXhUPVmaG5+T8j8Q3TJ80d9TN4Utfu9nA1F+KgNeVYDgrdzF+NAd3FA8DB5U6JCJ4BWG77sozcI5I7+74hVbYirxanbf5trOGOMGEUeNBqdvatkaEA3odMXrB3PhAVmiuZFPt0X3fv2PI9FPcGTrKbZ7bOWEi3LcdCArN8vq4TpbHCPZP8b3PbLNnB3gOfFdv8G7trQEypN9ILuUtGru4PXBPvGxD7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=09KPpMY5kNYo6CaMkZNxKArDAvBviaWPRhVSQrSZaXQ=; b=KE9WORp9l3gk6bjMAi1/sq6/lYz+ZWHYSyHHdmEH6Y0b+cVJb32frxud0ivxJ2v5FqqBWaYjpA3/RDyKZ4eFYfNDOMfoogGb2WlTF4crgjkJvoVGVl5vuuc/QyOTRl7K57pOZUd/OQ2v5reRE9kwUVpHQKlf3J/NNA502P09fFw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by DS0PR12MB6582.namprd12.prod.outlook.com (2603:10b6:8:d2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct 2022 09:51:23 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Fri, 21 Oct 2022 09:51:23 +0000 Message-ID: <b4b18e20-0e8f-6113-fdfa-224d49e2fec5@amd.com> Date: Fri, 21 Oct 2022 10:51:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v7 6/8] net/gve: add support for dev info get and dev configure Content-Language: en-US To: Junfeng Guo <junfeng.guo@intel.com>, qi.z.zhang@intel.com, jingjing.wu@intel.com, ferruh.yigit@xilinx.com, beilei.xing@intel.com Cc: dev@dpdk.org, xiaoyun.li@intel.com, awogbemila@google.com, bruce.richardson@intel.com, hemant.agrawal@nxp.com, stephen@networkplumber.org, chenbo.xia@intel.com, helin.zhang@intel.com References: <20221020103656.1068036-1-junfeng.guo@intel.com> <20221021091928.2674471-1-junfeng.guo@intel.com> <20221021091928.2674471-7-junfeng.guo@intel.com> From: Ferruh Yigit <ferruh.yigit@amd.com> In-Reply-To: <20221021091928.2674471-7-junfeng.guo@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::6) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|DS0PR12MB6582:EE_ X-MS-Office365-Filtering-Correlation-Id: e4066f5e-6702-46ff-146d-08dab349d004 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cEGglCsUwOFo73f6Qhucoci/MNCeq18H31E0TpXp2Qe1jMCtNakauweYCLAG/lzjtYQgr33rXYwI2WYP2wJxbHsB/yDG5eHVfkpwMcCfPEAwzJJIlnxy5HvNZ54w218poEOWZAgzrk4JEM73CGh7la9c2LKMohep+TOxm9QnyO6TkTmFT4ihBx7n5ceG+7T+M/ipPfMJI+XYp8eiYt0PY5Bvf3Jf1Ybv/W2JL8rchp9pkpGLohLD2qzR//ehnJKDnYpAHBYXdm4wWFg5R9qR19xQOXvvKn5znbcJ2oXQAN7gnXnhIWKfxufKj/qvwyhageac3uUTT2o94DdQicFB6JTNsN9VM2MheAT6bBuOT/hqjzS9vebHVi3O09D3OcoKop825xsQQTHhg3cwxwPlGPK/1rNbSGUqLI1Kp1AMAGQZ6jKgae85tQT1gQXae6fET9IYevrZYiq5eUotE5oTgrydSidPSNk1a2qLq+oXaa8j1MgPiWfqXmwIK/3TjP7Xjv/vCoA+KsSPNWhsktKb6ioKMCItbhPjcQ2RU9ufy0AHHjyMcQalziMMKl1jrbK0QZ916gZiH/FvN+CShgwiwNFnLU8ikohB0SCW/j9GZ+wnERyr5PiFdMj7yLZRO6cVtiBrTkx60gWqG9VnZeFRIiVu33lJ+nhSn4kZSFxlQrpdaXyP8IA0F0I9oJmVyfo+XZiMQd8+ipoix2l3L3nqxf6+9qWpA9FBQEEy3xkUAnPV+cD0jhzj/9XcaZUfeymrNltoTwbTxTwBGBNVCWbKnPLfBwprEluTVQ+f1wnr3/Q= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(366004)(451199015)(86362001)(36756003)(31696002)(38100700002)(31686004)(186003)(66946007)(83380400001)(7416002)(5660300002)(2616005)(44832011)(53546011)(26005)(6506007)(478600001)(6512007)(6666004)(4744005)(2906002)(41300700001)(66476007)(316002)(6486002)(8676002)(4326008)(66556008)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VU9Nam1Pam1kU3p2c0VoLzlBRkx4N0cwL2RJSDErY1pzb20veXNNUUhOcXNm?= =?utf-8?B?SkE2WXhiM0dMWlF2RTFLNTh0OEk3NkpiamJ0Rnd5elE4OWUxYXA4cWxGazQ2?= =?utf-8?B?dVRSNWcxQ1JPSFZ0ZXplR2h0L0JwTXVTQkMyZjRQdS84TkdheWlYK0Erd0pu?= =?utf-8?B?OU43eXdNSVhvMUY2dXRKZW1icnBCbkI4dkZ1SHh5c3JGUDhaT3o0bVBzWE5W?= =?utf-8?B?K3ZJZEMwNXF0a1k2SGR5U0wyaWxPdHRPRVRsaG1tQWRuejNZa1FOYkFra0cz?= =?utf-8?B?NXlzSlREV3hnejgxdzVsL1JveS9TNmZJOTJUUHpkenV6N0V5bFVZaTdLUHgw?= =?utf-8?B?TmIyN2FiUmFINFhjS2F4SGpsd1VpMnpXSlFqNjFJK2ZoNWlmamNrd3lyelZi?= =?utf-8?B?WXJxNHJRSkJIRG9iYjFvRFVHZ3lxaVpSQ095ZU9VZXpLTFFkTnR3S0t2YStD?= =?utf-8?B?Y3k1bXJCVlpwWXFvYlB3MmxMMEViTUFva2dwcG9oaEN4RTdVTy9HRzNFakFB?= =?utf-8?B?RmdCbHVkaDRuUnJia2JTMGROOFJzalJ5RkZ6UTV5dUZ4WEtkREp3ay9iV3cw?= =?utf-8?B?OGRHR3lTZzVaRnFqYTR3QzF5VDhPakdHa0tsbzVuYVpmVW9QTnc2Qyt6L1d1?= =?utf-8?B?Nm1rYWdnd3B4L1Z4NFp0ZWN1a244aHVlYXhkUXpSTmdPbmgyQXNDdzliQ0lj?= =?utf-8?B?TG9uc0hxL21pbGh6MWp4YXhCUUlLWEVJc2IyVmxkYS8zNFc5V2tWZWNtSmRC?= =?utf-8?B?VlNOM3VLcTNnaTdxSlh1MmpZelliM1lZaEFqU09Gd2xkUlpFYVJCVExHU3FZ?= =?utf-8?B?aGZueWJ1WDFLL2RyY1ZqZlQ4aEZCaFdOQ3J4SVY5NFdQSVE4N3VYcHcwVzI3?= =?utf-8?B?LzJqdjhZZHdmSHpaYzZjb3o0c0FFQ0lTR1FlWUZ6b2xzM1FaUUQ0SzJXZzE0?= =?utf-8?B?RTFmMllJalFCUVlkM1FsK003Z3hGcWYrR2FOdi9DcEgzVUdMdUJ3RUpmZFVr?= =?utf-8?B?UHFQbGdOdjZMZFplNUFONUpOVTAvQWVHKzFNenVYMWJaRlRzOUpxQU9CTTNt?= =?utf-8?B?UHdkOUMybkorMFJKdlBiZXRPL1VYem95MkJRWmJEWFNWSnJVUWs2TEt0ZFNT?= =?utf-8?B?RWxaeEtYNDVJTjZybzNjY1NobjdJUzNFYUIvMU1LbW9Ua0RyZHA5WDQzMzhR?= =?utf-8?B?K0F3d3VxNnhWUXo5bDJnTTFPQmd3ZURnYWhDV1ZsaE9DNFUzandacEhOeGZ3?= =?utf-8?B?UXRMcHovYitDTyt1SXR2ZTE3cGJqUzlZVzFsTXJJNkd2NDIySFFYRDZYWCtB?= =?utf-8?B?dHE0V2xIb255cTF1YVZJOHl3T05kZ0NuditISUVIOWlQSjNWZnpNc0FvTTBI?= =?utf-8?B?aGp3STM4ZFJlOWpvZ3dBVHdsZHkyRjhMaEpTaFhTUHF5ZW5WRzJCckVKV0tj?= =?utf-8?B?VWM5cHVvMEkzWHpZdUNwVTFvUkFKalBNSnU2WGJWQ3V3T0QvN1c1aExiZi9u?= =?utf-8?B?VWxpRlJ2b1d1N1lVYWlLQW1ib1pBQU9XSEFDU3dvMGxrM285RGc4MWlkenNt?= =?utf-8?B?S0dZMzBncUM4RkZQeTZEV1lzL3ROZTFVM09QSTdkRXVCdE1aelhtTTV0YWF3?= =?utf-8?B?VmllS2IzMVMrUXJ0cklRdUFYV1B5OTJ0YUNKc2tkRzdVa2cvV0k0WmRabXdT?= =?utf-8?B?TERvdTdUbzhSNGprUUwxbEJxckQ2UVpJWFRNMG1xZU1SKzluanczT1VEMXNT?= =?utf-8?B?bURYMWNQY2NNVmppNzBHQm13eWpjTW9CQW5VamNnNmswL0xrVGx6TWRscDlF?= =?utf-8?B?Y25VVENsODl5Z1k0NlA0ZHJ0SzdHNEhEaisrbkRkamVXRzg1eHBVWEdSYWRG?= =?utf-8?B?elJUdE52ZnM2UEVWNElxQ3hYd2dxVlc0aTBMcjhFc1NLbjNCeklvUmZtZDFN?= =?utf-8?B?QUhJYkpnVHIreHp2aXdQZUhPUGxBcnZwUndBS2pUb2Q5bFR4YU93RFlRNlhL?= =?utf-8?B?MHZsdTgzK3ZyV3hmS2JndXl3bVlvSmhvbERzSURVYjBVa2xGRVkvZGlSa1ha?= =?utf-8?B?cE5HWlVCZDN4blJlVlVyRFRxTlI0c2xZQkpJazUvOVJRNW95V3U1cUNuUVgw?= =?utf-8?Q?R62tdj1RR+Wk6iHPOgrygddJa?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4066f5e-6702-46ff-146d-08dab349d004 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 09:51:23.1990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ODCjkdvZ8IjuadqAsn90JSJibIn9rFKLLj6y8y/X7Ppo4mCD144NEenEjwhBhbIk X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6582 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 10/21/2022 10:19 AM, Junfeng Guo wrote: > > Add dev_ops dev_infos_get. > Complete dev_configure with RX offloads force enabling. > > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com> <...> > --- a/doc/guides/nics/gve.rst > +++ b/doc/guides/nics/gve.rst > @@ -62,6 +62,7 @@ In this release, the GVE PMD provides the basic functionality of packet > reception and transmission. > Supported features of the GVE PMD are: > > +- Receiver Side Scaling (RSS) [copy/paste from previous version] I am not sure if driver can claim this, I can see a RSS hash is provided but is it possible to update which hash function to use or update key or RETA table to configure which queue packets goes? Right now what is RSS calculated on? Perpaps RSS support can be documented as limited? And not sure if this update belongs this patch, it should be to the one that has the datapath.