From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 0F9F21B866 for ; Tue, 10 Apr 2018 11:41:40 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AA813EAEB2; Tue, 10 Apr 2018 09:41:39 +0000 (UTC) Received: from [10.36.112.60] (ovpn-112-60.ams2.redhat.com [10.36.112.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AF51320357B5; Tue, 10 Apr 2018 09:41:38 +0000 (UTC) To: Fan Zhang , dev@dpdk.org Cc: ferruh.yigit@intel.com References: <20180409163832.85611-1-roy.fan.zhang@intel.com> <20180409182116.47161-1-roy.fan.zhang@intel.com> From: Maxime Coquelin Message-ID: Date: Tue, 10 Apr 2018 11:41:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180409182116.47161-1-roy.fan.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 10 Apr 2018 09:41:39 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 10 Apr 2018 09:41:39 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix session id printf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 09:41:40 -0000 On 04/09/2018 08:21 PM, Fan Zhang wrote: > Fixes: 85a2d5cab96f ("vhost/crypto: add virtio-crypto user message structure") > > Signed-off-by: Fan Zhang > --- > lib/librte_vhost/vhost_crypto.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c > index d84513e7f..06c0d3398 100644 > --- a/lib/librte_vhost/vhost_crypto.c > +++ b/lib/librte_vhost/vhost_crypto.c > @@ -381,8 +381,8 @@ vhost_crypto_create_sess(struct vhost_crypto *vcrypto, > return; > } > > - VC_LOG_DBG("Session (key %lu, session %p) created.", > - vcrypto->last_session_id, session); > + VC_LOG_INFO("Session %"PRIu64" created for vdev %i.", > + vcrypto->last_session_id, vcrypto->dev->vid); > > sess_param->session_id = vcrypto->last_session_id; > vcrypto->last_session_id++; > @@ -399,17 +399,17 @@ vhost_crypto_close_sess(struct vhost_crypto *vcrypto, uint64_t session_id) > (void **)&session); > > if (unlikely(ret < 0)) { > - VC_LOG_ERR("Failed to delete session (key %lu).", session_id); > + VC_LOG_ERR("Failed to delete session %"PRIu64".", session_id); > return -VIRTIO_CRYPTO_INVSESS; > } > > if (rte_cryptodev_sym_session_clear(vcrypto->cid, session) < 0) { > - VC_LOG_DBG("Failed to delete session"); > + VC_LOG_DBG("Failed to clear session"); > return -VIRTIO_CRYPTO_ERR; > } > > if (rte_cryptodev_sym_session_free(session) < 0) { > - VC_LOG_DBG("Failed to delete session"); > + VC_LOG_DBG("Failed to free session"); > return -VIRTIO_CRYPTO_ERR; > } > > @@ -418,8 +418,8 @@ vhost_crypto_close_sess(struct vhost_crypto *vcrypto, uint64_t session_id) > return -VIRTIO_CRYPTO_ERR; > } > > - VC_LOG_DBG("Session (key %lu, session %p) deleted.", sess_id, > - session); > + VC_LOG_INFO("Session %"PRIu64" deleted for vdev %i.", sess_id, > + vcrypto->dev->vid); > > return 0; > } > Acked-by: Maxime Coquelin I'll squash it with faulty commit if not yet merged by Ferruh. Thanks, Maxime