From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id CD7112B8B for ; Tue, 24 Apr 2018 14:09:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 05:09:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,322,1520924400"; d="scan'208";a="218965290" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.55]) ([10.237.221.55]) by orsmga005.jf.intel.com with ESMTP; 24 Apr 2018 05:09:01 -0700 To: "Pattan, Reshma" , "Richardson, Bruce" , Thomas Monjalon Cc: "Parthasarathy, JananeeX M" , "dev@dpdk.org" References: <1523022706-12231-1-git-send-email-reshma.pattan@intel.com> <1523456067-14178-1-git-send-email-reshma.pattan@intel.com> <3442093.nS8Mgo2NPm@xps> <20180424105859.GA124204@bricha3-MOBL.ger.corp.intel.com> <3AEA2BF9852C6F48A459DA490692831F2A2C9022@irsmsx110.ger.corp.intel.com> From: "Hunt, David" Message-ID: Date: Tue, 24 Apr 2018 13:09:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2C9022@irsmsx110.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance power manager unit tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 12:09:04 -0000 On 24/4/2018 12:23 PM, Pattan, Reshma wrote: > Hi, > >> -----Original Message----- >> From: Richardson, Bruce >> Sent: Tuesday, April 24, 2018 11:59 AM >> To: Thomas Monjalon >> Cc: Parthasarathy, JananeeX M ; >> dev@dpdk.org; Pattan, Reshma ; Hunt, David >> >> Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance power manager unit >> tests >> >> On Mon, Apr 23, 2018 at 11:04:27PM +0200, Thomas Monjalon wrote: >>> 11/04/2018 16:14, Reshma Pattan: >>>> Unit Testcases are added for power_acpi_cpu_freq, power_kvm_vm_test >>>> to improve coverage >>>> >>>> Signed-off-by: Jananee Parthasarathy >>>> >>>> Acked-by: David Hunt >>> Applied, thanks >>> >> Sadly, this patch seems to break shared library builds. If you try doing "make >> test-build" with shared libraries on it will fail, or if you do a meson build using >> shared libraries you will get the same result. >> >> The root cause is that the function guest_channel_host_connect() is a private >> function and so is not listed in the shared library map file, preventing the test >> app from linking. >> > Any action from my side required? Let me know. Reshma,     Looking at this, I think this particular unit test needs to be removed. The way it is at the moment, it's "faking" the connect, then any commands that are sent to the dummy host are only really to test to see if the API breaks, which is going to be captured by compilation tests anyway. I don't see the value of this unit test unless you have the full host setup underneath is, in which case it's no longer a unit test. Also, we don't want to make these functions public, as they are only of use to the library internally, and there is no use for them publicly (unless a guest wants to fake a connection to a non-existent host). What do you think? Dave.