DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>,
	Simon Ellmann <simon.ellmann@tum.de>,
	"Guo, Jia" <jia.guo@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clear registers of all queues on VF reset
Date: Mon, 4 Jan 2021 15:56:16 +0000	[thread overview]
Message-ID: <b4d3a3cb-eb6f-8fa2-bf75-5c0463e106b7@intel.com> (raw)
In-Reply-To: <BN8PR11MB3795892A89E325A2AAD740A7F7C30@BN8PR11MB3795.namprd11.prod.outlook.com>

On 12/18/2020 2:34 AM, Wang, Haiyue wrote:
>> -----Original Message-----
>> From: Simon Ellmann <simon.ellmann@tum.de>
>> Sent: Friday, December 18, 2020 01:15
>> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
>> Cc: dev@dpdk.org; Simon Ellmann <simon.ellmann@tum.de>
>> Subject: [PATCH] net/ixgbe: clear registers of all queues on VF reset
>>
>> ixgbe devices support up to 8 Rx and Tx queues per virtual function.
>> Currently, the registers of only seven queues are set to default when
>> resetting a VF.
>>
> 
> Fixes: d17d0b7a2407 ("ixgbe/base: reset VF registers")
> Cc: stable@dpdk.org
> 
>> Signed-off-by: Simon Ellmann <simon.ellmann@tum.de>
>> ---
>>   drivers/net/ixgbe/base/ixgbe_vf.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> Good catch, thanks!
> 
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>
> 

This seems a very long lived defect, I am just suspicious if there was a reason 
to limit queue number to 7.


Simon,

How did you find the defect? And did you test/verify it with the update? 
(assuming you are using all 8 queues for the VF)

  parent reply	other threads:[~2021-01-04 15:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 17:14 Simon Ellmann
2020-12-18  2:34 ` Wang, Haiyue
2020-12-23 10:17   ` Zhang, Qi Z
2021-01-04 15:56   ` Ferruh Yigit [this message]
2021-01-05  9:02     ` Simon Ellmann
2021-01-05 10:29       ` Ferruh Yigit
2021-01-05 12:52         ` Wang, Haiyue
2021-01-05 14:10           ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4d3a3cb-eb6f-8fa2-bf75-5c0463e106b7@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=jia.guo@intel.com \
    --cc=simon.ellmann@tum.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).