From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEE60A09FF; Mon, 4 Jan 2021 16:56:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5938B160734; Mon, 4 Jan 2021 16:56:35 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id B414A160733 for ; Mon, 4 Jan 2021 16:56:33 +0100 (CET) IronPort-SDR: xmBWkukzKLDJAsAXfTjC7kAxeGe+QULgpWpm64EqhMRwYURq8GhXRQ8/d0dGBiB1cJZy3AElmT pQAPRhIxLRdQ== X-IronPort-AV: E=McAfee;i="6000,8403,9854"; a="195493541" X-IronPort-AV: E=Sophos;i="5.78,474,1599548400"; d="scan'208";a="195493541" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 07:56:32 -0800 IronPort-SDR: 7owFI7zRCoTB+o/oRwLdN8QGo177XNHEjUNlqpFw/qMTwonl81EQ3PwC96nK60NZZKEk20AGEK PX8vdDWo9W+w== X-IronPort-AV: E=Sophos;i="5.78,474,1599548400"; d="scan'208";a="378466137" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.93.148]) ([10.251.93.148]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 07:56:20 -0800 To: "Wang, Haiyue" , Simon Ellmann , "Guo, Jia" Cc: "dev@dpdk.org" References: <20201217171452.24914-1-simon.ellmann@tum.de> From: Ferruh Yigit Message-ID: Date: Mon, 4 Jan 2021 15:56:16 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clear registers of all queues on VF reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/18/2020 2:34 AM, Wang, Haiyue wrote: >> -----Original Message----- >> From: Simon Ellmann >> Sent: Friday, December 18, 2020 01:15 >> To: Guo, Jia ; Wang, Haiyue >> Cc: dev@dpdk.org; Simon Ellmann >> Subject: [PATCH] net/ixgbe: clear registers of all queues on VF reset >> >> ixgbe devices support up to 8 Rx and Tx queues per virtual function. >> Currently, the registers of only seven queues are set to default when >> resetting a VF. >> > > Fixes: d17d0b7a2407 ("ixgbe/base: reset VF registers") > Cc: stable@dpdk.org > >> Signed-off-by: Simon Ellmann >> --- >> drivers/net/ixgbe/base/ixgbe_vf.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > Good catch, thanks! > > Acked-by: Haiyue Wang > This seems a very long lived defect, I am just suspicious if there was a reason to limit queue number to 7. Simon, How did you find the defect? And did you test/verify it with the update? (assuming you are using all 8 queues for the VF)