From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 188D1A00C3; Tue, 1 Feb 2022 12:45:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87C5340698; Tue, 1 Feb 2022 12:45:05 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 6629140691; Tue, 1 Feb 2022 12:45:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643715903; x=1675251903; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=LU4jqfsp4pfyznpO5BAmlZZw0pJko3l4FIfdtg+pqw0=; b=D1RRxhapeEYpf6CN3i7osi/haP9LIyTAnQXh4kKN7WHI1YsVLOphi1Jx 1u//+PuEZNxDCIuFjtvsywUQ8ZuoLMuW6fcLpyOt5yCAQfqdmNhUhVd3R 13Ni8RKBCetRo3cK+y9xKfBmnAJfnl8BGsJVsYYe4yHPHAacjLEg0yn5o c5O9oKVNq+Yx6wW/Bboygpn7fznWp68NISRiNCjO1EZnX5YH/oGpAWhVv K0nDLd3MmvFRxMrFXNXa7BxaKk4OXti8m7ePjDV2+wi66ifPGdOlRS3MR u+ZcKJtteSDoweQupanovumArXWCts/ivp+3N7E5/02S8fq4cfqgCCBJO g==; X-IronPort-AV: E=McAfee;i="6200,9189,10244"; a="235066363" X-IronPort-AV: E=Sophos;i="5.88,333,1635231600"; d="scan'208";a="235066363" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2022 03:45:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,333,1635231600"; d="scan'208";a="523026211" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga007.jf.intel.com with ESMTP; 01 Feb 2022 03:45:02 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 1 Feb 2022 03:45:01 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 1 Feb 2022 03:45:01 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Feb 2022 03:45:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QjI9kiqa9qmPdQb5g8ffW5ueM6YTG8I/VclpOtQJ0BjVKv9jfw1LugpRdX4jp9hsjX5pZKh6GqzxNlwCzIANmVo1qPvs2ZNMpX8bh6tX0GwOOftDhnOFwCc1kQPxoVKBc4SRfPy2geGmHkU/ANV2ih6B/EdhGY6e5xgHQ0KhDAiCCP9e2TrzHHSCXfY5ffvaz80BVVZNLNUbCnei+cwRzFIz7lnaU+ze5sTrTjdn+S6oIbV4wpy1C8r6OwsdlhS1b3K0Dqtf2tPi94QYObxNZuAm3Y6XYPKdiVjsVK92jDWhPsP+Z9eicd5I+lQ2c4G/3qaKDKRDRAh9Kwp1bQw9pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QDOWhuMHjqD7VsWaw3MoQgOGkbHFj9I0V4g9dzf2opY=; b=miz1w4AeSYyJ62J2qelXRSXPELmndxOpQGdU0g0HQ09j2538oTEBqnHw96nJ+K8zgVN9ElpLnY4QHxy8NevDTVJT+I76Qm416IUAO8OQmZH9HQVBTLEx1lIJGC6eJQYEtxNntbZFrc6bqF1y/y18FFmNlyMdnuVcQh57rBn6ggOoKtWxixaezB7lpzE15VWyOes2eVaaQYnQ8BGalcxudOQbh4tNGDp749CtaVQj7kCMva3k5FxFT4bt+wBb1/oDk+s9N5PtCW3hWkoK4jqBKPqcnExCt1aOuu8q2CvMHyRDIXRZlBFAy2H9FeKLjH/bNhYuNdFcrqaEtqHjkDoMSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN7PR11MB2738.namprd11.prod.outlook.com (2603:10b6:406:b3::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Tue, 1 Feb 2022 11:44:59 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022 11:44:59 +0000 Message-ID: Date: Tue, 1 Feb 2022 11:44:53 +0000 Subject: Re: [PATCH] net/bonding: fix MTU set for slaves Content-Language: en-US To: "Min Hu (Connor)" , Chas Williams , Ivan Ilchenko , Andrew Rybchenko CC: , , Andrew Rybchenko , References: <20220126131037.2403369-1-ferruh.yigit@intel.com> <24dfb8f2-6d56-e091-7b7d-b88e18121749@huawei.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <24dfb8f2-6d56-e091-7b7d-b88e18121749@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0502.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dcf3a70f-c31a-4ed3-61b3-08d9e57846ac X-MS-TrafficTypeDiagnostic: BN7PR11MB2738:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2331; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Cndcjswdii8B3TW5YC3uyZSK0z0Rjv381OOjYfo2/NGVzoVPSkVzBGOPFtVjOHkjtezeWCMKM/Qzi33u0fkcXgOozOKYjMDk605l/wicRCRL3mdW5IFztzDp5wIqzgmoyB0+69OMP8Ozx+agVgeoE4AAGhv49Zuf4x62XF68Wb/jd3VQuaCcxWlBnRHSlx1Up+9YmARxujgaPmzWh4tJ/AT9yRO305UDcQQDwo2DBJ92igHqJaHZ8m2GbvGpiam9TObOK67uPJzM2seluuAb878Ew081gA60B/E3irV+HA77LEISGvOeSt9FKsn8rKzGaCVMT28fIoPWH3B0ERxzu0vJyDrtnVC2gdTaQjohkI0Eu5URANmdP/S+qs1LVUrLfD8q6ZtdwiicLc0p/uHATrd5Wd8Ps0hraL6G/VFyIcQPQVJhcV42ltQSjO2DM/IGKZI6VkcCeu3/wPOC08oAKMNkSidN2PTi44wNrn1lmsB1yJbL9WroTzN5JAb0NlSK0ioOotPccDr+4YKqcAEBuc5I+3SNOB7mPup/OF/eKwYeonZLtHBsEzuvl/A2/6BF5hGlwnduOC+sfq6lUVLHqIS5CWMTbq9VUe5rn1BjJMAiNnrObRra5SFZ73sBs+L5SyIZ7fCqUefo7uxMhn09SmK8E3lomj6rwG16/u8SfSZ8WQ6DkYxyICPo5SxJNxTW9iH2RMxlfpA9FYmpdeKGXw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(38100700002)(82960400001)(4744005)(2906002)(44832011)(53546011)(55236004)(6506007)(6512007)(6666004)(316002)(6486002)(508600001)(4326008)(8936002)(110136005)(83380400001)(8676002)(26005)(186003)(107886003)(2616005)(66946007)(66556008)(66476007)(31696002)(86362001)(31686004)(36756003)(45980500001)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDNPdjZSUjV1bnVSMHJtZ1U2dGxoVGMzU0FvQmpzc0NhTUVlLzdiVGFGcDlF?= =?utf-8?B?VVk1bks1RTk2bTBBNlVXOFdaWUR2UzZkeDRBK2ZDUE53a2hOVTJIeWFmVXg0?= =?utf-8?B?N2hMTmIvZ1crNUZla0FsbFU4elVzVjI0R2ZVcW5pc3pIWndkSjcreXFQNTFM?= =?utf-8?B?VkhReU9yZi9BeUdHWDdyRDVudkJjanFpSytJSVRBaHlrV3VQNHZjcUlaU1pi?= =?utf-8?B?ZGpEeG9HK2FXRVE2c1Jkb3J6Unc2UDZFc0J5ckI1WWVOQ2xTRHI1Z0FSK0x3?= =?utf-8?B?akVXb1R5Q3JqTjJoQnNpU3Q3TEZucTliS1JkR0Y0NWY0ZVRlR1NVdHI2MmE4?= =?utf-8?B?T1FxUERiZUh2cGQ1aFFxc1B2TXFlZTJjeFAzRlNEV1d0Rk02RC9kUmpmUDU4?= =?utf-8?B?Z3ZoNWZ1dkE0TEdrTGZtOXlEM2Z2ZkQxNzRENVhzbktjRDBqcERYdytoMytZ?= =?utf-8?B?c3RiRmpjdW1pVFN2TW9ncVhBWEN1cWlSUXpGY0J6T3RWVzdWUkc0QjlYWjZk?= =?utf-8?B?b2piUC9XZS9IaEpMbEp1M2VMdUxQMU4rOEVjZ3dzazNQbW9tOEVWQXhyaEJt?= =?utf-8?B?cVBMZnp3ajhVTlVkQlk1MjRUQU95RU5sdWR5QnlzaWtaNmRYMGlnUEVmTS9Z?= =?utf-8?B?bGEvL2pnendOWEtuZjBHakpkMkhwTS93V2ZocVV3c0J6TXRLb0V3R05nQlhh?= =?utf-8?B?NWk1eEVWeCtpbzBxaTgyWHAxaXVtSGJJK28yNitleDZHS1p4NENKMVJUK0Iv?= =?utf-8?B?dVc0SENrMnh1a0NCbWVWcUs0MlZEQWlKcjRlYkxiQVBLRld5TmQ2NUJPQmd5?= =?utf-8?B?dm12N1k5KzNSMzluajVFMHFxamNFMy9odkFJcGFaQ1ZIM3ZnUWRaTlpUU1Er?= =?utf-8?B?MW9kazR4ZXY5elJGeG9KejZ6WWU5SUloSWVsc0dXRTQxR05VNnB6T0trRm1q?= =?utf-8?B?Z1U2bEp5Rk5EekhoeXFEUVhzT1k1NFgrOUxzcjIvOXU1Wk50ODZ0Q09nZS9q?= =?utf-8?B?eXFkNjFWNjl3WkN6UnZOMmMxU1JyWDFBTkFEVXlTazhaMGxBMWZ3Qm5ONnpZ?= =?utf-8?B?QUdJRWdHM2xrMHJGT0VMZFVuTng4NGxQa3BMVmVoaUxUdHd6aUQrS1VaZXR3?= =?utf-8?B?MVBWOGpOckF1NVl0d3p5TUJqV2pOWHUwYmJrMTZUVThHbklMUXJkaEc4V0Vy?= =?utf-8?B?T3FYSEtUd2RLdDlERkpGRmY4V2tpZHpaTGpVVVN4eGJLb053K3J4ckVaSWRB?= =?utf-8?B?d0hPUk4rU1VNN2FLSVV0ZDRKbEFZaXBCSFVDUDJjTk9QWVpycE04ZlRwcDQv?= =?utf-8?B?Z1lQT1J6ZFRXUjhQMWdNTVFXdENWTlUweG9TUHJLM0FzVUZRUUJGcFpzbW4v?= =?utf-8?B?RUs0VVZwU0FiVENFR29PdTJhRCt6cmkvcmtMYUVMZVBQOEhZS3dUNVpBaFVN?= =?utf-8?B?bW1meXByU3JiNGdxKzNMaG95ZG9zWTlmTHJ1SVpZR2txeVZaUWdyd3hFWVRQ?= =?utf-8?B?a0lidGRMVjA5Q29QOFhEZW1ORktBU3BkY3lhVjlWbmNZM2RlNDRCYnNSTkhU?= =?utf-8?B?YWFqcFhZamFyY1JMTlAwV2RHdDJhR3d2aXRRVXd4SnpWK3hzM2tDODV6akhl?= =?utf-8?B?YjRnd2NuaU5oSEJkU3RiS01BeWNza290cGV5VUoyQ0NyS3pzWVBRQlgyb1V2?= =?utf-8?B?ZHBXcDhxTW93UXgrMkZtc3FlRzQ3T2ZORDZXUU54ZUpSdmJVa1E1S1BCWWpW?= =?utf-8?B?OWpaYmpRcjBQMjgxWjd1NXhqMVRpeFVNU2VWQzJNa3pSRGxPdjVKYUNjYnFD?= =?utf-8?B?TzN6NjFKL1Z0QnQyMnczRGV4OXhuT2hsZjJYZHRHT0F5b2RyWlpWNjlKYjha?= =?utf-8?B?QlpkY3g0SXhrYS83aGNqWEYyL2NlVmdUWnBURUtvSElDWm0rTW8rRk8xZ090?= =?utf-8?B?dG5oKzZJMVJhQTNGMEs0Zm5FamJKdXlOT0dxcnlhb0YzNldTM0ZNWVZ1ZmQx?= =?utf-8?B?RkxXelAvbUIrQ210alZhcTFHNFlNTDlicVFVZUdZTFd4LzlPVjBjc1NQOGtF?= =?utf-8?B?T0t1UWpnN21hRDFpSzRqaHRSVHErNlFjN1NZdzdKQVVMVlg1TFcwUTZVV2pR?= =?utf-8?B?ZnA3eXk3YUlOZ3NWVVdXcmdlZE8rc1JoS1p2T1F3ZHI1eE8wY0xkYWhqdG9y?= =?utf-8?Q?tz4sUB/lT7sNh1Wuq8hQlCA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: dcf3a70f-c31a-4ed3-61b3-08d9e57846ac X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 11:44:59.7455 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yj9XJutbvNyBm6mhqaNRtCfoSWNcJOiXDjzTSJqBezIPP1nnOti4cnpuMaMbEZ5IFFJhpdMeoYkst+Z/e0gfag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2738 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/27/2022 9:18 AM, Min Hu (Connor) wrote: <...> > 在 2022/1/26 21:10, Ferruh Yigit 写道: >> ethdev requires device to be configured before setting MTU. >> >> In bonding PMD, while configuring slaves, bonding first sets MTU later >> configures them, which causes failure if slaves are not configured in >> advance. >> >> Fixing by changing the order in slave configure as requested in ethdev >> layer, configure first and set MTU later. >> >> Bugzilla ID: 864 >> Fixes: b26bee10ee37 ("ethdev: forbid MTU set before device configure") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ferruh Yigit > > Tested-by: Yu Jiang > > Acked-by: Min Hu (Connor) > Applied to dpdk-next-net/main, thanks.