From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F163A053A; Wed, 5 Aug 2020 16:07:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4CB791C029; Wed, 5 Aug 2020 16:07:24 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 7AEFC2C28 for <dev@dpdk.org>; Wed, 5 Aug 2020 16:07:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596636441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cLJJmpBOHFqCBE4OoECere2wRDoeTYarUuDwF8ujhhQ=; b=I+psoMYqGEssVnf1KpmoXqV6SFW0CakinbPI7DzR66wsf1QUFkA0RM8fDq2ZRV8A7dNgua EVkOAQvpkMFSl4vKix9dm0YSmT40Q+a+c2V3hryTGbObNrmduuBTR6VOZ899qr7URcVXYV 4M5qTNDV0xVNmQOTtmqD2uO43XRG9J8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-YsmnqmfYOO2Q2p_HS9kqgQ-1; Wed, 05 Aug 2020 10:07:20 -0400 X-MC-Unique: YsmnqmfYOO2Q2p_HS9kqgQ-1 Received: by mail-wm1-f71.google.com with SMTP id c184so1994016wme.1 for <dev@dpdk.org>; Wed, 05 Aug 2020 07:07:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=cLJJmpBOHFqCBE4OoECere2wRDoeTYarUuDwF8ujhhQ=; b=Iyvipi8dOghgJMvG+ZrGzfBavO2qsXZXVe//z7bsZm1JY5kzrP5Pjuban6hX8dGC7H OXF4cQ/ocTxGQ8KA72GQAbxz6iiro5lFVlK7bCLAMqVfe1Jrr6u+j2uvKufu9svT5co6 UOCLy0CIgA/QwkIREUQ9Gc9ICmrMv7dWtLcb46Y6lw1ZwTexCQuOo6PFfEFLdnMPZOOv iQd1lpcigFaPyHr6wJ8V8mCM2VvRyPRIzfIiNedyvUJP1XqK8TLEavxSlKlLpXuizKqt HAlzhFUihZhWQJiUwWIesDAIQgM6pJaG7ehuDIF8dPNq5Q841zImEGJvbfzl/7P/vjTn Uo0w== X-Gm-Message-State: AOAM533m7lG97n7yv9IAbc3ZBLwcmNxFuF8LbkMn94rLTFHqzDkYsUO3 BjbhO6S8dai6lR6iitbgoznHQZ0UXOd2vEJDlT+D3ra7p8w11BKFqXBm0GIe8NcQ2Y0LsmbK4ym tutA= X-Received: by 2002:a1c:2985:: with SMTP id p127mr3333600wmp.166.1596636438596; Wed, 05 Aug 2020 07:07:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztdZm3fHyJ5g5lw+prdGTFCXzQw1W5f0lLczd6IOMZCzw6V4u66DqFPO3Ri5qzadFk8GM9Ug== X-Received: by 2002:a1c:2985:: with SMTP id p127mr3333589wmp.166.1596636438358; Wed, 05 Aug 2020 07:07:18 -0700 (PDT) Received: from amorenoz.users.ipa.redhat.com ([94.73.63.18]) by smtp.gmail.com with ESMTPSA id w2sm3176493wre.5.2020.08.05.07.07.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 07:07:17 -0700 (PDT) To: "Xia, Chenbo" <chenbo.xia@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: "Wang, Zhihong" <zhihong.wang@intel.com>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com> References: <20200804072431.86441-1-amorenoz@redhat.com> <20200804072431.86441-2-amorenoz@redhat.com> <MN2PR11MB406335F98D50CAE0209B5A3F9C4B0@MN2PR11MB4063.namprd11.prod.outlook.com> From: Adrian Moreno <amorenoz@redhat.com> Autocrypt: addr=amorenoz@redhat.com; prefer-encrypt=mutual; keydata= mQENBF1syNUBCADQ9dk3fDMxOZ/+OQpmbanpodYxEv8IRtDz8PXw8YX7UyGfozOpLjQ8Fftj ZxuubYNbt2QVbSgviFilFdNWu2eTnN/JaGtfhmTOLPVoakkPHZF8lbgImMoch7L0fH8wN2IM KPxQyPNlX+K9FD5brHsV1lfe1TwAxmhcvLW8yNrVq+9eDIDykxc7tH4exIqXgZroahGxMHKy c8Ti2kJka/t6pDfRaY0J+6J7I1nrn6GXXSMNA45EH8+0N/QlcXhP3rfftnoPeVmpjswzvJqY FNjf/Q5VPLx7RX0Qx+y8mMB2JcChV5Bl7D7x5EUbItj6+Sy7QfOgCtPegk9HSrBCNYaLABEB AAG0I0FkcmlhbiBNb3Jlbm8gPGFtb3Jlbm96QHJlZGhhdC5jb20+iQFUBBMBCAA+FiEEogUD gihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgEC F4AACgkQd5C5fbYeFsX7qwgArGHSkX+ILNcujkVzjTG4OtkpJMPFlkn/1PxSEKD0jLuzx14B COzpg/Mqj3Re/QBuOas+ci9bsUA0/2nORtmmEBvzDOJpR5FH1jaGCx8USlY4WM6QqEDNZgTw hsy9KhjFzFjMk+oo3HyItXA+Uq9yrRBTjNBGTXxezMRcMuUZ4MIAfY0IRBglL2BufiuL43jD BvTENNFLoQ/wFV7qkFWSkv+8IjTsxr7M6XUo1QLd29Hn0dvwssN579HL1+BP46i2REpzeBEG L75iVChi+YnIQQNMJ9NYarVabZx4Y1Gn8+7B/1SNArDV+IDgnYgt7E58otoV2Ap310dmtuvE VbxGpbkBDQRdbMjVAQgAqyp9oA7WDu7/Y9T4Ommt69iZx8os7shUIfdgPEy5xrcPn6qGwN1/ HQ4j8nWfBG9uuX1X0RXUZIUEtYTxtED4yaCQMTqDUf9cBAwAA2mYxBfoiNYx8YqxM+sT0/J4 2qmDd+y+20UR4yzHE8AmIbspTzDFIJDAi+jKSR8F355z0sfW7CIMDC4ZWrPsskjEy1YN/U10 r6tRRH1kNyrCSbTG0d9MtcQO58h7DLXuzUhErB+BtG52A04t5cweIJTJC+koV5XPeilzlHnm RFoj0ncruGa9Odns21BNt3cy9wLfK+aUnWuAB1uc6bJGQPiAwjkilz7g7MBRUuIQ2Zt7HGLc SwARAQABiQE8BBgBCAAmFiEEogUDgihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwwFCQHhM4AA CgkQd5C5fbYeFsUlSwf8CH+u/IXaE7WeWxwFkMaORfW8cM4q0xrL3M6yRGuQNW+kMjnrvK9U J9G+L1/5uTRbDQ/4LdoKqize8LjehA+iF6ba4t9Npikh8fLKWgaJfQ/hPhH4C3O5gWPOLTW6 ylGxiuER4CdFwQIoAMMslhFA7G+teeOKBq36E+1+zrybI6Xy1UBSlpDK9j4CtTnMQejjuSQb Qhle+l8VroaUHq869wjAhRHHhqmtJKggI+OvzgQpDIwfHIDypb1BuKydi2W6cVYEALUYyCLS dTBDhzj8zR5tPCsga8J7+TclQzkWOiI2C6ZtiWrMsL/Uym3uXk5nsoc7lSj7yLd/MrBRhYfP JQ== Message-ID: <b5447f63-bdf3-0c92-a1f1-04aec532311c@redhat.com> Date: Wed, 5 Aug 2020 16:07:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <MN2PR11MB406335F98D50CAE0209B5A3F9C4B0@MN2PR11MB4063.namprd11.prod.outlook.com> Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=amorenoz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/virtio: add DEVICE_NEEDS_RESET status bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 8/5/20 12:52 PM, Xia, Chenbo wrote: > Hi Adrian, > >> -----Original Message----- >> From: Adrian Moreno <amorenoz@redhat.com> >> Sent: Tuesday, August 4, 2020 3:24 PM >> To: dev@dpdk.org >> Cc: Wang, Zhihong <zhihong.wang@intel.com>; Xia, Chenbo >> <chenbo.xia@intel.com>; maxime.coquelin@redhat.com; Adrian Moreno >> <amorenoz@redhat.com> >> Subject: [PATCH v2 1/4] net/virtio: add DEVICE_NEEDS_RESET status bit >> >> For the sake of completeness, add the definition of the missing status >> bit in accordance with the virtio spec >> >> Signed-off-by: Adrian Moreno <amorenoz@redhat.com> >> --- >> drivers/net/virtio/virtio_pci.h | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/net/virtio/virtio_pci.h >> b/drivers/net/virtio/virtio_pci.h >> index 74ed77e33..ab61e911b 100644 >> --- a/drivers/net/virtio/virtio_pci.h >> +++ b/drivers/net/virtio/virtio_pci.h >> @@ -57,12 +57,13 @@ struct virtnet_ctl; >> #define VIRTIO_ID_9P 0x09 >> >> /* Status byte for guest to report progress. */ >> -#define VIRTIO_CONFIG_STATUS_RESET 0x00 >> -#define VIRTIO_CONFIG_STATUS_ACK 0x01 >> -#define VIRTIO_CONFIG_STATUS_DRIVER 0x02 >> -#define VIRTIO_CONFIG_STATUS_DRIVER_OK 0x04 >> -#define VIRTIO_CONFIG_STATUS_FEATURES_OK 0x08 >> -#define VIRTIO_CONFIG_STATUS_FAILED 0x80 >> +#define VIRTIO_CONFIG_STATUS_RESET 0x00 >> +#define VIRTIO_CONFIG_STATUS_ACK 0x01 >> +#define VIRTIO_CONFIG_STATUS_DRIVER 0x02 >> +#define VIRTIO_CONFIG_STATUS_DRIVER_OK 0x04 >> +#define VIRTIO_CONFIG_STATUS_FEATURES_OK 0x08 >> +#define VIRTIO_CONFIG_STATUS_DEV_NEED_RESET 0x40 >> +#define VIRTIO_CONFIG_STATUS_FAILED 0x80 >> >> /* >> * Each virtqueue indirect descriptor list must be physically contiguous. > > Should we also define RESET(0x00) in vhost lib? I don't see the definition > there. Correct me if I'm wrong. > I'll add it in a separate patch if that's OK. > For this patch: > > Reviewed-by: Chenbo Xia <chenbo.xia@intel.com> > >> -- >> 2.26.2 > Thanks -- Adrián Moreno