From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Alexander Kozyrev <akozyrev@nvidia.com>, dev@dpdk.org
Cc: rasland@nvidia.com, viacheslavo@nvidia.com,
Xiaoyun Li <xiaoyun.li@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: refer to the supported Field IDs for modify field API
Date: Thu, 8 Apr 2021 08:54:20 +0100 [thread overview]
Message-ID: <b5544bee-df65-d923-4cef-865009120bff@intel.com> (raw)
In-Reply-To: <20210331160028.21811-1-akozyrev@nvidia.com>
On 3/31/2021 5:00 PM, Alexander Kozyrev wrote:
> Include the rte_flow_field_id enumeration reference into
> the documentation to point to the full list of all supported
> Field IDs available for the MODIFY_FIELD RTE action.
>
This patch also fixes formatting of the tables, can you please mention from it
in the commit log and add the fixes line for it?
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> doc/guides/prog_guide/rte_flow.rst | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
> index a1fdcd7c07..9fce58ea5e 100644
> --- a/doc/guides/prog_guide/rte_flow.rst
> +++ b/doc/guides/prog_guide/rte_flow.rst
> @@ -2777,6 +2777,7 @@ can be used as both source and destination fields as set by ``field``.
> The immediate value ``RTE_FLOW_FIELD_VALUE`` (or a pointer to it
> ``RTE_FLOW_FIELD_POINTER``) is allowed as a source only.
> ``RTE_FLOW_FIELD_START`` is used to point to the beginning of a packet.
> +See ``enum rte_flow_field_id`` for the list of supported fields.
>
> ``op`` selects the operation to perform on a destination field.
> - ``set`` copies the data from ``src`` field to ``dst`` field.
> @@ -2810,12 +2811,15 @@ for ``RTE_FLOW_FIELD_VALUE`` and ``RTE_FLOW_FIELD_POINTER`` respectively.
>
> .. table:: MODIFY_FIELD
>
> - +-----------------------------------------+
> + +---------------+-------------------------+
> | Field | Value |
> +===============+=========================+
> | ``op`` | operation to perform |
> + +---------------+-------------------------+
> | ``dst`` | destination field |
> + +---------------+-------------------------+
> | ``src`` | source field |
> + +---------------+-------------------------+
> | ``width`` | number of bits to use |
> +---------------+-------------------------+
>
> @@ -2823,12 +2827,15 @@ for ``RTE_FLOW_FIELD_VALUE`` and ``RTE_FLOW_FIELD_POINTER`` respectively.
>
> .. table:: destination/source field definition
>
> - +--------------------------------------------------------------------------+
> + +---------------+----------------------------------------------------------+
> | Field | Value |
> +===============+==========================================================+
> | ``field`` | ID: packet field, mark, meta, tag, immediate, pointer |
> + +---------------+----------------------------------------------------------+
> | ``level`` | encapsulation level of a packet field or tag array index |
> + +---------------+----------------------------------------------------------+
> | ``offset`` | number of bits to skip at the beginning |
> + +---------------+----------------------------------------------------------+
> | ``value`` | immediate value or a pointer to this value |
> +---------------+----------------------------------------------------------+
>
>
next prev parent reply other threads:[~2021-04-08 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 16:00 Alexander Kozyrev
2021-04-08 7:54 ` Ferruh Yigit [this message]
2021-04-08 12:32 ` [dpdk-dev] [PATCH v2] " Alexander Kozyrev
2021-04-08 13:22 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5544bee-df65-d923-4cef-865009120bff@intel.com \
--to=ferruh.yigit@intel.com \
--cc=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).