From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38F73A0579; Thu, 8 Apr 2021 09:54:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2510C1410DC; Thu, 8 Apr 2021 09:54:28 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id D316840138 for ; Thu, 8 Apr 2021 09:54:26 +0200 (CEST) IronPort-SDR: PSanrWqF3VlbijUq6FV2NvLoShP3Ps3yreZSvadIvKUpEzO9IQrMufdBi6xZIP0U8bJ9Ek9tMc plutl0OWjZBQ== X-IronPort-AV: E=McAfee;i="6000,8403,9947"; a="181023828" X-IronPort-AV: E=Sophos;i="5.82,205,1613462400"; d="scan'208";a="181023828" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 00:54:25 -0700 IronPort-SDR: xbTRK2nNfMhjs7W5Yq6zlnPZM7dz7F87fLSywV37lf4DSU/1Gtwh0Djge/D+a7hf7l2q6PmuNC B7SNjn6R63jg== X-IronPort-AV: E=Sophos;i="5.82,205,1613462400"; d="scan'208";a="380155341" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.203.5]) ([10.213.203.5]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2021 00:54:24 -0700 To: Alexander Kozyrev , dev@dpdk.org Cc: rasland@nvidia.com, viacheslavo@nvidia.com, Xiaoyun Li References: <20210331160028.21811-1-akozyrev@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Thu, 8 Apr 2021 08:54:20 +0100 MIME-Version: 1.0 In-Reply-To: <20210331160028.21811-1-akozyrev@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] doc: refer to the supported Field IDs for modify field API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/31/2021 5:00 PM, Alexander Kozyrev wrote: > Include the rte_flow_field_id enumeration reference into > the documentation to point to the full list of all supported > Field IDs available for the MODIFY_FIELD RTE action. > This patch also fixes formatting of the tables, can you please mention from it in the commit log and add the fixes line for it? > Signed-off-by: Alexander Kozyrev > Acked-by: Viacheslav Ovsiienko > --- > doc/guides/prog_guide/rte_flow.rst | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst > index a1fdcd7c07..9fce58ea5e 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -2777,6 +2777,7 @@ can be used as both source and destination fields as set by ``field``. > The immediate value ``RTE_FLOW_FIELD_VALUE`` (or a pointer to it > ``RTE_FLOW_FIELD_POINTER``) is allowed as a source only. > ``RTE_FLOW_FIELD_START`` is used to point to the beginning of a packet. > +See ``enum rte_flow_field_id`` for the list of supported fields. > > ``op`` selects the operation to perform on a destination field. > - ``set`` copies the data from ``src`` field to ``dst`` field. > @@ -2810,12 +2811,15 @@ for ``RTE_FLOW_FIELD_VALUE`` and ``RTE_FLOW_FIELD_POINTER`` respectively. > > .. table:: MODIFY_FIELD > > - +-----------------------------------------+ > + +---------------+-------------------------+ > | Field | Value | > +===============+=========================+ > | ``op`` | operation to perform | > + +---------------+-------------------------+ > | ``dst`` | destination field | > + +---------------+-------------------------+ > | ``src`` | source field | > + +---------------+-------------------------+ > | ``width`` | number of bits to use | > +---------------+-------------------------+ > > @@ -2823,12 +2827,15 @@ for ``RTE_FLOW_FIELD_VALUE`` and ``RTE_FLOW_FIELD_POINTER`` respectively. > > .. table:: destination/source field definition > > - +--------------------------------------------------------------------------+ > + +---------------+----------------------------------------------------------+ > | Field | Value | > +===============+==========================================================+ > | ``field`` | ID: packet field, mark, meta, tag, immediate, pointer | > + +---------------+----------------------------------------------------------+ > | ``level`` | encapsulation level of a packet field or tag array index | > + +---------------+----------------------------------------------------------+ > | ``offset`` | number of bits to skip at the beginning | > + +---------------+----------------------------------------------------------+ > | ``value`` | immediate value or a pointer to this value | > +---------------+----------------------------------------------------------+ > >