From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E98814317F; Mon, 16 Oct 2023 17:53:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA7EF402DA; Mon, 16 Oct 2023 17:53:08 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2064.outbound.protection.outlook.com [40.107.243.64]) by mails.dpdk.org (Postfix) with ESMTP id 6226F40269 for ; Mon, 16 Oct 2023 17:53:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T4jem6XwrNQIiXG8asBrBSaa11Ffw5RHlNI9i3cargMbDB7uV2jlMPpL1tsdrotUeX4/5CLKV/Z0eCIbMNk8tD0qr7vAp7KqwTB5fSysLJtnY0aC042wDFFeiwkIxff69KLi0rhrpFIL3dxz8YQqDMk/fkbcY/fL5Ji3tcXxd8MJbno/ZEyvEu+qIDddrtOiX+BuFiSEtPf4FbfzEJtqHXxtaermM64A6VxmWVd2TWptcNGbZfXi2FY4ZjqYMpwDpAxKg1Y9lzWHbuWWa4c+ntJpg3wqb3N08snhgxtJTyxeBE9jifJX2gajcrzzSQ4znPPGSI7IlkGKwnKUcCWz4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kF5xvgxcaSH9ZwlaknTpiPwJGOGAVBdsSFov8TKuPRM=; b=HX1xYAn4aPaYkVxzvQQEncQAj9NrF8KFINbOp8dLgdYQeFhwM/CN5OZ/rwfadNzTeAsxKXFjcebvlJKPtjTonTrpA/SkZ1e+8B2B88TO7m6bSCb8l69Yi1lUy1gCOivrwMGNyhWXP7Z79E3YM5kbm6g5BQV/DD0ZejMQfSkBB+qGpbo/MAUol0gkIe4tLfHOcASmEPPdhADvKc5zI5in75muenlRyZjTGBtdltgaifnUazT+Cr1+P/i4I6HBdcovAAyx5TmVO2zywuyra6MqlYo1nyZZNWYbMckct0W1QviTtz2dUPWVSLRPYuTrl8IFShG30y4kS1pEzJziM4nj8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kF5xvgxcaSH9ZwlaknTpiPwJGOGAVBdsSFov8TKuPRM=; b=JLNX9E1gMUDP0eh1MbCvm/Tt02qUxBNVZVfn432ZRYK0vmkr9ok3WnUYB1Uheg9/7z8XAqAzv0TmdyNXZZ1MQsTo/TYD9GUS3XypnghAAes1Ky1Dww9hXIMs9qW3B2pHyfQH2Swkd5JaKbD9C5qK6O2hIYnBxPw39dIhmn2cJdM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB7197.namprd12.prod.outlook.com (2603:10b6:806:2bd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Mon, 16 Oct 2023 15:53:05 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6863.032; Mon, 16 Oct 2023 15:53:04 +0000 Message-ID: Date: Mon, 16 Oct 2023 16:52:59 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ethdev: clarify device queue state after start and stop Content-Language: en-US To: Thomas Monjalon Cc: Andrew Rybchenko , dev@dpdk.org, David Marchand , Jie Hai , Song Jiale , Yuan Peng , Raslan Darawsheh , Qiming Yang , Ivan Malov , Huisong Li References: <20230928205930.2619353-1-ferruh.yigit@amd.com> <20231013155723.2631644-1-ferruh.yigit@amd.com> <3675930.RUnXabflUD@thomas> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <3675930.RUnXabflUD@thomas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0265.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB7197:EE_ X-MS-Office365-Filtering-Correlation-Id: fa4410ba-8e6f-4c3f-45d4-08dbce5ffbd1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oaX00SO4+thcZtOgMfjYlkPfcvDwJ0C+MDq7GWzx7ME89u1m8lhnTiEwMdYyPracaMuu05q0Yb9Adc6nTZHnlHoT6PGIdtP6cDhmcwoUJCJbI5uVpzfj+oMRAY/7Nig+jgd++bCNciV6h2Y7Wpo+Kp5rRE4Va4YJl9pyuxFV6tWdhjjCpcinenM4F5Looph0AoFB0YDy9gDIxABKTuu/OsV5QjQhTYloxBEsZ7sS5D9nTfQw/rbJcxCdAIKcWPvs4ircSm1xW0GbJjh5WNAK7mGBQfl0FYsgOsmWPerO/HoRPpWQBbvcZASdHfv/7GdvUkzaXKUWs0rKAsvOdnLHNHxd6XOMRZ3oMK7cNqeNpOH2NnmUBoNWE9tPrhXjlqPQ3ATQ5mbBfgLU2fGuEYe7Ic5YmjUxh/7qNmnXRrxgMxP3XG08c395BVjfY0eHH6koqN8GfH+YGCxtdWZyxKKl65/M2+66/zZKaCRr4dyYrEuSQvOqgHvN5bNnosFiWvx5SXa93bXhDN+vSiJuLBpaCe0DB1NQvFESPpZ7YmpuibfeENHrbWIAmU4ebCVADnt5inN+QDix/pgpK9Cohhe3Q8Fqjn+thhAM6oH6RLKHByoAlLVvnpdZvx7KFLaLJkKI/GWBlW4CD9UkBtwIKTZ6zw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(396003)(346002)(136003)(39860400002)(230922051799003)(64100799003)(186009)(1800799009)(451199024)(26005)(6506007)(66556008)(83380400001)(44832011)(36756003)(66946007)(66476007)(316002)(54906003)(6916009)(38100700002)(2616005)(86362001)(6512007)(53546011)(31686004)(478600001)(6486002)(8936002)(31696002)(6666004)(2906002)(7416002)(5660300002)(8676002)(4326008)(41300700001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVBveU4xM3AxK3JWMTZnUHJIbi9BaU8wY1RPY252aGh1M2Q4OGxodWNHRVRx?= =?utf-8?B?K2RoaWdidUV1a2tDeDVsK1BtMCtFc2F0M094TGIybGRJZHIxQzRyQ1hEeVpX?= =?utf-8?B?RDV3ZnpwTzlKZVlHWHlIampGMGtZVVFEd2lMUU9YQnRWeG0xdUtSbEc4WnVE?= =?utf-8?B?TTBmYkZiMktTVS81NUxaYVY4N0RwTDRESVJOUjFORGRUOFhxUk1DUzgxYlcv?= =?utf-8?B?bCtXaE1QUnk5b2V4YUlvcGNJRW5PYUpzOUJsUUhaemgyVFdsWTUrYVI3Y2ow?= =?utf-8?B?elQ0WmM0RnJzY3BwWGtURURQeDZoSmlzR01HdmF3Z2lQUVRTMHN4UXF5YlRq?= =?utf-8?B?aE9zcGYxMWVwK3doVmNmRnJkTUFxMTlQVWJOMDM5QUZpUjhZR3BGUzdhWTNq?= =?utf-8?B?dUZ5REpLaEFjR2h4cHNaSktJNUViR1c5MDA3VFVYalFrQWxrOW1xcjd0d2Zj?= =?utf-8?B?YmhicWoyelQyTnpaRnRLTmpOZG9ncUNES1JramZCZlF5TzJRckU5bnpLcG12?= =?utf-8?B?VEpyVXVJbGg0dlc2RzlmSEV4SE45YnFWanJTcGhuWm5URDIzbWVtd0dMZXdN?= =?utf-8?B?N08vMlpVSThQYTQ2dVdKd3FoR1lrS1kvVmpTY0xBR1ZSVi9PLzZGT1VUOXNv?= =?utf-8?B?NWY0U1VMeGVFRWhoa28zUU8rQnRFYVhCK2tWU3NJK0g1dUFRZWZnNE9XMXRY?= =?utf-8?B?NkdPZ3ZHdEJkSytUN0h5TGp3U0ZpaDJOSDlQWnV0d2xkZ3ZTdzdnTmVnNktR?= =?utf-8?B?OVJFN3l1ZmlVVlhMSW42M21hNmJvT29WblArYkpGcDdYK0Z0TXBZWW0vL212?= =?utf-8?B?K1Y5ZU5wWEZCUGplQlVMYTA5cWhlZEYzWGZwc0RQbmFaM2hqOFkzN0k2Qno3?= =?utf-8?B?bkZFL3V1Y0pPaXFHTG5CSXB6K2d3ZnNrUlVSYXo4cHcxL3pBWkJEV05ybHNl?= =?utf-8?B?c1N1dTJJZHVYeXM3bE1xMjBWYWNUTmxDcllMdmdxZ092YUFadUVxWUR3ZFkv?= =?utf-8?B?QjExL1haemhsSFdBdnM5a1JJUVRmL1lORk84YnZCNktqWmVHRWhBQ0tIWTNG?= =?utf-8?B?Zlcxc285RmI0aHJnMU44SUZ0eUtiMDJvWmQzSlIvNzk5YytzcGN6cE5zRXo3?= =?utf-8?B?emtZTWxFU1RBc0VLcmtSN3dkdjZqZ3hDWkN6S3ZEY3BwZHZvSWQrUlh6eE1Z?= =?utf-8?B?eldFZXhKUjN3RitVRFZ5NFRTTFJmNGFFRGZiOEVjQXpMSGVUVDZ4WnhBbTI0?= =?utf-8?B?N2ZTUW1UNlRpSTJLV2JpVzBYeE53bGMzQnpuRTRDQlZtYkNFSmhKM2ppbk1Y?= =?utf-8?B?bllWR3VTSmtLWU05VVVaY1RuSkk0ZEk5cS9RRFUvR0V2QWVVVlA4Q0dGRU5L?= =?utf-8?B?cDNXWTd4ZlpJVFBlZHNoTnkvOTZYU3F1bVErVWZDaWphbFIvRWZRMWhwL3ZL?= =?utf-8?B?bGlOazlmeGVsOVNQaURnaElRK0ZMQ29uYlVjbUFwbmFzTzRwRmk1cDIvaExL?= =?utf-8?B?dFJZVHZFMGpycGhJbTF1M3ovYW9vM2FtMFEvZFF4bHRTWEcrVmZWWjkyc3d4?= =?utf-8?B?eHFWaisyWXVkWW5zUzk3U0tKWGtjWmF5STNncml5WmJZem1PQ25zc3VJMkto?= =?utf-8?B?RWtHdTRqK291YnZHUS9EUEYvTTEwRXJqekJJODRiWlBBRDYxUVU1VzJQK1do?= =?utf-8?B?WEFqQmdvVHkwVHFoMWwyTjVlejFJb29NMG9hb0V6UnNEWXA3b2pWM2c3bnhR?= =?utf-8?B?VDhrVlRtdTlBelNRVW5ZKzVzaS9CM25IRjA5L3ZzaDVzMXBFcXNmWkpWUnNK?= =?utf-8?B?UFJ5NS9XcGtEY2JMbXIzSlYwV2I4eGNRNGVkZmF0YkpVNTB6MEJqR0RiVkdM?= =?utf-8?B?SGxPMGRlY0JnbWhuSmhuNmNOaEZNOWNtdHRtVjZsUlhSWjB4aGxKeWp3RTRE?= =?utf-8?B?cFZtaFRORnp4Y0FGZVVGNGRzSEM4bTlyUzViNE9ZcUliLzJvdFlYWi9XQjA2?= =?utf-8?B?N2RWcXZlQ3Y2MXBMZW96U3FZWEpVWnVpaW5zNkpISEtWT09mNm9wcjVtWnFt?= =?utf-8?B?Tkd0L25PTm1Gc0NEcWovOG51L28wa2NsRzd5TDZTeU9lVUpJTG1lNXlxOGsy?= =?utf-8?Q?7dy/ODfUidB9zvTBPb5yJNssQ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa4410ba-8e6f-4c3f-45d4-08dbce5ffbd1 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 15:53:04.7348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: grlWElIF6xmMmGFeXHtsptTSw1N1bHjX8O9B1PJQKca04AFvVbX/G3WmhMxKXIGe X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7197 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/16/2023 3:59 PM, Thomas Monjalon wrote: > 13/10/2023 17:57, Ferruh Yigit: >> Drivers start/stop device queues on port start/stop, but not all drivers >> update queue state accordingly. >> >> This becomes more visible if a specific queue stopped explicitly and >> port stopped/started later, in this case although all queues are >> started, the state of that specific queue is stopped and it is >> misleading. >> >> Misrepresentation of queue state became a defect with commit [1] that >> does forwarding decision based on queue state and commit [2] that gets >> up to date queue state from ethdev/device before forwarding. >> >> [1] >> commit 3c4426db54fc ("app/testpmd: do not poll stopped queues") >> >> [2] >> commit 5028f207a4fa ("app/testpmd: fix secondary process packet forwarding") >> >> This patch documents that status of all queues of a device should be >> `RTE_ETH_QUEUE_STATE_STOPPED` after port stop and their status should >> be`RTE_ETH_QUEUE_STATE_STARTED` after port start. > > It is so basic that it may look stupid :) > Yes we still have to enforce such basic things, thank you for this work. > >> +REGISTER_TEST_COMMAND(ethdev_api, test_ethdev_api); > > Maybe add a comment here to explain it is not part of basic suites, > waiting for all drivers being compliant. > Following comment added while merging: /* TODO: Make part of the fast test suite, `REGISTER_FAST_TEST()`, * when all drivers complies to the queue state requirement */ >> + * All device queues (except form deferred start queues) status should be >> + * `RTE_ETH_QUEUE_STATE_STARTED` after start. >> + * >> * On success, all basic functions exported by the Ethernet API (link status, >> * receive/transmit, and so on) can be invoked. >> * >> @@ -2828,6 +2831,8 @@ int rte_eth_dev_start(uint16_t port_id); >> * Stop an Ethernet device. The device can be restarted with a call to >> * rte_eth_dev_start() >> * >> + * All device queues status should be `RTE_ETH_QUEUE_STATE_STOPPED` after stop. >> + * > > Acked-by: Thomas Monjalon > > Applied to dpdk-next-net/main, thanks.