From: "Wei Hu (Xavier)" <xavier_huwei@163.com>
To: Ruifeng Wang <Ruifeng.Wang@arm.com>
Cc: "Wei Hu (Xavier)" <huwei013@chinasoftinc.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
"xavier.huwei@huawei.com" <xavier.huwei@huawei.com>
Subject: Re: [dpdk-dev] [PATCH v5 2/2] test/cpuflag: add new flags for ARM64 platform
Date: Thu, 20 Aug 2020 08:39:18 +0800 [thread overview]
Message-ID: <b55c9415-5801-fc30-e515-538e683606ec@163.com> (raw)
In-Reply-To: <HE1PR0801MB202534AD3FD8493433491ED49E5D0@HE1PR0801MB2025.eurprd08.prod.outlook.com>
Hi, Ruifeng Wang
On 2020/8/19 16:11, Ruifeng Wang wrote:
>
>> -----Original Message-----
>> From: Wei Hu (Xavier) <huwei013@chinasoftinc.com>
>> Sent: Wednesday, August 19, 2020 3:04 PM
>> To: dev@dpdk.org
>> Cc: nd <nd@arm.com>; Honnappa Nagarahalli
>> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
>> <Ruifeng.Wang@arm.com>; jerinjacobk@gmail.com;
>> xavier.huwei@huawei.com
>> Subject: [PATCH v5 2/2] test/cpuflag: add new flags for ARM64 platform
>>
>> From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
>>
>> This patch adds new flags into the test_cpuflags() functions for ARM64
>> platform, such as RTE_CPUFLAG_SVE, etc.
>>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>> ---
>> v4 -> v5: Use double '\t' for better alignment.
>> v4: Initial patch.
>> ---
>> app/test/test_cpuflags.c | 39
>> +++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>>
>> diff --git a/app/test/test_cpuflags.c b/app/test/test_cpuflags.c index
>> 06718631f..7c71ffef1 100644
>> --- a/app/test/test_cpuflags.c
>> +++ b/app/test/test_cpuflags.c
>> @@ -118,6 +118,45 @@ test_cpuflags(void)
>>
>> printf("Check for ATOMICS:\t");
>> CHECK_FOR_FLAG(RTE_CPUFLAG_ATOMICS);
>> +
>> + printf("Check for SVE:\t\t");
>> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVE);
>> +
>> + printf("Check for SVE2:\t\t");
>> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVE2);
>> +
> Sorry if I didn't make it clear.
> In v4, I meant we need double '\t' when checking for 'SVE' and 'SVE2' to align the check results with that of other flags.
> You can check this by running cpuflags_autotest.
>
OK, I got it.
Thanks for you detail description.
Regards
Xavier
> Thanks.
> /Ruifeng
>> + printf("Check for SVEAES:\t\t");
>> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEAES);
>> +
>> + printf("Check for SVEPMULL:\t\t");
>> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEPMULL);
>> +
>> + printf("Check for SVEBITPERM:\t\t");
>> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEBITPERM);
>> +
>> + printf("Check for SVESHA3:\t\t");
>> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVESHA3);
>> +
>> + printf("Check for SVESM4:\t\t");
>> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVESM4);
>> +
>> + printf("Check for FLAGM2:\t\t");
>> + CHECK_FOR_FLAG(RTE_CPUFLAG_FLAGM2);
>> +
>> + printf("Check for FRINT:\t\t");
>> + CHECK_FOR_FLAG(RTE_CPUFLAG_FRINT);
>> +
>> + printf("Check for SVEI8MM:\t\t");
>> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEI8MM);
>> +
>> + printf("Check for SVEF32MM:\t\t");
>> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEF32MM);
>> +
>> + printf("Check for SVEF64MM:\t\t");
>> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEF64MM);
>> +
>> + printf("Check for SVEBF16:\t\t");
>> + CHECK_FOR_FLAG(RTE_CPUFLAG_SVEBF16);
>> #endif
>>
>> #if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686)
>> --
>> 2.27.0
next prev parent reply other threads:[~2020-08-20 0:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 12:47 [dpdk-dev] [PATCH v2] lib/librte_eal: support SVE flag on ARM64 Wei Hu (Xavier)
2020-08-17 13:07 ` Jerin Jacob
2020-08-18 2:47 ` Wei Hu (Xavier)
2020-08-18 2:43 ` [dpdk-dev] [PATCH v3] eal/arm64: update CPU flags Wei Hu (Xavier)
2020-08-18 3:41 ` Ruifeng Wang
2020-08-18 5:07 ` Jerin Jacob
2020-08-18 8:05 ` Wei Hu (Xavier)
2020-08-18 8:06 ` Wei Hu (Xavier)
2020-08-18 8:09 ` [dpdk-dev] [PATCH v4 0/2] update CPU flags for arm64 platform Wei Hu (Xavier)
2020-08-18 8:09 ` [dpdk-dev] [PATCH v4 1/2] eal/arm64: update CPU flags Wei Hu (Xavier)
2020-08-19 2:27 ` Ruifeng Wang
2020-08-18 8:09 ` [dpdk-dev] [PATCH v4 2/2] test/cpuflag: add new flags for ARM64 platform Wei Hu (Xavier)
2020-08-19 2:26 ` Ruifeng Wang
2020-08-19 7:09 ` Wei Hu (Xavier)
2020-08-19 7:04 ` [dpdk-dev] [PATCH v5 0/2] update CPU flags for arm64 platform Wei Hu (Xavier)
2020-08-19 7:04 ` [dpdk-dev] [PATCH v5 1/2] eal/arm64: update CPU flags Wei Hu (Xavier)
2020-08-19 7:04 ` [dpdk-dev] [PATCH v5 2/2] test/cpuflag: add new flags for ARM64 platform Wei Hu (Xavier)
2020-08-19 8:11 ` Ruifeng Wang
2020-08-20 0:39 ` Wei Hu (Xavier) [this message]
2020-08-19 10:56 ` [dpdk-dev] [PATCH v6 0/2] update CPU flags for arm64 platform Wei Hu (Xavier)
2020-08-19 10:56 ` [dpdk-dev] [PATCH v6 1/2] eal/arm64: update CPU flags Wei Hu (Xavier)
2020-10-12 3:30 ` Wei Hu (Xavier)
2020-08-19 10:56 ` [dpdk-dev] [PATCH v6 2/2] test/cpuflag: add new flags for ARM64 platform Wei Hu (Xavier)
2020-09-01 1:42 ` [dpdk-dev] [PATCH v6 0/2] update CPU flags for arm64 platform Wei Hu (Xavier)
2020-09-03 3:11 ` Wei Hu (Xavier)
2020-09-14 6:00 ` Wei Hu (Xavier)
2020-09-28 0:49 ` Wei Hu (Xavier)
2020-09-30 1:44 ` Ruifeng Wang
2020-10-09 6:34 ` Wei Hu (Xavier)
2020-10-13 16:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b55c9415-5801-fc30-e515-538e683606ec@163.com \
--to=xavier_huwei@163.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=huwei013@chinasoftinc.com \
--cc=jerinjacobk@gmail.com \
--cc=nd@arm.com \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).