From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E051EA0C43; Mon, 15 Nov 2021 11:07:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6772A40E01; Mon, 15 Nov 2021 11:07:09 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 820C440141 for ; Mon, 15 Nov 2021 11:07:07 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="257162167" X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="257162167" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 02:07:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="644792986" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 15 Nov 2021 02:07:06 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 02:07:06 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 02:07:05 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 15 Nov 2021 02:07:05 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 15 Nov 2021 02:07:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oY8JaeesKt6ETL1QTTOEWSbLwyS0D6Jqu3eYoRMdd0IHNu3wEf4KW4BUppfmPw1zAznk6NHzrz+4vXe3nxAwObSQU+4q7LvbeMp5Qf+k1AguoWxeuz6MQVNMQYQiBXeCHwRKtYuxG6KVsaADgICsK9U9/pjubltGL0/Dmfwzr85FniVna7Uj3ECTHCXdyjvsuqciY2Ck3WGGyDm86PQw7y1NBCHocxPQpIE6rIZpVDXC4s27MStVEQR/eElO87HkTruEXiKx4aaaNe/CeQnoMhxEV5amEmgyB55R1EPvYsLZUIVp1OqwZjV1RvcxwbMBUEpwov8jVlO7gRFLhnjVAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mtq0RDUtsJRHBn6fGwPJxi4oEwcTj4eEwzrKHc2Np50=; b=b7xGoPtBsLO5Y0/aIU5OVH83nVpNKMrk/uUzpZcYtoloUCFwA85kw6EjrJEpoKjk/APriXIiHzp9Cp1bkqf1+hyqFu2EFpDYqDIXRoF757OnB0Q0ZwBS2d0CuCuTnnSdDCeJYq3n2I8pFxxCm1BecuVccC1ZqrQtRFO7QOFpHKmCBw7Hia0ro9ShieIp/7yHGSaTQxWB90dTd0cefkknWcCbexxDWlWdE4fuXyexzQJDelBWpU/TqP6gEG2FMPKLgOmzN9H/EXWMiq2Oqwj3wt+CIyGzKC67vTdq+uFDG9Xzo4qoPp6ii17LGt605o2GtAtracWquZKiib12rSD6og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mtq0RDUtsJRHBn6fGwPJxi4oEwcTj4eEwzrKHc2Np50=; b=dJn8jZMH5wMe2tw5oQVvgkxNn6uGgBCVWFqOVtFvUv84njVnFqcZRNk6j4RQZfE9TyCO2Qmv//bhMq4iLWrykg3yRDTDHrQQALwPbobsll+FDADCEPSdmKo8mXsrJoLBv7Phrk/IBOxT1/vhsdWAy/WWEq02hj6DHc/lFgXYdi8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.19; Mon, 15 Nov 2021 10:07:04 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.027; Mon, 15 Nov 2021 10:07:04 +0000 Message-ID: Date: Mon, 15 Nov 2021 10:06:58 +0000 Content-Language: en-US From: Ferruh Yigit To: Apeksha Gupta , , CC: , , References: <20211109113432.11876-6-apeksha.gupta@nxp.com> <20211110074829.16654-1-apeksha.gupta@nxp.com> <20211110074829.16654-4-apeksha.gupta@nxp.com> Subject: Re: [PATCH v9 3/5] net/enetfec: support queue configuration X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR1001CA0038.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::24) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR1001CA0038.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Mon, 15 Nov 2021 10:07:02 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7ece947c-5bc1-42a3-63b1-08d9a81fac74 X-MS-TrafficTypeDiagnostic: PH0PR11MB5013: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3173; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7yjPVhL4VU8xzKvA5jFKkcAWJ/pRSLY8fbUoXzTfe7ezrOMBJ2Q/OepRiZwCMBi+9vjl6/X7+5QhaSyTIQ9nBBUpWdi9vi2wkh+/wDjSHwHurou5yD6CeIw00dPEjsswiopt6RjsOqOyLDKzvgwetJ7aRRnn3tsY1H1TG/Lswwq50fHI0SV7xZMbOKLyA1GrzCiawIn37I6csnP6bdIQme1pVJrWOVRk631dD/xFgRc2v1Lc9WvBmREq/iUogh4fS/qzPw9td4qs7nz7ON0dZEmOELhIk7BKwSAnsrlq6n9exw9CPN34dm2/1TkFScecB6ddQWL88qqgnaMoYFfFZnKvq/sr+evgnX7DCfLcugZ74Q0PTBcRRI7o0CdmccoiF7v1M66Uj2k2fBkS9Tstg0N/Z7vmjjorELqTeUyJeo3c+LejFYBrH/0QTNghIFC9Rgmluvtt9A8hwf45BAXZDtqAu/SGOZF+byMQghOypW94h/WEAAJ77r0sn8zAtAS+3vGKn7Xv8cTZSZTma8GpB9bG41beFZQqTbpiXdXUMAvhFRp1m4EWKDFVpFknz4tGzlF9YewbWyg5J7J/2Zm3a2p30moZodoHSTZAwgFmoGuznYfFZCjTK9dnH1QAC5SBqircyy5fyGWHRqGwSgfl72XsGmXmURQPwpXvVAEUy/QqNam/Fl4+ut78SIvmGAFaYgTgFib6KdVbkhRvpWVC7w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6486002)(26005)(8676002)(31686004)(8936002)(16576012)(316002)(31696002)(508600001)(4326008)(38100700002)(6666004)(5660300002)(36756003)(66946007)(2616005)(2906002)(956004)(86362001)(66556008)(186003)(66476007)(82960400001)(44832011)(53546011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjdpOWh5ZmMxWTF4YWxjWThkaTk0R1lIZkxxamptN2lOVE1rc0FaT3BqYzRu?= =?utf-8?B?bFpuZ2JidGY2OXNwRWpxM1NmNytuamZqSmNjSTNtMFdLL0k4RVp2QkFMMUtL?= =?utf-8?B?cDRKSmhYbUJ5bzFZUW9ESXdmYWZwNHpOMFdDRzR4ZG4zN0xYMDFQemZXSFlZ?= =?utf-8?B?dlVQNjM1S3RRZkZ2bnJLcTA3cHpKTEcrWlZ2Mnh4TStDbDRLeGVaQnc3aVBN?= =?utf-8?B?UWZQYVdYZGgvbDZFZVFsdFBraXdEVDhkTkFYNkV2US93cldBYUR0RGx1YXFQ?= =?utf-8?B?SHR6Q3Q2VElkYmpMcmpXMSsyZTErY1U3L3dmZlFhbmIzYldLNXhpVzFIVEdw?= =?utf-8?B?SGkraGdWeFFET2Y0R01KOTdRZzdqZVBNeUZrQUY4Z05kNUR2TEttNFphWmE2?= =?utf-8?B?aGVSUTBxQlcvU0t4ZWsra2daN3RFdDc0RFZ1Yy9TT3lvWS8venhKcnRINU92?= =?utf-8?B?Ui9BanBOSXhqQU9ncW1wbDNiL0VWTjIyaEpNUmtxYTV2a1BNcEtjSHBUakhl?= =?utf-8?B?Rng5dTBqNTJPV0xDL3ZPWTBwYytYQTU0VXo4aG92cFFvZkg0MDNpbkRkM29q?= =?utf-8?B?eGFxTWhjMTBWckk2eEhpVjYxc000cTlrRE9ha21VRkZMU1JWSUd4ZCtyaTE1?= =?utf-8?B?LzR3MVQ3djBvcUd0bW03QW84bFNWdCtiUEU1cjB2ZlF6bkRsdmtQOEhFQVhq?= =?utf-8?B?RmFocWhjYmlrb2pyRjhWajJZOWtsZXM0VE9HbFVoWkNGNEc2NEF3S3F6aVRO?= =?utf-8?B?VVBrdVMvYTd2YVNIaTE0TmtFbkYvcXJKQmlla1JBZVFvL0JzWnRxUFNYSUc0?= =?utf-8?B?QnVpVExwa1Jnbnh6L25zZXpYTDVWTHRQLzVCNytzcjJNM0Ric2hLWDhKNzNG?= =?utf-8?B?am4rYVdvWUlBaVQyY3k4Mk1KTGhnV0V2aVVOZVI0d3prTDBqUWhRancvdklZ?= =?utf-8?B?VVRXQmk3eTE0WmNObDZLd2xIc0tQWFRXQTl5d1Yyb2hmMnRvMnRSZENrL1ZV?= =?utf-8?B?QkNkdjN0Y2NoNFd5MzQvOGVSL0ZZdVNIbmRCcSthb3doYSs2MncrZmtZSitI?= =?utf-8?B?UlQ5ZXBSVEJ6Q0R1VFpTc2dVdHNSd3ZGdFdGK2ZIalhETGpkdENtWnJjSE5u?= =?utf-8?B?L0tsdFJDaUE4dGZ6Y1JvQ2t0Yk81YnlWdks3eUtJa0Q4SnRsVDUzc2wzRTJK?= =?utf-8?B?QTJSTWdYRlJ3OWhURjZtbGVWRWFGYUoyTjhmbHl0UEdHWVhLNUU1RnpVZjdV?= =?utf-8?B?c29yK0JmR0k5aDNpSWk0RGxxU2p5eU56bXpzNkwyM211L1JBQUwyZE5xVndt?= =?utf-8?B?anJvUnVvbUFKVzRibENRb3NVcHUwdXQvVjZ2RmVzelFYcVFFT1VhckQ2VUox?= =?utf-8?B?VlNxZGpEbG05WEdXcDFOc0dzc3grSWg5WVBGa0t0anltN1FzclB5ejVWa1VD?= =?utf-8?B?VTNDQXJZRlR2NUVLdGlROW4zd0I0SkQ5RGNSTkgrYytaKzhhcTArNzl0K2xU?= =?utf-8?B?ckhhaU1ZRGZXOTNyd0szcjR4azlCLzREam5Nc0wrbjVKTFVoU2ZtWitUYzU1?= =?utf-8?B?NTA1blBLMUpVYXVPTUZmT0JWbjRzamlyUjhFWHlTdHA5QS9LbG9CMnJJRnhP?= =?utf-8?B?d3V1aWNaaXdVcDYwTXlldXNZYWpFcGcvb0dnYWUxSzNWcjBoai9VcEpSQUkz?= =?utf-8?B?aTFwd0gwaTBLRk9xOXpUV3YySTdEZlFqbFBGK1dudkpnaS9BdkZHN282ODVv?= =?utf-8?B?b2ptbzhjendNNEhONDc0WjhRR05FY2Z0MmNpUlAxTktVS3BJVE9aSVh3VHhE?= =?utf-8?B?TWg2UFVUZkRicWhCQ1I0dlIzYmFEcUdSU25yQ0pwYXFHZWIzY1JKOThJSGc4?= =?utf-8?B?OWJ3VDI0QmxjZnNNTUNzNUVXbUEwaGYrY2FmYVIvMFd3VW1vZStWVFlxbmFK?= =?utf-8?B?Y051d1hnb0E0UlJyUTBiMkNLOXFCdExEbU9QSFZ2L3ZFQnVGMzdVbVd0VENL?= =?utf-8?B?WCtUOWVTWlp5Q0FlbHdSTGc0Wno4djlPaVZRd2cyNWlIS0NFc1lETVQ3U25V?= =?utf-8?B?czhpSGFpRkcvTTlYOUJXY2VGaWRUcG9YV1NyR3BGT01ySjBCSzdwV3lVNGNP?= =?utf-8?B?Qk9ON3EyNnRETWljNFpsT3pwYzhGaUNydnYzTU5mTTVDZTF3aVVXR3A4b25U?= =?utf-8?Q?S02sTBpR7+RALCfhT3va4mM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7ece947c-5bc1-42a3-63b1-08d9a81fac74 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 10:07:04.2766 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R6rkjKmdEJgUYDAEpLXK6D3j7ksRKecURDJM3LgH8lqGf06gtM7D+T7LJ8KlcJq4en3ewzsK0bBB5d/1Q5zDhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5013 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/10/2021 1:54 PM, Ferruh Yigit wrote: > On 11/10/2021 7:48 AM, Apeksha Gupta wrote: >> This patch adds Rx/Tx queue configuration setup operations. >> On packet reception the respective BD Ring status bit is set >> which is then used for packet processing. >> >> Signed-off-by: Sachin Saxena >> Signed-off-by: Apeksha Gupta > > <...> > >> + >> +    rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_t[queue_idx]), > > Isn't 'fep->bd_addr_p_t[]' a 64-bit value? > > <...> > >> + >> +    rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_r[queue_idx]), > > Isn't 'fep->bd_addr_p_r[]' a 64-bit address, why doing endianness operation > only on 32-bit and writing only 32-bit of it to register? Hi Apeksha, Above comments seems not addressed in v10 & v11, unfortunately this keep happening in this set. Above lines are causing a build error for gcc12, can you please check: ../drivers/net/enetfec/enet_ethdev.c:482:9: error: array subscript 1 is above array bounds of ‘uint32_t[1]’ {aka ‘unsigned int[1]’} [-Werror=array-bounds] 482 | rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_r[queue_idx]), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 483 | (uint8_t *)fep->hw_baseaddr_v + ENETFEC_RD_START(queue_idx)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from ../drivers/net/enetfec/enet_ethdev.c:18: ../drivers/net/enetfec/enet_ethdev.h:114:33: note: while referencing ‘bd_addr_p_r’ 114 | uint32_t bd_addr_p_r[ENETFEC_MAX_Q]; | ^~~~~~~~~~~ ../drivers/net/enetfec/enet_ethdev.c:482:9: error: array subscript 2 is above array bounds of ‘uint32_t[1]’ {aka ‘unsigned int[1]’} [-Werror=array-bounds] 482 | rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_r[queue_idx]), | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 483 | (uint8_t *)fep->hw_baseaddr_v + ENETFEC_RD_START(queue_idx)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from ../drivers/net/enetfec/enet_ethdev.c:18: ../drivers/net/enetfec/enet_ethdev.h:114:33: note: while referencing ‘bd_addr_p_r’ 114 | uint32_t bd_addr_p_r[ENETFEC_MAX_Q]; | ^~~~~~~~~~~