From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jim Harris <james.r.harris@intel.com>,
dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com,
zhihong.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] vhost: add experimental flag
Date: Fri, 27 Sep 2019 20:31:31 +0100 [thread overview]
Message-ID: <b5af7497-60fc-639a-7159-2801a36084e0@intel.com> (raw)
In-Reply-To: <156931701484.14501.959600637205964114.stgit@jrharri1-skx>
On 9/24/2019 10:23 AM, Jim Harris wrote:
> This function is listed under EXPERIMENTAL in the
> rte_vhost_version.map, so it needs to be marked
> with __rte_experimental in the header file as well.
>
> Found by check-experimental-syms.sh when trying to compile
> DPDK with -finstrument-functions. This script didn't
> catch this in the normal case, since the function is
> declared __rte_always_inline.
>
> This also requires updating the vhost_scsi example to allow
> use of this newly marked experimental API.
>
> Signed-off-by: Jim Harris <james.r.harris@intel.com>
> ---
> examples/vhost_scsi/Makefile | 2 ++
> examples/vhost_scsi/meson.build | 1 +
> lib/librte_vhost/rte_vhost.h | 1 +
> 3 files changed, 4 insertions(+)
>
> diff --git a/examples/vhost_scsi/Makefile b/examples/vhost_scsi/Makefile
> index c5aec269e..6015c0241 100644
> --- a/examples/vhost_scsi/Makefile
> +++ b/examples/vhost_scsi/Makefile
> @@ -27,6 +27,8 @@ CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)
> LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)
> LDFLAGS_STATIC = -Wl,-Bstatic $(shell $(PKGCONF) --static --libs libdpdk)
>
> +CFLAGS += -DALLOW_EXPERIMENTAL_API
example still fails to build, option needs to be enabled in the 'else' leg of
the makefile, I am fixing while merging to next-net.
prev parent reply other threads:[~2019-09-27 19:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 9:37 [dpdk-dev] [PATCH] vhost: add __rte_experimental to rte_vhost_va_from_guest_pa Jim Harris
2019-08-21 5:19 ` Tiwei Bie
2019-09-18 13:12 ` Maxime Coquelin
2019-09-23 15:41 ` Ferruh Yigit
2019-09-23 23:26 ` Harris, James R
2019-09-24 16:04 ` Ferruh Yigit
2019-09-24 16:05 ` Maxime Coquelin
2019-09-24 9:23 ` [dpdk-dev] [PATCH v2] vhost: add experimental flag Jim Harris
2019-09-27 7:50 ` Maxime Coquelin
2019-09-27 9:48 ` Maxime Coquelin
2019-09-27 19:31 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5af7497-60fc-639a-7159-2801a36084e0@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=james.r.harris@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).