From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: Chenbo Xia <chenbo.xia@intel.com>
Subject: Re: [PATCH v3 2/4] vhost: make NUMA reallocation code more robust
Date: Tue, 26 Jul 2022 10:39:35 +0200 [thread overview]
Message-ID: <b5b9757f-9fb8-8c82-b2b6-4c95940e4ddd@redhat.com> (raw)
In-Reply-To: <20220725203206.427083-3-david.marchand@redhat.com>
On 7/25/22 22:32, David Marchand wrote:
> translate_ring_addresses and numa_realloc may change a virtio device and
> virtio queue. Callers of those helpers must be extra careful and refresh
> any reference to old data.
>
> Change those functions prototype as a way to hint about this issue and
> always ask for an indirect pointer.
>
> Besides, when reallocating the device and queue, the code already made
> sure it will return a pointer to a valid device. The checks on such
> returned pointer can be removed.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/vhost/vhost_user.c | 144 +++++++++++++++++++----------------------
> 1 file changed, 66 insertions(+), 78 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2022-07-26 8:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 13:53 [PATCH 1/2] vhost: keep a reference to virtqueue index David Marchand
2022-07-22 13:53 ` [PATCH 2/2] vhost: stop using mempool for IOTLB David Marchand
2022-07-22 14:00 ` [PATCH 1/2] vhost: keep a reference to virtqueue index David Marchand
2022-07-22 15:13 ` David Marchand
2022-07-25 7:11 ` [PATCH v2 " David Marchand
2022-07-25 7:11 ` [PATCH v2 2/2] vhost: stop using mempool for IOTLB cache David Marchand
2022-07-25 20:32 ` [PATCH v3 0/4] vHost IOTLB cache rework David Marchand
2022-07-25 20:32 ` [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation David Marchand
2022-07-26 7:55 ` Maxime Coquelin
2022-09-13 15:02 ` Maxime Coquelin
2022-09-14 1:05 ` Xia, Chenbo
2022-09-14 7:14 ` Maxime Coquelin
2022-09-14 9:15 ` Thomas Monjalon
2022-09-14 9:34 ` Maxime Coquelin
2022-09-14 9:45 ` Thomas Monjalon
2022-09-14 11:48 ` Maxime Coquelin
2022-07-25 20:32 ` [PATCH v3 2/4] vhost: make NUMA reallocation code more robust David Marchand
2022-07-26 8:39 ` Maxime Coquelin [this message]
2022-07-25 20:32 ` [PATCH v3 3/4] vhost: keep a reference to virtqueue index David Marchand
2022-07-26 8:52 ` Maxime Coquelin
2022-07-26 10:00 ` David Marchand
2022-07-25 20:32 ` [PATCH v3 4/4] vhost: stop using mempool for IOTLB cache David Marchand
2022-07-26 9:26 ` Maxime Coquelin
2023-02-17 7:42 ` Yuan, DukaiX
2022-09-15 16:02 ` [PATCH v3 0/4] vHost IOTLB cache rework Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5b9757f-9fb8-8c82-b2b6-4c95940e4ddd@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).