From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8AFBA00C4; Tue, 26 Jul 2022 10:39:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9119140DDD; Tue, 26 Jul 2022 10:39:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3E72740695 for ; Tue, 26 Jul 2022 10:39:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658824778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=22haK0X8DyXhYFtaTVWhlqEvCeIYS68j/0RG+pRK5AM=; b=T+Uov3LoxO10tJll13aLtNJ4KDmX/VC62vn8HwESCU9qav3B673ntiauQEZtmdjFNh9Sj1 //G7wjGmobH+515DPIyrOMiOThAyTEKnkUfH90qKOdy3yWj9v8TLv7z9wKrhyNqvgtg0Cp jYYc2K7g7cGdWSj+gvM6Y5Fl+zHWiVQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-675-0oTwbriGO26GJgKBGe4Btg-1; Tue, 26 Jul 2022 04:39:37 -0400 X-MC-Unique: 0oTwbriGO26GJgKBGe4Btg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 18A7585A58A; Tue, 26 Jul 2022 08:39:37 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79A9A94580; Tue, 26 Jul 2022 08:39:36 +0000 (UTC) Message-ID: Date: Tue, 26 Jul 2022 10:39:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 2/4] vhost: make NUMA reallocation code more robust To: David Marchand , dev@dpdk.org Cc: Chenbo Xia References: <20220722135320.109269-1-david.marchand@redhat.com> <20220725203206.427083-1-david.marchand@redhat.com> <20220725203206.427083-3-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20220725203206.427083-3-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/25/22 22:32, David Marchand wrote: > translate_ring_addresses and numa_realloc may change a virtio device and > virtio queue. Callers of those helpers must be extra careful and refresh > any reference to old data. > > Change those functions prototype as a way to hint about this issue and > always ask for an indirect pointer. > > Besides, when reallocating the device and queue, the code already made > sure it will return a pointer to a valid device. The checks on such > returned pointer can be removed. > > Signed-off-by: David Marchand > --- > lib/vhost/vhost_user.c | 144 +++++++++++++++++++---------------------- > 1 file changed, 66 insertions(+), 78 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime