From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC7FF43B04; Mon, 12 Feb 2024 16:01:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCDB9402D9; Mon, 12 Feb 2024 16:01:20 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2040.outbound.protection.outlook.com [40.107.244.40]) by mails.dpdk.org (Postfix) with ESMTP id 0E805402D0 for <dev@dpdk.org>; Mon, 12 Feb 2024 16:01:19 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iGRL+LCR1mejFa34awVqZivowfHp8SoQkRGQnF4rur6fTn39rrTz+9XsiDpQMo2XWc0aeo6fK5vfH9W576J7vDu1dFCUK1gcmALj39Ur/BUtkgXc61cg1b9i7sACB6Fj4ZPKyv0r4lthp66mUxd9T6BjbHTZQY0ftxV9jbOFeinkBVfVxzf6xZQ6SyJpYVvfe/QIQUgu0GCth81DHW1juCRNxpkHelptX6zmUD3VNDv67kM7mo0u/3q5hcfAs06Zj8LmRKkejPmA1pp4gYfakv2PhHhprUNONnLMghGm2K/IRW2CyIVnllXaituZGZswntdBqvStfw7ioB/8v/FvuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q3u115HWtpS6rCDA1V/rgs3lIuF0mOB54viWK/N6YKo=; b=lOTFdXKxz9rdK1QRD+cqIyL+NPg2NgSant89Kogo98+9p4YGvRlZiduP99xD+KmUyrdFq0II/fUxZQX+Ry5UWOk1hNx2mETAbTcOHxdt7O/HUF8wd1MwKtdY3CApuj7dRfRdUOICvrCuzQaTu3e9MvjSq1ClwVEwoQRbnl5zM8OrsXcMDUO3uTJfYEPufBmLBCJDr3qipIsI0HvoTsB8lSU1taystYKAjH2ZJHiXPHp5TgOtwLy99HY4Cox9hf7luRFEET3fxuEpDqiVhrOrK7hFgOJfQdscHSizbHruv8vF5BR8Y1b7FBnfhMnI0+pjFOFEA+CHrs5Kk50P1kt9PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q3u115HWtpS6rCDA1V/rgs3lIuF0mOB54viWK/N6YKo=; b=aIHbTB9Sr02l2LLwiDzgtH7Aaj74ephkVowJSnmEt1nAVo6A6TNpYy5W1j74NT/sRaOT6p5KXazDIri89QVXkFtNZkGnAtqeBAlDYXrc+bC5TYSL0JiFL0uRtcds2gYKudrp82mb+M4IOB3KG3bsm7lIaw8BbWutv4B02wrmkp/8qRGSynQrgTpjG0l2+T1tAI6iB1gFJ/NkO7xrpzGlgit0H2Z8RESCDpUGEK0HHigmkIHTCPCXY2GhHjqoyDhzVsOyhdFwdP2utGZBW95b5bmndrVgheg2lTJpVujg7Ckn5zcl0OAszSFYx+v6ItH3Py+t7mP5A8u/ncTjLR3zbQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) by MN0PR12MB6197.namprd12.prod.outlook.com (2603:10b6:208:3c6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.16; Mon, 12 Feb 2024 15:01:15 +0000 Received: from IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::22fc:4326:d657:92ad]) by IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::22fc:4326:d657:92ad%7]) with mapi id 15.20.7292.013; Mon, 12 Feb 2024 15:01:15 +0000 Date: Mon, 12 Feb 2024 17:01:10 +0200 (IST) From: "Etelson, Gregory" <getelson@nvidia.com> To: Ferruh Yigit <ferruh.yigit@amd.com> cc: dev@dpdk.org, mkashani@nvidia.com, thomas@monjalon.net, Ori Kam <orika@nvidia.com>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Subject: Re: [PATCH v5] ethdev: add template table resize API In-Reply-To: <7c5bcfe0-dd24-4ca8-acf1-62c6246458ad@amd.com> Message-ID: <b5c6cf79-c75d-d3ee-67ce-b52cdeb6f523@nvidia.com> References: <20231217093205.321082-1-getelson@nvidia.com> <20240211093053.397469-1-getelson@nvidia.com> <7c5bcfe0-dd24-4ca8-acf1-62c6246458ad@amd.com> Content-Type: text/plain; charset=US-ASCII; format=flowed X-ClientProxiedBy: TL2P290CA0019.ISRP290.PROD.OUTLOOK.COM (2603:1096:950:3::14) To IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6332:EE_|MN0PR12MB6197:EE_ X-MS-Office365-Filtering-Correlation-Id: 09e9b5e0-2341-4a1a-e1cf-08dc2bdb7582 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PbRQM6FV7R88+wnvdArBZ8xXqic5TJVpSx5c35QJUSpsLmjFItU5XJ6bmAhzgqqGGSzFA+26ufsfRaR3toFdsSikN/53UEmUOhqbnmKzJrH5ym7WfTztaB7fm4hf07rjVBx4Q35dxPaJVyoGre1y+p5k+ODnGfOLpXJYSRPE3h8EjdfBfwMz6A+agAyBED8mui/4+ILj6awhPy8oCi/jg5e53q6uvQuXES8sHRonlknqygvHcEv4EJJLNhh0vDaL49gosFxCVvNVCs+N44sxFzaxPS/YlYbeCTmBRFX0OsH/P0EnY8Oo9GFKLuzUNve+RBMY+brpmLIRbeGzy5jn2cQ/0TlR35nv/XHAoZwx/0Gr70JD8/xDVxwRDcp+/i88TohzFuPN9P6zo7MPdHbM4KUZ3VYriIMdVqrugAHOG/SnUEb+zodXHHitek1S3zxsC71DQpw8QETLnQxSyTgyjnAjLgbzpCvRYfIGAxj8OokdxQZnmoEpJ3bTeMtd0Jrw+N+RK6ymt2g11OPTTYtiCuqaJmWJRPDrmNMHIt1dy2OYoVKzq+HdwwaXZspKx5iX X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR12MB6332.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(39860400002)(366004)(396003)(346002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(41300700001)(26005)(6486002)(6666004)(6916009)(6506007)(5660300002)(6512007)(31696002)(66556008)(316002)(2616005)(8676002)(31686004)(54906003)(38100700002)(83380400001)(66946007)(4326008)(86362001)(478600001)(2906002)(66476007)(8936002)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7SHzZcifhXJv4XdKqzyanKthHIDnO8GrN8s42+/yRGSWWqBTXsmZGPo/Yhxi?= =?us-ascii?Q?2Zs07yV2IAnToq8Ld9e17zs7qTZi42Vz4R7REYwLos2kWz9ze2DjUWp2VMqn?= =?us-ascii?Q?2F1JVMgt4geQoMenqkhpVgLTnJ6B94E9csghm4ByXdRd+ZBEX4PKtUJNR8KY?= =?us-ascii?Q?9KjcDItowmZbcJ3GERWwfTD7OrNTLrxOZVC0PpR0NhH0nc9yc3007qB4z856?= =?us-ascii?Q?9MZS6jjaiLncgZIFzPVRe7Kl4Jc3dkeEAR1K4I8Dwi6xVyoezj37l4QWcgtx?= =?us-ascii?Q?KIq6dFebMg9SQIpZYn+97j0F0BfevNPqYvZ4mQDPHJ9suDabP2TW4vPhB/kK?= =?us-ascii?Q?w5OkcHel4AfXjJnkP8T9sftWtgRQbrmR2cheJPvmtMxmu/ypv16La0YaX/kD?= =?us-ascii?Q?ABjtEHfwY3qlTGpCNHhL3FZrxK6DZHOrqWFOV1U+DisjLr6GyTGUS+xFrUrq?= =?us-ascii?Q?y+z1RzHmXGY5mIrCxk9RT1QppdeZGSIpN46yuW3wEpYsCDNyuOxJ6Yz0z1Z8?= =?us-ascii?Q?YMWpqFMayS2Bceeg73rdx4twUX/enjXQL01ftqKQTXWFeX2v+bmNSuiRfkTQ?= =?us-ascii?Q?6VusDmW960dpM3oODAhFrDWebGORAUJl6eJiEkA+rVEiqWFiWqn/Hh5vm2Ab?= =?us-ascii?Q?6n3/0eVc+HrogJvpAfjAWI6EloRnVORNQglNzwppNfn/7+PqCVngP8BW/ZQG?= =?us-ascii?Q?A2QI/Zwcfr4xLom9C3FnFj6BIz8N8ZpFpMKVvuhSpC5EB3qSatCF+n0UFc7w?= =?us-ascii?Q?NpCrICaO0D/ymLynhAEvBibtDr1bvZJmxZC7BIF6zv6VKFSkjuLVDNix2mPt?= =?us-ascii?Q?v9tfRXnmCypjjDxU0t/0tjwrFXxJ6f0XkZrYowFnXYFnt8mtP8RfQmsRTpNA?= =?us-ascii?Q?5WaQkGlxrlCtxukYfxjOgGBmTkbVpMPbCVNlL3VvvlUrmzSSmX/YON+UmCN3?= =?us-ascii?Q?4oddoYlOCZ+22h/sDoP63EjODbs8XlPH8e7H7rhCvGOLt39lcHia4dQWz0lQ?= =?us-ascii?Q?daelPoVMF0uIH+sYx26kDnbze6w72zZCySjKVs4kNOHjArXtJgLkqdqZoDQL?= =?us-ascii?Q?dX8w6DZjKBiQW2/qhGf6iY/AOVLFV23A/CFThXpZBKd2v/+FF4n8TO7p2JcR?= =?us-ascii?Q?6p37Fj+1qnNpjvUFvIVnebzcvreI4sQ22YxCjl4pbZikdTi5smGAg29Uwrt+?= =?us-ascii?Q?RPYD6ARJFFlPiJ8Fom3wIDhbbWVVNVEDe/OIczurxTaPf0uFpCo7kxCX6TAO?= =?us-ascii?Q?IzCUb2uR+TS9qzIpexcbhhgqS1AwI9Rda0r/4eow2qr5n0oLgouHTDLHs5Aw?= =?us-ascii?Q?RuwlSlGDPgWHRfwFPGBx8ZzRAStWjDA9T4HFsBhwuioix2X+jNYQjjxnmRKv?= =?us-ascii?Q?fa8RtwY+AvhypUT2pYceCwYx0hFHZvptTdSOP1nUYmuOHNRnsE1pqoJjmi99?= =?us-ascii?Q?Dq4cHQO2tr/ZKfO82nBuEgD99qrRPSXCWir5RNz5W8O3GcV/bTIWCDqgJsnn?= =?us-ascii?Q?BtdEelf70pkPDByynQ4iQJP7sE0EUy1cCv6EWMc2XXBbBugqHHnrWsoRVcqy?= =?us-ascii?Q?+VEZLx5DsP6g8mE+2AzKpujtFbMMF5O+iMWpHOp7?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09e9b5e0-2341-4a1a-e1cf-08dc2bdb7582 X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6332.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 15:01:15.1071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GUcP67yadIb4wdEirnQ1vpOdQacdVrmAYuRLOok61ttiB0gX9hGNE4/8pKL8N+hnDrlU2GFQvS8YviSafa0NCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6197 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Hello Ferruh, > > I have two more clarification requests, can you please check them below? > > > If one ore more flow failed to update, for any reason, should user retry > the update (in that case we need a retry error maybe) and can user still > call 'rte_flow_template_table_resize_complete()' (for possible next > table resize operation)? Can you please clarify this in your document. Please see my comment below. > > When user calls update() with a flow from new table, API should ignore > it and return success, you mentioned this is what mlx implementation is > doing, what do you think to make this as default API behavior and > document it in above API documentation? > > I'll update the patch. > > If 'rte_flow_template_table_resize_complete()' fails, can application > call another resize()? Is this managed in the application level or > driver level (by returning error to next resize if complete() is not > successful)? Is it something to clarify in your document? > > PMD failures in `rte_flow_async_update_resized()` and `rte_flow_template_table_resize_complete()` are not recoverable.