From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B27FA0C43; Fri, 22 Oct 2021 17:46:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB46F4117E; Fri, 22 Oct 2021 17:46:21 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 680D941149 for ; Fri, 22 Oct 2021 17:46:19 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10145"; a="229595859" X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="229595859" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 08:46:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="534968154" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 22 Oct 2021 08:46:18 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 08:46:17 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 08:46:17 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 22 Oct 2021 08:46:17 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 22 Oct 2021 08:46:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lew7F4qu7bI6cKrhyFvdjFe9LK9rGomVDkZp0QfHvWcGqYLllE/7reNoFtcXt8YzcSZdXrrAGLT/CKKWLMH6zZlL7dtBlq3ohuhBCAEQCRS+uvhY4LbUjlv0V1dS8BZSc66qvt9kDtpESiony36ciFpyPZwKKrrhODS3X+4w48uH3CcZ7Wx7EW1VkG3Z2DAJkbjp5Gfkq8MyNp7kKPt3uTzm/bPgycATqxQUN9nxBlulEkzFGiWn9Uy0siApe9DPlyh/dTHfBsCw1juYkoEvxZ7gSEMg7DBFZXMV8r3v9rlioubey1V8kfV9MUqg77PuRDMH2jc8Pg2y6HLDXEJjNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aZAW8fyfbVtQDDQy0g+kzA2Z/dILsXi/Y2vKTKUMsXQ=; b=K59GjCPfVweIl+IbvoQpj680yswwqdHPv5lpj6Yq5rgRF3vE08oQMOj+rTCFORQ84FlTilmp772AYHB8C1Qww2lAjHmw3AxwJrfirLl54pAxpGaLy0EB4PrMeqarXSyyVNbnQ17LNWT+1hersH3ZdIoxrVTB2wGJHQfwZz//LXrN8yLfyZnPDUsk5Um1docd31+DRHn4eRK+IVNmWz3poutU4ne1xiEZRggrQeVHVN4jrxU9o68pxUC4wduaul12QeHrX0LQ+wrcyDDFtLDGZmSTBRDWKCwh+xYkS4B17VdvdcNqEB7IYumf5998qKLEY2ipUqm3gMm+EhWReddbWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aZAW8fyfbVtQDDQy0g+kzA2Z/dILsXi/Y2vKTKUMsXQ=; b=Ibq6eZd7LEetfhlhWWjTI3pDcNuD+FYidFlzKexl06kvwtZ3FgKEFMM+4V0LqhlZnrzrklW2p7l8EHAJ+LbCirUNXlQ4kJbIAhG7IOheBtbuuqTUnklMXXl9C5B4jzZuzXvPzrZuSsmxIGCeWgILzCsG9BkX4l+RM4+dT4Xmcdw= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5141.namprd11.prod.outlook.com (2603:10b6:510:3c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Fri, 22 Oct 2021 15:46:13 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021 15:46:13 +0000 Message-ID: Date: Fri, 22 Oct 2021 16:46:04 +0100 Content-Language: en-US From: Ferruh Yigit To: "Jiang, YuX" , "Wang, Haiyue" , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , "Zhang, Qi Z" , Hyong Youb Kim , Michal Krawczyk , Andrew Rybchenko , Somnath Kotur CC: "dev@dpdk.org" , Thomas Monjalon , David Marchand References: <20211022121708.1591089-1-ferruh.yigit@intel.com> <20211022125716.2706937-1-ferruh.yigit@intel.com> <20211022125716.2706937-2-ferruh.yigit@intel.com> <8f1804a8-b53a-bb50-6701-e7afd77e8b8d@intel.com> X-User: ferruhy In-Reply-To: <8f1804a8-b53a-bb50-6701-e7afd77e8b8d@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR1001CA0047.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::33) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR1001CA0047.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Fri, 22 Oct 2021 15:46:10 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c63204c-ade5-4874-74ee-08d99573132c X-MS-TrafficTypeDiagnostic: PH0PR11MB5141: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WFGfM33zoWlcv+gfYpBzMqOPMhXcRxBMCSkUvviAw+Z8foA8uY+TtkODYrfKeSQArYouS757Dc8fz3oTlpBzNSB1ILqDcZ/xsmgsMYYqALU+Tf8vpZ4Td5Es+Lj2CCuY69i2KtcL+bgLQPf47CQvqM2tsRGYWLNj9+yu5v87Av7kp1R3tnUwvdcIJLwgZVonCBQ59UCg3fHK1alQ36vP8yOiMXBHiR1CAXqiWW8xA4tagrvvoKrWw8mQ9Zp3b9rXBlRavXpXKLj39lRqM13OGORFkvnNEfxeH0QDgyhkMSvmptAKrS/ItxQqLNknqrOwKXDrUy77KeWtCzq9NA5bShNtFdMzExxW/Kn/BqX1YV5lhxuiL/0GUXNO810XFwHGXZKOXPKOAyqN/XulKsuLkTaOf9acCf9qZ2O/RLnI0sEgs5z8PSqpWcv4PtFdOS7zEdkC8KRmWqOc/YYIfayJmtrM896o9pxXdZX+yev7c4t7VRY6m0MzwLso5Dnx8Y/sGWKqV1vl5YKFuSdmOoF/7oDl72OD+B//MKurGNCoxOpEzNHDe3dmsO76OE80LOFPnyFlo8lLjCdsAyXW1dNitVyHEZpyvE8CEWnBG/FZlvFnHU3xRJ/16bCXh+s9JI+epdlUGuzKgE8BUdcTRzWRk2eXF8XSlPpDQG55FidIIhkZlLSwchxt2GJMtDDXzK+CYvFKMkV3TG5ND2d67hcFRLCHAafW5mXN9nKX1EOebcqZHS32xlL/gxuHfEdlGHter1am6ZS2DLZIc10o8TxKpH6FO4nEtStjUNVyfMyE13ruE+BaB0qx41bQ9IUp+orP X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(82960400001)(2906002)(38100700002)(921005)(26005)(83380400001)(54906003)(16576012)(966005)(110136005)(5660300002)(316002)(508600001)(36756003)(66476007)(44832011)(8676002)(8936002)(31686004)(186003)(4326008)(956004)(2616005)(53546011)(6666004)(66556008)(66946007)(31696002)(6486002)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnEzdERjZUttRTNMZFVYWEorQUVmQVFTaGtjTjNmUzkxNVJTSjRsUEdCYWVm?= =?utf-8?B?VmtWekZkWXg3WFBlNVdZY2ozc0lwSkxPN05aRmNHaTBveGsxVEFhSEdjSVoy?= =?utf-8?B?MG15bkIzL1l2aWRIVDh1K0lybEdyMFlkanlrNHIrc3lqQkJraU1zRkRDVnVp?= =?utf-8?B?N1R2b0VZdW02QWsxWEp4L0F1bGlIaTNFeXc5ZWdtZGhRejRUbkNWZitUSGYr?= =?utf-8?B?bFRyV0VxbXFneDhldnYvSW9udXQ0OGJrb21XLzd2SzdMUlJ0eDBKRER6b0E1?= =?utf-8?B?MXdLenEyS29FbDIyTllML2tFRTBPL0xqQXRwZlh3eDlmTFNFTzQvQStqanJm?= =?utf-8?B?ODZ5MkVneDg1Q3drd3NCUXNoeWs4UHgvSmRIdmQxK3EwYTJvUStWclB5T3JM?= =?utf-8?B?M1oxbmxvNmZ6RUFraDlmaUNQYUE4ek1BNGl1N1VNL1d0NGlyYUdrTDRSbzZl?= =?utf-8?B?YzNZZzByQmNwTXVuQm42cy80amdwMjdyKzFYa1lqQW1IRnBCR0FacE1ySCt0?= =?utf-8?B?eGhnQnEwb1hyS1lUZzhLVDZFRjhxOHdRdlc0QWh5MmY3c2VHTlEwMENjN2V3?= =?utf-8?B?TTdab0srRnZ4Um5JTDRHTjB1Yi9VR3JFbVkwZDl0WHNrNWthVzhCdmlGZUNx?= =?utf-8?B?cjR0U291MG1EYnZqNnpMMG1MazFpMlhoSzVBdytmRWJLcm5QYWUzbVQ2TW1m?= =?utf-8?B?TFNadEUrUzlJTWJnT25JTkp5VkJ6NmVQa0NuMXpQUElhdzZ2cW8xUU1CWDJj?= =?utf-8?B?NE9CUkl0aWtyMW5yamwwcllsbTZFbEUvaGpXYUtkVmI3dFZTTkM1R3hGemcw?= =?utf-8?B?d1pUeWxxUlg4REZEOHN2ZU1hMjNXZ3BBRGNETjdMV0xUZUNJd2M1RitzKzlH?= =?utf-8?B?M1dQUkVZOUltaW1aWENsdjJxTGo5U0xORkg4VllUaVRUdWVid3l4SUsxdm1w?= =?utf-8?B?RU5JYnNLWnRWZ3V2N0NrR2xoNDl2akhyYTNRVjJDUktxOHlNejJxUkdOemo5?= =?utf-8?B?amkzU3d5Y2ptSGJlM1ArellWWk5yK0xEby9LQ3RlZHBFOG9wYkNHakxsbkFo?= =?utf-8?B?MHdkRVNEVHpVcmVQZlF5YnBabjhiMnhiME41bDJhY1k2SnNJTFN3cDhmbkl6?= =?utf-8?B?MWxRWm5HTUJMZ3pFbS84Vmhtd1hFTThMNWsvTC9VWWhoWGxoWXN0R25leUU2?= =?utf-8?B?YWhpbDE4NTBrM1ZiSVhQeWcwUUNVbWlGdUIzZFZFSjRZcmxEeS82cGxSeHpE?= =?utf-8?B?Wk8vUkFVdk1sQ2J4TDMvTmJiYys4ZUJXMUMrWnVDRmVLbldmdjgrWGlKOTJQ?= =?utf-8?B?cWhtVjZYU2NwbGVYT3UyRDBBOUlib2VyT0JhT3hWWExYZzRyd1dHajNneGFy?= =?utf-8?B?YVN4N1dGVlBzQmtHZUlWdHpaRnJ0ZXBjUVA2QytuTXdqNTJVMjh4aVFKVklS?= =?utf-8?B?cS9BaS9LZFByNDE4NFdFR0Q4dUNZSzVpWVNkY0NsaTlCUlQzOXVsWThORFR2?= =?utf-8?B?NzJrT0pWdUYzOWFJdmcrcks0Yll4cTNNaUJvd0tNZEVuOFdpdTlWQk5PNUQ1?= =?utf-8?B?aFpGSnJZZS9qYlNPRTVjamxjd0xFSm03MVZkRzJTRTQ1Q2dCMkdaZ3lZNXgw?= =?utf-8?B?Nm1GandWb3Yrd3gwemp2TElEdkVEb1Z5QnhrTnhOZWxHMGQ4MUs4ZEZVeG9i?= =?utf-8?B?UGdVdE5qa2tZNzFCRU9KeFJxTTlaSUxGOWRLQmlPbDRpTm5WbE5CSGVpRmVF?= =?utf-8?B?Q04rMHZkSE91LzFReWRzVDBGSkpYYWJFa1R5ZHd6RGhNR2pLN2tuYU5ucisz?= =?utf-8?B?ejV6dUhqWEZDeTNUS0JTZ2QyNnVqTlEvNGh1bjRKSk9tN3lpSkdKckZhYkx5?= =?utf-8?B?L1JKdlJkcEhhV1FzUHpvWGg1MndWWHg5dm9OQ1B2YkVoQ2F6cit3R3lPUmkw?= =?utf-8?Q?w3EsdiNWLPjyFrMRe3QkEVX37VPK5PxB?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6c63204c-ade5-4874-74ee-08d99573132c X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 15:46:13.0739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5141 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/2021 4:20 PM, Ferruh Yigit wrote: > On 10/22/2021 3:10 PM, Jiang, YuX wrote: >>> -----Original Message----- >>> From: dev On Behalf Of Ferruh Yigit >>> Sent: 2021年10月22日 20:57 >>> To: Wang, Haiyue ; Xing, Beilei >>> ; Wu, Jingjing ; Yang, Qiming >>> ; Zhang, Qi Z ; Hyong Youb >>> Kim ; Michal Krawczyk ; Andrew >>> Rybchenko ; Somnath Kotur >>> >>> Cc: Yigit, Ferruh ; dev@dpdk.org >>> Subject: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload >>> flag >>> >>> After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, drivers give jumbo >>> frame decisions based on MTU value checks, but some of the checks were >>> wrong by mistake, causing device initialization to fail, fixing them. >>> >>> Fixes: b563c1421282 ("ethdev: remove jumbo offload flag") >>> >>> Signed-off-by: Ferruh Yigit >> >> Tested-by: Yu Jiang >> Verify patchset v2 https://patches.dpdk.org/project/dpdk/patch/20211022125716.2706937-2-ferruh.yigit@intel.com/  on dpdk main branch(f4acb429d0 (HEAD, origin/main) hash: promote some functions to stable) >> Tested on i40e(iavf) and it looks good, will test more on others. >> > > Thanks Yu, > > I can see it is not fully validated, and most likely it won't be > before -rc1, but it would be good to have this fix for -rc1 to not > block testing. > Since the previous code is clearly wrong, and fixes are similar > between drivers, if one is good I will take risk and merge > the fix for -rc1. Series applied to dpdk-next-net/main, thanks.