From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B64CC1BA04; Mon, 29 Jan 2018 17:32:01 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14211C05FECC; Mon, 29 Jan 2018 16:32:01 +0000 (UTC) Received: from [10.36.112.21] (ovpn-112-21.ams2.redhat.com [10.36.112.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1D24718145; Mon, 29 Jan 2018 16:31:54 +0000 (UTC) To: dev@dpdk.org, tiwei.bie@intel.com, yliu@fridaylinux.org, jfreimann@redhat.com, jianfeng.tan@intel.com Cc: stable@dpdk.org References: <20180129151347.23640-1-maxime.coquelin@redhat.com> <20180129151347.23640-3-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: Date: Mon, 29 Jan 2018 17:31:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180129151347.23640-3-maxime.coquelin@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 29 Jan 2018 16:32:01 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 2/2] vhost: remove pending IOTLB entry if IOTLB MISS request sending failed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 16:32:02 -0000 On 01/29/2018 04:13 PM, Maxime Coquelin wrote: > @@ -52,8 +54,13 @@ __vhost_iova_to_vva(struct virtio_net *dev, struct vhost_virtqueue *vq, > */ > vhost_user_iotlb_rd_unlock(vq); > > - vhost_user_iotlb_pending_insert(vq, iova + tmp_size, perm); > - vhost_user_iotlb_miss(dev, iova + tmp_size, perm); > + vhost_user_iotlb_pending_insert(vq, iova, perm); > + if (vhost_user_iotlb_miss(dev, iova, perm)) { > + RTE_LOG(ERR, VHOST_CONFIG, > + "Failed to send IOTLB miss request for IOVA %lx\n", > + iova + tmp_size); Oops, the correct value is "iova", not "iova + tmp_size" I just posted v3 fixing it. Maxime