From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D235A0C5B; Thu, 25 Nov 2021 19:41:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2052E40DF5; Thu, 25 Nov 2021 19:41:40 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 1E3A740140 for <dev@dpdk.org>; Thu, 25 Nov 2021 19:41:37 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10179"; a="234285398" X-IronPort-AV: E=Sophos;i="5.87,263,1631602800"; d="scan'208,217";a="234285398" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2021 10:41:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,263,1631602800"; d="scan'208,217";a="457940212" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 25 Nov 2021 10:41:36 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 25 Nov 2021 10:41:36 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 25 Nov 2021 10:41:35 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 25 Nov 2021 10:41:35 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 25 Nov 2021 10:41:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LO27JvGflvOYDiCn3aAOPdWIA/fMdfVjp3vgkF+REa3eNENaMUkg66MRzXhdE8kkSTRGl8pXtWkuFte/n3/VX2eDFntCzbZCOG/BFlb7yyT9R2+/TE50OB5vUCUbsF0rrR7+zYk8ggC2Ct1jngdYU67OTYG2HtF51cR7WsK31mPPb53h9YKTcIxcIdhV2gHPaXY0oQ5S4h6kXlfQOBT9otk9RgD3bXW2va/zkKAc+/gZ9j54af/JBjHuNgBk9DVvzs4iSCtfxDBOLwAfHcqGTgcch1zTjj98qszqqLQ6Nf84poXszDcHri4XoD54gH5Ic3FJ1pLxF7u9XSpvkkfu5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2amBKoj3F/7Y7fYb4NSQVDi/6FkPfOXStecer8U71FI=; b=jAafWqZym/iSS6GZHibeE9UmBIYbV49ifNiH+7qw24D/XPOhs42zQLsSpIctJm+MR+PyTvVBxTSx0VaUmQFTJbjtZaCXhUPRLMAVDj7sFfYZMjLYgNvys6GXnbuZt2GT55Nj8MpRTIKUrx6s/yY/uFKpBHJC9OqB2wi7+FzXvasbpXc6oJKVktDJQt8kLlfYlK2haGQuRx03+9Q5GD89vjciY6CKvAx1KoHM68w0YYuNosouI5yFRoyDQtYKwBYr464EU2IxGuAr0sZWFknzIxh36fqgpenaJJcwREgGe5mPAKXj9+fESTp79mLIyjkrNbLhrVhq69i1xnCCy30LzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2amBKoj3F/7Y7fYb4NSQVDi/6FkPfOXStecer8U71FI=; b=Vsu2wE1VyqDjCDPf0sMWm3DBkcx72FnRnvyojK2A4ByRATm0CQytK6iut6RJj2bV3yx6NB/qMy3gRXeNqXC/04C4oV2Y9t8c7QBMm/k/qof6RnFl6uORIwRbN3eb0kDMYUZPtiZ0csd/8vt39DZP1KNM2Kammser3fGS+Ob3HY8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4806.namprd11.prod.outlook.com (2603:10b6:510:31::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Thu, 25 Nov 2021 18:41:34 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.030; Thu, 25 Nov 2021 18:41:34 +0000 Message-ID: <b5febe1b-30c4-3f7b-a3b9-603c6d3c1051@intel.com> Date: Thu, 25 Nov 2021 18:41:28 +0000 Content-Language: en-US To: Aman Singh <aman.deep.singh@intel.com> References: <20211123084719.1313-1-aman.deep.singh@intel.com> From: Ferruh Yigit <ferruh.yigit@intel.com> CC: <dev@dpdk.org> Subject: Re: [PATCH] devtools/cocci: add script for ethdev namespace X-User: ferruhy In-Reply-To: <20211123084719.1313-1-aman.deep.singh@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0301CA0046.eurprd03.prod.outlook.com (2603:10a6:4:54::14) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0046.eurprd03.prod.outlook.com (2603:10a6:4:54::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend Transport; Thu, 25 Nov 2021 18:41:33 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1e1f0bf0-792c-4609-cbb0-08d9b043345a X-MS-TrafficTypeDiagnostic: PH0PR11MB4806: X-Microsoft-Antispam-PRVS: <PH0PR11MB48066639A2F700598592561B95629@PH0PR11MB4806.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uTGzM8qti7J8Y95d0ThqdTeD/E9U3z+kkYE4suzOe0Ixg7IWwzw7e+73oqGhv3opfAh2qrEzbB4ou1/6eQUtmF4RK5KBjxJej6iHfnh1PueXIHtM8WUluaApPyo+eZ4iAR1tenyCFPUjoc75TjBXbKHsqJa96EReKK8X/Av2H6Fb/EysV+sAIZ2vEQPTsxoY4VFNn4fKMPeqGFkRBq7W39FEPNSfYYrnsrDafYrUx9zUg409IKd37r140NkC9qyy/30MXZbWI4WzpMxqWkR4QzPAby/x9ELvaMOoaj4BLE2Qf2fb5YtpswIwquiha6U1Sj7xjE7ocHi1V3AVAe7fFpm0ZvKzRMXIwiqmMHdTdwh3hLSAyn3DG9Z3ZvW+PB9wMPeoj54+bu1pM9eWXmqwJCQ/0HV9MJe2CId/t+8EKPEPg24PmMTz5R3YCpexceR41OSUFQQjRiMY9RAANfvZLxwtrVJcNYH5HkECuPzLOe+ucNc/uzy8GQWXq2XRFv7Bhhyq43exLGN02TkPTXZ4TD69Situix6Qn3e386fNfznvWU4u2uUu8vMdQkgWlH4r0FJOkK7M8mna95ZGd+o165FNDf4jDkBJA2kROw1ObK2jwbdA1XbGotkJWY3P0cOuACVWWOjy2z659NhKrqydDGCqMJPS8o7WtY/9+xoRuKLR1ZiXpKN48gTCiIJGstktrFVPsg+9VKOQiuDgGhLbsw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(44832011)(2906002)(4326008)(956004)(36756003)(2616005)(82960400001)(6636002)(6486002)(5660300002)(8676002)(6666004)(53546011)(16576012)(31696002)(8936002)(66946007)(66476007)(38100700002)(6862004)(186003)(508600001)(66556008)(31686004)(26005)(316002)(37006003)(86362001)(83380400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VW9EUGREVGpXQXBBV3laczlnbEk1ZFg1bVlPLy91N2ExNjI1NWFPV2h5b1Jn?= =?utf-8?B?WFZJTHdzd0lXdDdhdlhFelZRaEoreVlGSGhqaEVxeVhHc0NTaFR2aWpXSkNX?= =?utf-8?B?NmtyQzBUNlVoQ3VFWFhhOWY0dEtPTlQwUnlrNWtvdEFlanE5WGpxRmdRQXlQ?= =?utf-8?B?bFQyLy9YL3F4ajlxVDhoOG9Vc2YxaVJIeGs1a0NOTVQ0NnFyOXF4RmRzMjZY?= =?utf-8?B?TFVCNmRETFkrNkFUM3ExWCtTNHNjRERBM25td0xhVDdybzM5NjFJazJEZzdC?= =?utf-8?B?bGpVWUQ0cGZqVjFWWkRuNUlkTGJLQzhUNVh5akZrbEJGUEFhZkFITUFQbTFY?= =?utf-8?B?aWVXbUl0NG04TFJ3NmVPcjN2Mk5jOVl2ZnlpVDNTejBOd1AxVU4wWUp4cFZV?= =?utf-8?B?Rk84eVZYaHJyM0RXTEdZalBSUVZ4VmROOTVRRlp0S1BOcFN3NFRyd094VVVu?= =?utf-8?B?aFlhNE5BeThjNnljNnNrd09zVWVJSTA5MkFIdUVsSGpwM0RrdHFGeWVzd2ZT?= =?utf-8?B?NFBaa2puSTZETnlUOS8zNzFXODZ1SGVad1lNQzBQelRGcHlPeFJNcnR1NC9k?= =?utf-8?B?K2xvNE1VckNSV3IrTmFCR2hkYm4vZ3ZiQ3U5UFZIY2lGbHp3NkRFTTh1ektN?= =?utf-8?B?RmRpaWI5UWVldUNuVEV4SXl2SWtuTEZ0L2RPSGdla0pTRnVMLzZqQTlJZHY2?= =?utf-8?B?TEhob2w4UkY5eThRWkxTSW9aT1c0U3dScnhEMHVXS2czVisyR1IxZlppV3Ay?= =?utf-8?B?bnBscVhTemt2RzIva3BlSVJTUlJ3MXZxcytDRUpTQVZhRXhYK0xaUnlhWi92?= =?utf-8?B?RlJGUjBJREtrVzdqMVRyclhON3hwM3lnaVhYWElDRjMrNUlJc1NEWGJBR3ds?= =?utf-8?B?MEkxYmFtQ3Zzd002TWFRZ085djBCVEw0L1JRQjNMWDFYOGxMZDRpVk9vQlgr?= =?utf-8?B?bWNha0xMeVpZMnd1Y09WSmZOUzNPUTVaRllhQVJLbkVaM0VETzFUaGdrRElt?= =?utf-8?B?bXU5WWpBR1NHdXhvRmtrMktFd3N4ZGdQWkVGV2JNLzVkckJWN01DVjhzUXJH?= =?utf-8?B?K1pLenk5WHYrZmZKVEtQTEt2REtHa0NQWXpyYVMydmsvVjNmbFNrWkVvVnZP?= =?utf-8?B?cGFQdEl4emY2R1pCYUlmMzFLZnFMdGp6Rk9EM3NEWmIzcmltQUJvT1FWMGo3?= =?utf-8?B?ZHpDZzhzMWg4VGJBMktIbWZLb015TmZaQlorTkhLY2RNSHk0MGc5eXNwRVda?= =?utf-8?B?QTNrUVo2Tzk3dzdhOXdMVGRIZXJ0Uy8yNENKVFlZTmRGMGpUbGRXL3IrUkgz?= =?utf-8?B?L2R6VjV2d2dvdkFVOGtkeG13S2RsbEI2RTBCOHZhaWR1a0lKdlh6UkF3RGFu?= =?utf-8?B?NVQ2ZGpUQkt2VlNEUzNLWUZ1R1U0NGdSeVUwOWJRbFRaM3hMYWNMVUhMNjd3?= =?utf-8?B?T3h1cFdBTkpqTGk3OUcyd2V5YmJLMWU2dnlmWXRCc0xIM0IyUXBHd1M2Vy9q?= =?utf-8?B?a0pESlR4YjczV1VuWTkyRFpuVmV2NHBiMGNHdzNNOUwzU0ptS3J3ZkJqL2M5?= =?utf-8?B?cmN0SnNOZHlaUU16UExxbll1ejFHcTJCS3NmZUZOTWZKUGdxd1dLVmtkbUxQ?= =?utf-8?B?R3BkNWVQdGtyQSswTWd2WTk2Z0tSdldCUVc1R21JV1gvN3d6QWt0K0l1cy9S?= =?utf-8?B?bVhGdGlINm9GazhZaEVMaTN5dlR6MUJ5dGwxcnB2YXJhakNsWE16Rk53aVMv?= =?utf-8?B?VSs1d3BQWi9mUjlGV1BjMDJGb2NaWjdpcmxBWG03NDZqdVgxVFFLa0N4V1Bt?= =?utf-8?B?cXI1VUNFbURlTU9GKzNJb25KNmtqcE9xblY0RTFZY1I3K2NVaXJnMHNsSGVW?= =?utf-8?B?Sk5HRGpRNnk0aUowT041T2lrQ0xrQ01WaWp0UnNiYk43aXVRaW4xWDk5MGZV?= =?utf-8?B?Q3dQNUtDVkNhU21IRHNIYjkzOG5MWGtwUTdrajFncURaWjNscHFIa0NORlcz?= =?utf-8?B?RFppaEZ1MUFPaTFpUnR4V21hdWIxZDRsb0RaQmdGOXFxcUpSSHpjVjNRcU9v?= =?utf-8?B?ZWxjNzVBVkRkSjVoY1dxOVhWM0FrUC84UjNkbWgvY3J5Z2EraDJxVHc4SVVu?= =?utf-8?B?VW9NWXJTZCtLMXpaUnkvTDRIK3hBckJLNFRwUWZHUjczdVhHdHo5Z01SNmpW?= =?utf-8?Q?iaM6TwXtWO28n0Z0UTB3ItI=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1e1f0bf0-792c-4609-cbb0-08d9b043345a X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2021 18:41:33.9897 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N6NtOMkA6iXagHgOy7s2xBLevMmKv+W3tasOZ25C7OxUvAO5/JNX2ENpVZxJBPF09gg4Vq+YsYnNsysoUmUL6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4806 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 11/23/2021 8:47 AM, Aman Singh wrote: > The cocci script is to help add prefix 'RTE_ETH' namespace to enum > & macro of ethdev library. It helps in automating these changes for > applications. The script won't make changes in the code comment part. > Usage: spatch <script path> <app path> > Hi Aman, I am trying to test the script, I thought an easy way can be to run the script in an old version of the DPDK release and expecting it build successfully after script run. For that I am using 'spatch --include-headers --in-place' option on p the repo. Getting build error for the OFFLOAD macros, header files seems not updated for the offloads, but .c files are updated. Like: DEV_TX_OFFLOAD_TCP_CKSUM --> RTE_ETH_TX_OFFLOAD_TCP_CKSUM DEV_RX_OFFLOAD_UDP_CKSUM --> RTE_ETH_RX_OFFLOAD_UDP_CKSUM ... Am I missing something, or .h left out intentionally? Is there a way to update all? > Signed-off-by: Aman Singh <aman.deep.singh@intel.com> > --- > devtools/cocci/namespace_ethdev.cocci | 48 +++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 devtools/cocci/namespace_ethdev.cocci > > diff --git a/devtools/cocci/namespace_ethdev.cocci b/devtools/cocci/namespace_ethdev.cocci > new file mode 100644 > index 0000000000..d5de41e117 > --- /dev/null > +++ b/devtools/cocci/namespace_ethdev.cocci > @@ -0,0 +1,48 @@ > +@rule1@ > +identifier I =~ "^(RTE_FC_|ETH_MQ_|ETH_RSS|DEV_RX_|DEV_TX_|ETH_LINK|RTE_RETA| > +|ETH_DCB|RTE_TUNNEL|ETH_VLAN|ETH_4|ETH_8|ETH_16|ETH_32|ETH_64|RTE_FDIR|RTE_L2| > +|ETH_SPEED|ETH_MIRROR|ETH_VMDQ|ETH_NUM|ETH_QINQ|ETH_MAX_)"; > +@@ > +I > + > +@ script : python p@ > +I << rule1.I; > +J; > +@@ > +coccinelle .J="RTE_ETH_" + I[4:]; > + > +exception_matches = ["ETH_VLAN_FILTER_CLASSIFY","ETH_VLAN_FILTER_ANY", > +"ETH_VLAN_FILTER_SPEC","ETH_RSS_MODE","ETH_RSS_UPDATE","RTE_FDIR_MODE", > +"RTE_FDIR_NO","RTE_FDIR_REPORT","ETH_MAX_RX_CLIENTS_E1H", > +"ETH_MAX_AGGREGATION_QUEUES_E1","ETH_RSS_ENGINE_NUM","ETH_NUM_MAC_FILTERS", > +"ETH_MAX_NUM_RX_QUEUES_PER_VF_QUAD","ETH_RSS_IND_TABLE_ENTRIES_NUM", > +"ETH_RSS_KEY_SIZE_REGS","ETH_NUM_STATISTIC_COUNTERS","ETH_SPEED_"] > + > +if any(x in I for x in exception_matches): > + coccinelle .J= I; > + > +@ identifier@ > +identifier rule1.I; > +identifier p.J; > +@@ > +- I > ++ J > + > +// Below rule for structures only > +@rule2@ > +identifier A =~ "rte_fdir_conf|rte_intr_conf"; > +@@ > +struct A > + > +@ script : python p2@ > +A << rule2.A; > +B; > +@@ > +coccinelle .B="rte_eth_" + A[4:]; > + > +@ identifier2@ > +identifier rule2.A; > +identifier p2.B; > +@@ > +- struct A > ++ struct B >