From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 926C5A0542; Mon, 29 Aug 2022 16:24:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 841494069D; Mon, 29 Aug 2022 16:24:08 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id A0C854003C for <dev@dpdk.org>; Mon, 29 Aug 2022 16:24:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661783046; x=1693319046; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=n1fjLsG4nbCvJKFLcNOtSKEi06xvb/gp20X8CvYSCLo=; b=eXb2w+eOr/QnBwOIbQVYrOSNuGb6cxaprhzaNkgIrlg2OkSzgbcJPjFu bieQhERbIj1pGvjugGw51rXPXgwIJSGJDRHBUFlzKRg7aFOaevf7eQUKI nPTWm1ij+ARiS1j/u5eSfNu2X8vibsFIBT4xdYX6mv3qwNb5ZCDLvi0PB D5U4AC2V8CyX2Rgsk24yoslE/u78LYAQV/Qb3YS9T+nZsWgd5Ub3iVyaf TQGGR/yooZDIv9iEEO4ZUjsCy4MEGWQamxPKg4XMndCy+4/dWUbiUdCke ViqfxYLuHlUUhUs/IqX4iYNkvmx1e+N/q08mc4HOEribLMJ5wZdso3pRS w==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="321025883" X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="321025883" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 07:21:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="753644167" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 29 Aug 2022 07:21:42 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 29 Aug 2022 07:21:42 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 29 Aug 2022 07:21:42 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 29 Aug 2022 07:21:42 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 29 Aug 2022 07:21:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EH43WBbEEMCEmR0vVpl6WlC9QFdSU/GtL3Zn9oLr1vv7zRELLyD9UGpXbUX97R8ZCzqcMhN6+KJPPcCdd5UOioVf9WskVEiYqn2elOZRJvIc7/vs6x1fCQ6erjgXvZ5XxvvGOogd2GxJvrtVsmUSU1hiHf3WZlXbsgIt7LRNSqzR7Cf8VduPwv7h2Lyd0HpYf6h7acBmPOqs357PrnIvh5SQrfNSkRTvE25+p2JYlHeh7Gq3D6c+BIFG99rYRiNHbo9Akj/Iw4aJSYX79LxrF3eYzHTNt+SgE5lXJ1Ij5Q/jdgFZGXWDMdIH7q4CprkP3MZ07uOx8A/1ULGNwb5c+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n1fjLsG4nbCvJKFLcNOtSKEi06xvb/gp20X8CvYSCLo=; b=FDLGb3A+r80zbg9bO8PJyJeYd4PS0Dttw92TypfRAOaN3vzF18Z3jse1tcewN94//MBWAA775OhTa1lUyt4NIwXmSUFJaCtu15etme8XDp7Rv5OubnXe7rZcBkU5x8B+2NYm14+6hOSosEHxZDXU2EdaCnXkF3a9K+s6pgNBc0OUsnFTLl5prHR65O1Lx7jMoRQm0zM6pSrukSG9wt+n1+MiE0PKJy6D73aozha82iO7ENGsLunW/hOiZO4U4rxOE7nDGzrw1ZuHAtMo9BBsTBOQeotDnL0UbyK4EI9r07vRJ28lpdOuSXNWJb5DVjh09xAeLm8T35X5YFHEdmwrMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DM4PR11MB5424.namprd11.prod.outlook.com (2603:10b6:5:39c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Mon, 29 Aug 2022 14:21:40 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2080:d65f:9c32:7749]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2080:d65f:9c32:7749%4]) with mapi id 15.20.5566.016; Mon, 29 Aug 2022 14:21:40 +0000 Message-ID: <b60d3fe3-40bf-25e5-9644-620e6eec3b9f@intel.com> Date: Mon, 29 Aug 2022 15:21:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v3 1/3] eal: add lcore poll busyness telemetry Content-Language: en-US To: =?UTF-8?Q?Morten_Br=c3=b8rup?= <mb@smartsharesystems.com>, Thomas Monjalon <thomas@monjalon.net>, Bruce Richardson <bruce.richardson@intel.com> CC: Jerin Jacob <jerinjacobk@gmail.com>, Anatoly Burakov <anatoly.burakov@intel.com>, dpdk-dev <dev@dpdk.org>, Conor Walsh <conor.walsh@intel.com>, David Hunt <david.hunt@intel.com>, Nicolas Chautru <nicolas.chautru@intel.com>, Fan Zhang <roy.fan.zhang@intel.com>, "Ashish Gupta" <ashish.gupta@marvell.com>, Akhil Goyal <gakhil@marvell.com>, Chengwen Feng <fengchengwen@huawei.com>, Ray Kinsella <mdr@ashroe.eu>, Ferruh Yigit <ferruh.yigit@xilinx.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Jerin Jacob <jerinj@marvell.com>, "Sachin Saxena" <sachin.saxena@oss.nxp.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, Ori Kam <orika@nvidia.com>, Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru> References: <24c49429394294cfbf0d9c506b205029bac77c8b.1657890378.git.anatoly.burakov@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D872C4@smartserver.smartshare.dk> <YwyXyFZVXhuK1lua@bricha3-MOBL.ger.corp.intel.com> <2555175.9Mp67QZiUf@thomas> <cf93ce5c-a2e5-eeff-cd76-df574db85235@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D872CD@smartserver.smartshare.dk> <77ff0a3b-7b1b-84c8-36ff-136d2d634e0b@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D872CF@smartserver.smartshare.dk> From: Kevin Laatz <kevin.laatz@intel.com> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D872CF@smartserver.smartshare.dk> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB3PR06CA0016.eurprd06.prod.outlook.com (2603:10a6:8:1::29) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 79da4b32-24e3-47c5-c5bf-08da89c9ca5c X-MS-TrafficTypeDiagnostic: DM4PR11MB5424:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sp4dhfTiS3B7KFkV76rGWouiheHbnJNy4NPqNK9OF4sFR+DSEKVBkKlYNSJgkVcsvnRFcrZC9TVFOzFAqaogsHv55jetdB1p6guEg4BTRpcGeauQ5RcI+z44qJMC6+i02Ghupzth/XfEQjRO8wTi6Q6Yx2K8VFNXFHniT10MUFoPXnuFksuJ/IYicsiK0oxCJDDSJhxAgRDdFuZsv8DJMAYhw5LIgSGk2pFb9MjjvsoIWw9GxAA5W/Ygi4YNeSFc9Xz/+cMPKGZ3sLBonPdIyHzhIO9YXYxAe9fdN6B+frhUQRWRo6ywSGDe5L8H56YIfP8sL/RiYP/NS1WoGWpoG2T3ax3To4zroJt2M6aoi7KaG/cz3MjeZDtEdqGWzwg+svAUfzzMXtMHNha96rde/S8rp4iRjxn0Cl08RZXSB95gC/U8dkyDRDVf4lkk38LpPGdCXFDdy78tTFJadiSaiz3Ioc0dBMeggJKJUGUC6NtIAXnuZc1p3Wlx8dK88oLdgHC9GNa1j4eYwF/rwKKocK1RnWGnVmqn42ktS7i4lvTwwfQuFhZxOV259PcL0RQ8PR02rdgY8qXEGhnpVdeBEXe7SxHHqqRWVMe/MT4UlfjKbMbcluITJtefAraC7/Vetbjszxt5wpKDlx8BJMZY2yPGFl+HNBbPOvHu/+Y6osYFTdax0/9opFGZObJ1hDWcaLip2HVEfrNfZcU3bS4cku2nJdg8Z5UO5PJkohnJlRiOcz5ZEFTzLb9F6q52smZqLAdiRjv0BQ/njT/fuE7TJNHK3cN+SXAr52HprfvZUVg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(136003)(346002)(396003)(376002)(366004)(2616005)(66574015)(186003)(6636002)(316002)(31686004)(36756003)(6666004)(26005)(44832011)(53546011)(6506007)(6512007)(83380400001)(2906002)(38100700002)(31696002)(86362001)(82960400001)(8936002)(478600001)(7416002)(41300700001)(6486002)(5660300002)(54906003)(110136005)(66556008)(66476007)(4326008)(8676002)(66946007)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3l2OTJKL1VGdzdhcnAxVjl2R3lSOUlCbk16MFRCUGc4eE84RnZaM3JsOU5S?= =?utf-8?B?bVRRSjBxZG53ckt0M0FYb213QjdRUktDRHNUaUErTDlYdFczOE9xeXlEdWVl?= =?utf-8?B?MWFhdUZhSWI5RUVjdFpRRDRTZXA4RXpPZXFRQ2FQdk8rZWVkSWJUbkJPNTI2?= =?utf-8?B?Q0Fhc0xXaTZuNlFCVHhGamtRMjI0RndTb1NucitEeXNaMWhNNkN6N0dkQ2Jp?= =?utf-8?B?UEY0VXlwdE1QMVF2bURYeWM0dEh0TkNVc1NRQnlzQTZKbm82OXN4bHhrWjYy?= =?utf-8?B?b3hybVl2WTg2Ykg3QTRSQ093U0pBTEpacEVDVFhsK1pDVnF4bHM5dEVibWNC?= =?utf-8?B?cHIwU2NvOE1zUWtMcWZPb053Y0JtdEFmZURjODdCcTlzVlo4UWJrRUxvWVZv?= =?utf-8?B?aDZ5R1FnbXlMb3p3UEo1QmkyT3BmUlRPVXZlVzBMMUlTMEw3SDlPaGJpOU5I?= =?utf-8?B?VEt2T1A2UFhSZ2dnMWVERCtsbFBiK29ScU9KSWZLTERJd3hMRFY3R2xPWlpO?= =?utf-8?B?TE84MUV3bi9LQ3dhUUVLT3dGUHhhOEtsRmRKUjhtUkxHbWp2a0NyajRxcjBY?= =?utf-8?B?aXZ3Y082SklSZnFscVBORWtQS3NYVDhnVWJoRHZmb3duUG5BOG1pSm1WbHc1?= =?utf-8?B?UXh1a0kyZnhhaCtPRi81NktoNGROODJuTFdjM2hNQ0VRYlBvN2pKcm5lL3Ja?= =?utf-8?B?VDJaeXdiR2hNUy90dnVneERjMVlsNldyaDU3Z3hGcXVtVDArZVMzdUUyMEQy?= =?utf-8?B?WVQ0UEpVUUoyWWxrZEp4TGk3cm45YVN5QTFHZ3MzYVRoMXgxbFdsbThxTHgw?= =?utf-8?B?dnZYaUNLWHlSSGlNRTF6cjVPRkN0Ui9SeXVvUHdlc0RNL2pJdlYrWEdVeVBj?= =?utf-8?B?RzhkL1Fma210ZXZ4Zktpa2VxZEo1TU4vL3pEdlN0ZTN1UFYrNjhCdXl5SWlU?= =?utf-8?B?S1c1aGpUbm1PemNBRXZHeWdMMjlWRW12OUsrUmMxSlkvUTRMemNTcW1NSWRR?= =?utf-8?B?RHJsS21KN1lrRFBHRU1QY0NqK0Q1UVZWdXdsMzVxblE3Y0RhWVZ4RGZQNXlt?= =?utf-8?B?dEg3dVVuTzVZcndHMEhPRWJnMDVqbXF5eUlMOE1CL1JCS2QwbXVmZ2oyUTgz?= =?utf-8?B?M1lZckZwTXlnY0FDZThOK05CSHpBZkpsV3pFSkt0UU5Ic29lczg1QkdYWWdi?= =?utf-8?B?R3Zob1dHbFBKZUw2WjFVTEdzWmdTS0Q5YSs0TEZTSzBIVXpRM3ZFU2tFRjF2?= =?utf-8?B?ZHFCK1B5NExiZjRBd3N2ZjlFbFIzUy85eW92UWwzT2xOZ0hIN29CSnFQU3R5?= =?utf-8?B?ZTBVM0dJQ05CUDhWV1o1QU00YUhBNVV3Z2ZxMHJvaUJ2ZjNzK0dOdGNIY1BK?= =?utf-8?B?SS81T1RpRnJBNFVjVDBoa3NlSVVkeCtobFZGUHZHSGdwRWQxb3dCM1J2b1Fs?= =?utf-8?B?QW9TYzBVbEFKcmtPVmtNbFlWU0hNSGZYUXRFZEw5RFJuU29Hc2hxS1JZRitU?= =?utf-8?B?R2ZjT2x5YmRUSFJjYytiajRrWGxHd05ydncxVENBTDZPTi8zVnJZdW5wSjVq?= =?utf-8?B?Yjl4bWs5ak5TUDZvaGJ1a1l0Q0J1WDZ0eVVmc0FINEUzc295amx1Uk9oaWRl?= =?utf-8?B?bURQSm1DUXRqbjJuZzBmV2lvVDEzTjF4dFFhWkNjRGJyUmNIWjRNeTEzRnFm?= =?utf-8?B?UTRldnc4VFN2MjBwemNUVDlZWmg3eTZXZkUyaS9xZTN3WEY3N0JRcGdIOEIw?= =?utf-8?B?bFlpSGR5UzEyWW5sNlJ6eXBvMHd2WVJPdXg0dVo5SWdTSVpEL2xsOTZwclJu?= =?utf-8?B?TWIrbjh1MU5rMDRCM3pFQ0NxeFRDYkRjOWRlQ3Uzb2cvNDRab0JIcnE3KytR?= =?utf-8?B?YjV0Q0l5eTlYVWRlb2szUGR6YXU2c1hnbGs0SVFkVkpkcjFwVENhdlZWS0ZD?= =?utf-8?B?MlhZY3dyQU11enFmbVZIZDh6L2FJcWV5NDdGU3ZJbUoyS1JqN1ZGd1JLRGtv?= =?utf-8?B?WG1RVGhiaUc2YVZpUlp4VXhsODZ4cDBFS3RkRDkyMDF6c3lvUzVuUW5OeHQ0?= =?utf-8?B?NWxTVkJxUXRhZkZ4ZytzbXJyWEJFa1A5VEVCekdrQ3JlUDkwTGdUNncvV3Rs?= =?utf-8?B?VXYyaFJpRWpGamNKeG15YndZN2RrLy9KSXoyMUtNK0tuTXJEMkEyRi83Z3N3?= =?utf-8?B?RlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 79da4b32-24e3-47c5-c5bf-08da89c9ca5c X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 14:21:40.5824 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TWX2LVW4/eKZbfoZ6A6ika5Uo0rmRYOq5kqVFy4EPjalDTNwjsMqwHy4Q+tsJ1PC12Wg8bkxyYg2z91EBmARrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5424 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 29/08/2022 14:44, Morten Brørup wrote: >> From: Kevin Laatz [mailto:kevin.laatz@intel.com] >> Sent: Monday, 29 August 2022 15.37 >> >> On 29/08/2022 13:49, Morten Brørup wrote: >>> From: Kevin Laatz [mailto:kevin.laatz@intel.com] >>> Sent: Monday, 29 August 2022 14.37 >>>> The patches currently include runtime options to enable/disable the >> feature via API and via telemetry endpoints. We have run performance >> tests and have failed to measure any performance impact with the >> feature runtime disabled. >>> Lots of features are added to DPDK all the time, and they all use the >> same "insignificant performance impact" argument. But the fact is, each >> added test-and-branch has some small performance impact (and consume >> some entries in the branch prediction table, which may impact >> performance elsewhere). If you add a million features using this >> argument, there will be a significant and measurable performance >> impact. >>> Which is why I keep insisting on the ability to omit non-core >> features from DPDK at build time. >> >> I think there's general consensus in having a buildtime option to >> disable it. >> >> Do we agree that it should be buildtime enabled, and runtime disabled >> by >> default (so just the single additional branch by default), with the >> meson option available to disable it completely at buildtime? > No. This feature is in the fast path, so please follow the "enable_trace_fp" design pattern, which also has fast path trace disabled at build time. > Ok, will make this change for the v4. Thanks!