DPDK patches and discussions
 help / color / mirror / Atom feed
From: dwilder <dwilder@us.ibm.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Aaron Conole <aconole@redhat.com>,
	Michael Santana <maicolgabriel@hotmail.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>, dev <dev@dpdk.org>,
	"Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>,
	David Christensen <drc@linux.vnet.ibm.com>,
	David Wilder <wilder@us.ibm.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/3] ci: add travis ci support for native ppc64le
Date: Wed, 19 Feb 2020 12:32:41 -0800	[thread overview]
Message-ID: <b61836a1d3a00fb25d1fb854121dbbd8@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJFAV8z2fRcWJq-U-S0CNPMo1q+wKmdZWdDwTrs4ue1-5KffFg@mail.gmail.com>

On 2020-02-19 05:46, David Marchand wrote:
> On Wed, Feb 19, 2020 at 2:10 AM David Wilder <dwilder@us.ibm.com> 
> wrote:
>> 
>> This change follows the example of aarch64 Travis support
>> by adding support for ppc64le gcc builds.  Limitations for
>> ppc64le are the same as aarch64 as described in commit
>> 31bb45bcfd.
> 
> checkpatch did not catch it because of the \n (?).
> When referring to other commits, please use the format 'commit <12+
> chars of sha1> ("<title line>")'.
> 

Ok

> 
>> 
>> Signed-off-by: David Wilder <dwilder@us.ibm.com>
>> Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
> 
> I can see no clang compilation.
> Is it unsupported? forgotten? unwanted?
> 

Unsupported for now (issues with altivec).

> 
>> ---
>>  .travis.yml | 30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>> 
>> diff --git a/.travis.yml b/.travis.yml
>> index 1d43f16ae..c15bf4f07 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -153,5 +153,35 @@ matrix:
>>          packages:
>>            - *extra_packages
>>            - *libabigail_build_packages
>> +  - env: DEF_LIB="static"
>> +    arch: ppc64le
>> +    compiler: gcc
>> +    addons:
>> +      apt:
>> +        packages:
>> +          - *required_packages
> 
> Copy/pasting this part is useless.
> The addons: global node would make all jobs use this required_packages
> as a default.
> I have a patch cleaning this for arm.

I see your cleanup patch now.  I will refactor the ppc support on top 
and let you know if I have issues.

Thanks for the review.

      reply	other threads:[~2020-02-19 20:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19  1:10 [dpdk-dev] [PATCH v2 0/3] add travis ci support for ppc64le David Wilder
2020-02-19  1:10 ` [dpdk-dev] [PATCH v2 1/3] eal/linux: select iova-mode va with no-huge option David Wilder
2020-02-19  1:10 ` [dpdk-dev] [PATCH v2 2/3] devtools: allow test-null.sh to run on ppc64le David Wilder
2020-02-19  1:10 ` [dpdk-dev] [PATCH v2 3/3] ci: add travis ci support for native ppc64le David Wilder
2020-02-19  7:55   ` Thomas Monjalon
2020-02-19 13:46   ` David Marchand
2020-02-19 20:32     ` dwilder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b61836a1d3a00fb25d1fb854121dbbd8@linux.vnet.ibm.com \
    --to=dwilder@us.ibm.com \
    --cc=aconole@redhat.com \
    --cc=arybchenko@solarflare.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    --cc=ferruh.yigit@intel.com \
    --cc=maicolgabriel@hotmail.com \
    --cc=ruifeng.wang@arm.com \
    --cc=thomas@monjalon.net \
    --cc=wilder@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).