From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1E2BA00C4; Fri, 1 Jul 2022 14:02:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 901904069D; Fri, 1 Jul 2022 14:02:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9009940150 for ; Fri, 1 Jul 2022 14:02:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656676977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lF0jtDRtEsby4pArJZdw9L2ZzLmdOCtm2Sc4xThxB8k=; b=MdC8Sfj/C3zsn85ex9NYH/itrES1UZTWfs7n3OQR5scJ+8ueCxXfboCqgPHsZ0H0viFJC0 RDaZJ+U7QXfeuk9WFhU4cyMtVklL8HHpUf/kzR7f8Xhtffv10AMTKDLUxuaSd7H6zh63bF ZcmcTonSViWNjoUrG+jyTJYUY6xWy70= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-643-MR8NCZs4PZeaUsZcPcVg4w-1; Fri, 01 Jul 2022 08:02:51 -0400 X-MC-Unique: MR8NCZs4PZeaUsZcPcVg4w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD3EE1C08984; Fri, 1 Jul 2022 12:02:49 +0000 (UTC) Received: from [10.39.208.30] (unknown [10.39.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 026F540334D; Fri, 1 Jul 2022 12:02:48 +0000 (UTC) Message-ID: Date: Fri, 1 Jul 2022 14:02:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] vhost: fix virtio blk vDPA live migration IO drop To: Andy Pei , dev@dpdk.org Cc: chenbo.xia@intel.com, rosen.xu@intel.com, qimaix.xiao@intel.com References: <1655884028-193120-1-git-send-email-andy.pei@intel.com> From: Maxime Coquelin In-Reply-To: <1655884028-193120-1-git-send-email-andy.pei@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/22/22 09:47, Andy Pei wrote: > In the virtio blk vDPA live migration use case, before the live > migration process, QEMU will set call fd to vDPA back-end. QEMU > and vDPA back-end stand by until live migration starts. > During live migration process, QEMU sets kick fd and a new call > fd. However, after the kick fd is set to the vDPA back-end, the > vDPA back-end configures device and data path starts. The new > call fd will cause some kind of "re-configuration", this kind > of "re-configuration" cause IO drop. > After this patch, vDPA back-end configures device after kick fd > and call fd are well set and make sure no IO drops. > This patch only impact virtio blk vDPA device and does not impact > net device. > > Fixes: 7015b6577178 ("vdpa/ifc: add block device SW live-migration") > > Signed-off-by: Andy Pei > --- > lib/vhost/vhost_user.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > Reviewed-by: Maxime Coquelin Thanks, Maxime