From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Nobuhiro MIKI <nmiki@yahoo-corp.jp>, chenbo.xia@intel.com
Cc: dev@dpdk.org, stephen@networkplumber.org
Subject: Re: [PATCH v2 1/2] vhost: fix constants to follow new naming convention
Date: Thu, 9 Mar 2023 17:33:14 +0100 [thread overview]
Message-ID: <b64b92a0-37b9-5af9-7062-a6f46dbc6609@redhat.com> (raw)
In-Reply-To: <20230309051643.70171-2-nmiki@yahoo-corp.jp>
On 3/9/23 06:16, Nobuhiro MIKI wrote:
> DPDK apps (e.g. dpdk-skeleton) output this name
> during negotiation. But, it is not consistent when
> debugging using QEMU as a front-end, for example.
> This is because QEMU already follows new naming convention [1].
>
> Some type names and variable names, such as VhostUserSlaveRequest,
> are still in old naming convention. But, in this patch we
> only focus on constants.
>
> [1] https://qemu-project.gitlab.io/qemu/interop/vhost-user.html
>
> Signed-off-by: Nobuhiro MIKI <nmiki@yahoo-corp.jp>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> .mailmap | 2 +-
> drivers/vdpa/ifc/ifcvf_vdpa.c | 4 ++--
> drivers/vdpa/mlx5/mlx5_vdpa.c | 4 ++--
> drivers/vdpa/sfc/sfc_vdpa_ops.c | 4 ++--
> lib/vhost/rte_vhost.h | 8 ++++----
> lib/vhost/vhost_user.c | 14 +++++++-------
> lib/vhost/vhost_user.h | 14 +++++++-------
> 7 files changed, 25 insertions(+), 25 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2023-03-09 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 5:16 [PATCH v2 0/2] vhost: fix names " Nobuhiro MIKI
2023-03-09 5:16 ` [PATCH v2 1/2] vhost: fix constants " Nobuhiro MIKI
2023-03-09 5:36 ` Xia, Chenbo
2023-03-09 16:33 ` Maxime Coquelin [this message]
2023-03-09 5:16 ` [PATCH v2 2/2] vhost: refactor " Nobuhiro MIKI
2023-03-09 5:36 ` Xia, Chenbo
2023-03-09 16:33 ` Maxime Coquelin
2023-03-16 14:47 ` [PATCH v2 0/2] vhost: fix names " Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b64b92a0-37b9-5af9-7062-a6f46dbc6609@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=nmiki@yahoo-corp.jp \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).