From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by dpdk.org (Postfix) with ESMTP id 7B47D961B for ; Mon, 20 Jun 2016 04:19:59 +0200 (CEST) Received: by mail-pa0-f50.google.com with SMTP id hl6so45704807pac.2 for ; Sun, 19 Jun 2016 19:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=5DtPOktwPAX9NqBvYaCHC/fXkoki6ndAEn14i1enumA=; b=1MEkVQovrSNxHc2r8tuTO18pHZSNnK4sHzzK6ymlHwEBGyw1rZ0VD+GnqYJCB7B93V IzHIqs9JPnrDupMwVEQxtTO7jteOWyXgII/1JqrCJDghpOt8hkqcn3dtomGK28Ij7XcW 3FhpDBYp1E6m1nogTWGRSabrci4H3l3U+59dl897ADiFFU0XipKK/YomKmNkECKpA0y0 ccUW/P1YhjZAwmKxoqMnuF1cW69lMk8AtXp6kvHdx7BUJKRNGKNS181S7l6h1ZChkikZ HQkOYNDYYUyBoTx5y60wk7TiafylfKQ2vKRSWVtGLO281CsWKPhYOg1XfxmxH9Hjedxt P1Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=5DtPOktwPAX9NqBvYaCHC/fXkoki6ndAEn14i1enumA=; b=fdmWpH0NlHehv1/hssEYiN++dWCPt/GX5lnon646cI+Rj4CS7HHhkUwpmNSOR/ctBG qpI6syrfc6TPz7eW/UgNRfaWzOIdoNH5M9RazzqUscuVUWULEsKb+1E7Z1/YKmL6PSbP 0ZiH3hnRSUFgf1UN8OUjmKppCE3odU5xrRhHbrLEkmmhF5GXd+w/A5fNvY0a/zyLVVTX 3Q2hoOT+Frd31F4Z5aUlqr5eDpKQKfdVIntmR8xvgxvrRXhUr/tJPvdBKNo6KT80gNTE k6EHD+LER8qYBBExJYruI8pwuuXq3SzCSMxoB/T8Na9QFE14Q8wArtP/MtHLyZbianrW VH+w== X-Gm-Message-State: ALyK8tIFSZX9ogYkrv7f91vpPrJ1x5MjEg3pFkMkrv+ZTCwgXq9x9y5VUYwSmDLq+xmdkD4v X-Received: by 10.66.157.8 with SMTP id wi8mr18969556pab.21.1466389198650; Sun, 19 Jun 2016 19:19:58 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id r7sm26448914pfa.3.2016.06.19.19.19.56 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2016 19:19:58 -0700 (PDT) To: David Marchand References: <1465961172-28253-1-git-send-email-mukawa@igel.co.jp> <1466044391-3210-1-git-send-email-mukawa@igel.co.jp> <1466044391-3210-3-git-send-email-mukawa@igel.co.jp> Cc: Thomas Monjalon , "dev@dpdk.org" , "Mcnamara, John" , michalx.k.jastrzebski@intel.com From: Tetsuya Mukawa Message-ID: Date: Mon, 20 Jun 2016 11:19:57 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: Fix resource leak while secondary process maps pci devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 02:19:59 -0000 On 2016/06/17 21:28, David Marchand wrote: > On Thu, Jun 16, 2016 at 4:33 AM, Tetsuya Mukawa wrote: >> This patch fixes resource leak of pci_uio_map_secondary(). >> If pci_map_resource() succeeds but mapped address is different from an >> address primary process mapped, this should be error. >> Then the addresses secondary process mapped should be freed. >> >> Signed-off-by: Tetsuya Mukawa > > scripts/check-git-log.sh is not happy : > > Wrong headline uppercase: > eal: Fix resource leak while secondary process maps pci devices > Wrong headline lowercase: > eal: Fix resource leak while secondary process maps pci devices > Headline too long: > eal: Fix resource leak while secondary process maps pci devices > Missing 'Fixes' tag: > eal: Fix resource leak while secondary process maps pci devices > > > checkpatch is not happy, but I think we can ignore it. > > WARNING:LONG_LINE: line over 80 characters > #48: FILE: lib/librte_eal/common/eal_common_pci_uio.c:93: > + (size_t)uio_res->maps[j].size); > > > Anyways, looks good to me, Thomas, can you fix the commit logs of > those last 3 patches on eal ? > Thanks. > Hi David, I appreciate your checking. Next time I will check check-git-log.sh before submitting. Hi Thomas, Could you please let me know if you need the fixed patches. Best, Tetsuya