From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 85035A0C54;
	Fri,  3 Sep 2021 12:43:56 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 03AA640E01;
	Fri,  3 Sep 2021 12:43:56 +0200 (CEST)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by mails.dpdk.org (Postfix) with ESMTP id 3DC6440DF7
 for <dev@dpdk.org>; Fri,  3 Sep 2021 12:43:54 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10095"; a="219448997"
X-IronPort-AV: E=Sophos;i="5.85,265,1624345200"; d="scan'208";a="219448997"
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 03 Sep 2021 03:43:53 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,265,1624345200"; d="scan'208";a="689596875"
Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86])
 by fmsmga006.fm.intel.com with ESMTP; 03 Sep 2021 03:43:53 -0700
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
 fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12; Fri, 3 Sep 2021 03:43:52 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
 fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12 via Frontend Transport; Fri, 3 Sep 2021 03:43:52 -0700
Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.42) by
 edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2242.10; Fri, 3 Sep 2021 03:43:52 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y9k+wT1FdvfPk1+T45DO7zr17ExTkXg+qaWcW8CJpDcDDNki6RXsvYeq1ZpuvO3TECVX0DsPvdZ+WkUsq/h3C3ivhPK5ZgCU/fGJRToPO/yhzKK+QeR4dA/Y1TaJGQ76Mx+wyDJEKgelN80yzFpMLXdfSRox3b8KqQV87wvSJO+MuZ5RsJcEvP4i5cKjc0FgKNZjfpPpPj82lxY4B9zu4C5LboBU8ceo3rI4viMrpe5LqiVQLgf+qzNWpjvjL00tsF+GrVCZOKw7wjn94hSG01znN0O8kurXht7WPS1t0YLdRGQnZ9snAMiTbEw7CdBnAFzfsEQoxxLrB51TwkeWBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=F8S1717wXZj/NgeDUK857djunHVVLgzG/yXIT9yqGwI=;
 b=MrQJoFJ/QRMOu/pkAFkK0nGj3M+l2JfkP6jZY9/a4Re2WQACO1hBqhgS1XFwhgjLdM4SrcS+UEWSF3bRCiTUVVE3/e5Vi72Q98zDHble8mjiFXzse4+ivjycUYaf6yGzriAp63t0WWt2SdgKwEjvTYPRSeuwRoftHbFBrj+doFneKVWBsR8W0hKFq1FCSyTDWQXliSSpELeva4V8JURNE+7HDREgpGItIZt5+mDCP8cnuyxOBWMq4WMoUBqn2bvvSFwt752Cjl6+9rMRvJ+C2opmV83XbA5PDZrKqWtggPn05MtbMGVVcRYnfj98S9O9DoAsbHem60INV1W+V2Mamg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; 
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=F8S1717wXZj/NgeDUK857djunHVVLgzG/yXIT9yqGwI=;
 b=I1GoDLg/Vo0nVlSMCBVWbzTCIFH6rbejv1Wwvq4Yj92dWpc3Z8GmLK7NKrJrkTDIZM1fFCYAJDLDjkjIQgqLkKjXTzadTZyFDemEHZIWQJdt+1wO9gqLaaBtDBoS3ocX/0SyZYND90xtrrhk5RZCPhyX7uxqtt/4+DgHHZdfytc=
Authentication-Results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=intel.com;
Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19)
 by PH0PR11MB5032.namprd11.prod.outlook.com (2603:10b6:510:3a::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Fri, 3 Sep
 2021 10:43:50 +0000
Received: from PH0PR11MB5000.namprd11.prod.outlook.com
 ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com
 ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4478.022; Fri, 3 Sep 2021
 10:43:50 +0000
To: Haiyue Wang <haiyue.wang@intel.com>, <dev@dpdk.org>
CC: Alvin Zhang <alvinx.zhang@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, 
 Beilei Xing <beilei.xing@intel.com>
References: <20210817071652.9939-1-haiyue.wang@intel.com>
 <20210817071652.9939-2-haiyue.wang@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <b72bda2a-a0fc-6ae0-3e9c-ba3a55772acd@intel.com>
Date: Fri, 3 Sep 2021 11:43:45 +0100
In-Reply-To: <20210817071652.9939-2-haiyue.wang@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: DBBPR09CA0020.eurprd09.prod.outlook.com
 (2603:10a6:10:c0::32) To PH0PR11MB5000.namprd11.prod.outlook.com
 (2603:10b6:510:41::19)
MIME-Version: 1.0
Received: from [192.168.0.206] (37.228.236.146) by
 DBBPR09CA0020.eurprd09.prod.outlook.com (2603:10a6:10:c0::32) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4478.19 via Frontend Transport; Fri, 3 Sep 2021 10:43:49 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 03494e59-bff5-4c50-87d9-08d96ec7b77b
X-MS-TrafficTypeDiagnostic: PH0PR11MB5032:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR11MB5032D7F84415ADAFB11A9D7695CF9@PH0PR11MB5032.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1201;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: WxINRYN/cEW5mHk6v+Nyht9u0RHC4SSSAtHw0WDA3hNgZdRDYEf5s2giax8+VWlnG5tQs28AQ1MbjA9igr0QbVkHCeT06K7F/kms2I6Ut7m1RBbR911Uz7k/f9lH/qxb22KuWJR3gthyrUDTZ6acRoCkVuTA/3BK/MpEoZdQuBClmlyENDOwgF6oIgwCePU8A1bRx12RqkU+Zt0QMVZF7j0XlYL/hu2LieBvBD2td3ktGioheJp7TQHkuUslgS4xRQ3+P1sadzrhZdKHgntMC8I/cs0RGds7MuTxOEI01BzKBDAw0S+ujjxtLNTbJHx0EJSJtPYFnPyCubs64DlIHM/UYH9R2urn8yWp7fxhuUQtKGOHKka8zC+r4PvNHLjET5SJrcaXxoQdiB/pnGdjmxtVj7e7fCo4KbQuG9LeoY91JU9GVmO9CvtuOYPGGnNbp13pTXFsy4fr5g0wKG/aDH1srrrIF0RRtIkP+CFi8YpU0CRUvpizm5GIq3zkU4utOgCpc2e6KIN4oF8OXSS/oxe4pWvWSBBxo+3pw4uibrONE4Lmul6HGLo+A16mOZeJPuN03wWdmncntI2oFRP8uap1J9X/RU/PWVezROhyOOHE+nRpaU2veZywyfNGP7nnB9/jt5MJcHUIPpYGwELtIi0ICSMQadMfeon2seHgYAukoftmB5e0MSvS/dVS/nigOLkUGtF9aFWVnU7IlG49aw==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(39860400002)(366004)(376002)(136003)(396003)(346002)(66556008)(66946007)(316002)(66476007)(6666004)(186003)(5660300002)(31686004)(107886003)(6486002)(26005)(2906002)(956004)(2616005)(16576012)(8936002)(8676002)(4326008)(86362001)(44832011)(53546011)(31696002)(36756003)(478600001)(54906003)(38100700002)(45980500001);
 DIR:OUT; SFP:1102; 
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnlicUNEMG95bERRbjRUWWFZV3NnU2lGVTNQdytKNTBSS1dzZ0xhQkpPVi93?=
 =?utf-8?B?bllSMTFXU3QwNE1nOGgvZ09UcVVrWDhQYWJiWW1ZYWxldmQrdmJYNHpOcS9s?=
 =?utf-8?B?REVXdjBxMW12dHI0aU03Z0gwNCs2bHdleEttdTFTUFU1and0VkwraWdpcHNa?=
 =?utf-8?B?Y0JTR0l4UytvMU1pY0FzZDJDWWxSTUNPa1phVkk1OFovQmtEN29XYTBLbm9z?=
 =?utf-8?B?alZ4ZzBFbWt3ZWRCeFYrbmFrMDZXbTF0UzdIbURRY25GaXZEWkIrZDR4bmxO?=
 =?utf-8?B?T0RGTlhMOW9XR2Rwa2JYUWcxczVwVHBVTTg0WEZyQ1pVSllxSkFVa0JyTCtJ?=
 =?utf-8?B?MjBVb3ViM2toSHVKdTZpZlR0OXZuRWhha1RYcmJjYVZqZTJGc2lmRFJNT0l1?=
 =?utf-8?B?VmlXY3h3ajNsUEp4YVEzeU5HcDVBdElYdnVYVll0Y1RUd3gxUlRDYnMrOUIv?=
 =?utf-8?B?N09kR0ZLdkZoRkxlQitCUzhyQTNNL29mTVJ3b1d2T0d5dkp1OFpmeVNFZTMy?=
 =?utf-8?B?bTFDYnFLODY2TTVxeElIZXprbVZzMlhQYmRzQXNWUnQ0dVBCR0pobmdKS3RX?=
 =?utf-8?B?SUVOZ29teDZRWngrbW1pRWJDbWdueVBZNlpkTTZZUW96cFRJdzVJSCtnNmRu?=
 =?utf-8?B?VE1qZ0xVa1V6dFBId3AvQk1aSkNsZXFCOEMzNkV4WkMzMWhYZVZ2VERIUHEz?=
 =?utf-8?B?ak9MT3dRQlZ2M0t0a1RzcTBZQjBxZXlsWjdOVm1VTlFqYXRxTnJEcUhaRTNR?=
 =?utf-8?B?K0V2THlmcFpGdG84ZlFjSW1YZFBiMU8xc1pDYU1jL0V5YUhPRkluOGk5NGIw?=
 =?utf-8?B?dnkwZ2ZJbmpteS9DUWJYazVDZHplblU0SFY0Q2pZZTB5ZFFBR2EycUMwMFRs?=
 =?utf-8?B?cEhMMmtzV0dEeVdTcktCRmx0RU1jNS9SNWJ4LytpV0l1TW9RUUNNRzEwTWRC?=
 =?utf-8?B?ZjdkS1dXdEh3NktROERyd3drZXFGN2xRak0vNTU4Mkd1SkljaEdSbzlrTzB1?=
 =?utf-8?B?Ni9DQlRKR2JVZkZVcU9ZOTlyWHJWcldYNkQzVnZ4RVA5dTlWZ2N2KytyT3lU?=
 =?utf-8?B?Rk1MRUJCRzlUS3ZYaUl0RnZJT3V4TDZBWURjN1Z3b0s5Sm1vVGlKNngyWjlh?=
 =?utf-8?B?cUNBVWlINDE4Z1dacDI5OWpXTEhRK0pLcXBDV0Qrc2p0aER4b0FsUytsY1FI?=
 =?utf-8?B?U2FKTk9jL0dFS2s5Wjk1R29ZVWh2WDU3bFc4K0lBYkZiZW5YSXVwclVuL1dJ?=
 =?utf-8?B?L2ZVcjN4MXoxRFdPVEkrR0ZoOTZCT1h5TDBCNlpyd3ZVUXQzZDdHVFVBa0Vx?=
 =?utf-8?B?WnF4bkwzVnhLWGFYMEJHRUpPcGV2azdxbWVUdGJJVjF4WC9lRXRBTlRXMUlL?=
 =?utf-8?B?RVVVN0tXaDEyRHlCdnROL0hSWXRqKzVkSzR6bGI4cTQzbUZNZzljVWNUQ2tu?=
 =?utf-8?B?U2lWZWNIOGMvSTRyZ1J6OFlLa2FFUFk0NzkxeWZKT0dJRHRTNDJYK2R0dzZZ?=
 =?utf-8?B?cTRUR2VxT3JvS2NpMVZWbE00bFIvMnkzV0RCdW5WWC96UDNKNXhmSjhXaWRB?=
 =?utf-8?B?aTU0eTAxUFdLZVpBaUZGSjBjTnk1OGhyMTBFamdWK01tQ1VqclJhb0taVUpt?=
 =?utf-8?B?MktNQUNsSnhlRHlVYnNqSG5lYTF4TWM4VEJ0UHo2OFVMc2gyb3VMSFByc3lL?=
 =?utf-8?B?MThaU05FR2VpRnFKSW5ZRjJqR2pRVUVQL1RLUUlmamFHNjlucmQ5NVpJaVFL?=
 =?utf-8?Q?F83kyJjZRSQWq9loDR1JAhphIC/tTvT36/R9mpB?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 03494e59-bff5-4c50-87d9-08d96ec7b77b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2021 10:43:50.6634 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eEHNW1RwNVAUiLNUwC117tOFBnT6EsSnSrgqJQAB7ew95e4cWS68LMbIeSPfaCkhyrxg9/+I14i+Gv/QnJfqHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5032
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v1 2/4] common/iavf: add proto hdr field
 support for L4 checksum
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/17/2021 8:16 AM, Haiyue Wang wrote:
> From: Alvin Zhang <alvinx.zhang@intel.com>
> 
> Add TCP/UDP/SCTP header checksum field selectors.
> 

Hi Alvin, Haiyue,

Can you please describe a little more, what is the impact of adding proto hdr
checksum field selector?

Is this also something related to the flow director as other patches in this set?

Thanks,
ferruh

> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>  drivers/common/iavf/virtchnl.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h
> index 9fa5e3e891..c56c668cff 100644
> --- a/drivers/common/iavf/virtchnl.h
> +++ b/drivers/common/iavf/virtchnl.h
> @@ -1598,14 +1598,17 @@ enum virtchnl_proto_hdr_field {
>  	VIRTCHNL_PROTO_HDR_TCP_SRC_PORT =
>  		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_TCP),
>  	VIRTCHNL_PROTO_HDR_TCP_DST_PORT,
> +	VIRTCHNL_PROTO_HDR_TCP_CHKSUM,
>  	/* UDP */
>  	VIRTCHNL_PROTO_HDR_UDP_SRC_PORT =
>  		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_UDP),
>  	VIRTCHNL_PROTO_HDR_UDP_DST_PORT,
> +	VIRTCHNL_PROTO_HDR_UDP_CHKSUM,
>  	/* SCTP */
>  	VIRTCHNL_PROTO_HDR_SCTP_SRC_PORT =
>  		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_SCTP),
>  	VIRTCHNL_PROTO_HDR_SCTP_DST_PORT,
> +	VIRTCHNL_PROTO_HDR_SCTP_CHKSUM,
>  	/* GTPU_IP */
>  	VIRTCHNL_PROTO_HDR_GTPU_IP_TEID =
>  		PROTO_HDR_FIELD_START(VIRTCHNL_PROTO_HDR_GTPU_IP),
>