From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id 259271BA5B for ; Thu, 10 May 2018 13:57:52 +0200 (CEST) To: "De Lara Guarch, Pablo" , "dev@dpdk.org" References: <152591991920.119328.14523975619615362920.stgit@localhost.localdomain> From: Andy Green Message-ID: Date: Thu, 10 May 2018 19:57:45 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 11:57:53 -0000 On 05/10/2018 05:52 PM, De Lara Guarch, Pablo wrote: > Hi Andy, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green >> Sent: Thursday, May 10, 2018 3:46 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs >> >> The following series gets current master able to build itself, and allow lagopus to >> build against it, on Fedora 28 + >> x86_64 using gcc 8.0.1. >> >> The first 17 patches have already been through two spins and this time are >> corrected for all the comment (thanks to everybody who commented) since v2, >> and have tested-by / acked-bys applied. The first workaround patch for the hash >> function cast problem is dropped since something has already been applied in >> master since yesterday to address it. >> >> The additional 23 patches are fixes for problems found actually trying to build >> lagopus using current master. >> These are almost entirely related to signed / unsigned or truncation without >> explicit casts inside dpdk headers. > > I think it would be a good idea to split this patchset into two. OK, but... > One for the gcc 8 fixes, and another one for the rest of them. > > We should first focus on fixes for just DPDK, knowing that the release is close. > > Could you also share what's triggering the other issues, when ou build lagopus? ... gcc8.0.1 on Fedora 28 the same. I just force their dpdk submodule to dpdk master + my series and build with defaults. I'm not doing anything to make it more strict or nondefault. The quoted compiler warnings and errors are coming from lagopus actually using dpdk with x86_64 + gcc8. I have a pile of lagopus fixes also required to get this far, that pile is still growing. -Andy > Thanks, > Pablo >