From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24A6441DF5; Mon, 6 Mar 2023 10:10:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1014740A8A; Mon, 6 Mar 2023 10:10:33 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2074.outbound.protection.outlook.com [40.107.101.74]) by mails.dpdk.org (Postfix) with ESMTP id AB6214067B for <dev@dpdk.org>; Mon, 6 Mar 2023 10:10:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ijmuqo/PMHHT+QVwjkZyGQ9J9M8PJq9bkW1pHAaGTcLJ0sC+6Q9pZrjJm+FUFf/RJGb7Ke4uslRwUmlD/cclu9WtyRjHsJZcn4XskWbRswQpKCQwxUExiiTSydh9iialkpdn37IFX2t3h2GFLki3cYrDP/c7nMycEgfDSf5ExBZaXw9sg2C/BaQNvB8rrCANgFq/IY1k162cBaJM1LlAJxpnrDx1owxbbhY8NBHWCGkDuOxAFrUApfW8ezu3N7QR0jqmn9cn8t0PbWLQ03YAMyyoflXi8H99hQmTX+uIB2mu3jt9CaSd7le0P3n2Yeeikud0yZ+LlSirR47xFnVB5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AR4ek4FhtnigkQpVgyQ00NC8UtsMFJFQW1NK5rdC6EA=; b=HcXEpAjjK1JCaUnGXTZiw/81WZM6BRiUIO7C4H7knkjCsrF5HdrcfqOmEvurwql/dlm0CF7STRoBtUvTkHy33D0IwXK6kJsEsHKWHPjr4tvCGCdTcCUn9hsR3osF6/NI7CE70qqvC1OdKrDbGdzRnhAhqUYrqrANbGkrzugn8u705JJlRwqTlxUBCFYfef3DkBPTuYOX+0GboI4HXBBKroEeYqtQq2hqGJrzEKNgGR9kFBEBX9c9mbCyfKNIG7ac14np1s3zmOQyEO52EMS+682Yp3QicgQst49VoGWmTUGOCfzm5NaknnbZFV3FQDw75hR9fnCTgmbu7Zw8adH5/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AR4ek4FhtnigkQpVgyQ00NC8UtsMFJFQW1NK5rdC6EA=; b=rRErjBYb1IIYPJF7eIcyN1yWSWAgH4CU6eZ6wgKzsLkkVyEmgxe6iNvy0ps89gjnjBn/S3YyU853Vqq1ivS9MCBPUVSyQA+3Jhr4i3n0QXdR9k++A+mMVrFGCLGFF7bC7/kRZyr2YvhYcSIwmojubbrzOkZi0giLd6SFqohPK0A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB5952.namprd12.prod.outlook.com (2603:10b6:510:1db::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.28; Mon, 6 Mar 2023 09:10:29 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%5]) with mapi id 15.20.6156.028; Mon, 6 Mar 2023 09:10:29 +0000 Message-ID: <b73ff08f-4f52-1ae5-cbfe-c3ce375635fb@amd.com> Date: Mon, 6 Mar 2023 09:10:22 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: fengchengwen <fengchengwen@huawei.com>, Konstantin Ananyev <konstantin.ananyev@huawei.com>, "thomas@monjalon.net" <thomas@monjalon.net>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, Ajit Khaparde <ajit.khaparde@broadcom.com> Cc: "dev@dpdk.org" <dev@dpdk.org> References: <20230301030610.49468-1-fengchengwen@huawei.com> <20230301030610.49468-2-fengchengwen@huawei.com> <0f387ca1eee34a7f92745de7b59a71a1@huawei.com> <bb00bf60-583c-ba6a-92d8-565a875008ab@amd.com> <b99c2140-cc94-3b6a-5569-53324e6dfc79@huawei.com> From: Ferruh Yigit <ferruh.yigit@amd.com> Subject: Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode In-Reply-To: <b99c2140-cc94-3b6a-5569-53324e6dfc79@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0681.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB5952:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e77566e-41b8-4dda-2774-08db1e22a124 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eMe8CSaoy4vgZlPg6boYK1KSs1Airx33u+fcWoKUf+qNvSwr9Z+GBDnVoLzaHhhCl1vy1rIF/grw9bQVdWvZERosG8vb/Ox5RWRdMEW+lLoPyhIcSl97ywBz8ewXTWLQdRN6HfGQbX28nOPJzFY2sUhHhshKTK+p3QRmHbYh8Lm39KfT/lrkex/slsM0mhwSTinqOg/sMcTkbiMiYiH3LSUNwzL55WdLLENfPsT2AWYJPcjjewAG6ij/hZVY7XjBpEnsBOYWSyHnCk6DcBoetef45P4KlzHT93ZkjDBVJqBQABkR1iuA+0QGColDHcXryzWMzO4KRtDnPG7byla05349KmBJptwKl3MCGnFxCTSDhSafIBYYkPEhgnLzoGlh5VvBGNZr7nuXSkfGeUJyob8gLIC/MIDMaCAMHRKHIx65a5aSEypPYUPOXRGY9FSzaNoBmoTsDGsVg2KuyrA8hlbgvA/+mIqyQLC/vHsLGrRbHgIQBdaHwguWEr6UAVyliMN7qL2mlochxgdE64HngCLTulQR94zSgZnEfonIU9Qlc+C09a3S3azVZ3hwB6v2LME/BU17oofkguslOif/1OkXAS5u4QdGIQ+zuiNBCrnVXqXKsSrD9ERRxwgpveuJiHB4zgunrERzuHceP4qCr2IQ3N39OMvNZbd1aMdEe9QJyf8XP9PBcFSEDMq3itX/00fEjgOvGl89WI0Nx1/gd/rgKuZcqYOLMqmU8IU+tFI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(366004)(39860400002)(396003)(376002)(346002)(451199018)(186003)(38100700002)(8936002)(66556008)(66476007)(8676002)(41300700001)(4326008)(66946007)(44832011)(2906002)(4744005)(5660300002)(478600001)(6666004)(2616005)(53546011)(6512007)(26005)(6506007)(6486002)(966005)(316002)(110136005)(36756003)(86362001)(83380400001)(31696002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzVtY3NKTWNybCtaZHFmcnp6aWsydkx2dXMwajNWUVNCTzB4YWtPNnJLN0Y4?= =?utf-8?B?SCszaGZLMlEvbmRjUmZEL3pKN05MMmVscjFpbVBkdXYyUTI3RVozSU5FNUpW?= =?utf-8?B?SXhNUW5iR3hveS9hQ1pLRTB5MjJpb1NJSWg0SnJ1dkptQ1FVdkF6NStJRWor?= =?utf-8?B?VXpyd0lOY1Axem5ua0l1QXpBODZ0K0oybGhPeXBEbUZQa3ovTStON1ZtRUht?= =?utf-8?B?UXN0VmZ1WmZ2R3JneUpINDN6bkFDazNlK3J1L29uRDVvbDhIdzgxNWlLT2M5?= =?utf-8?B?dVBHNnlyZmZ6by9Oc1pyWC9OeVFtWEZFb1F1L1ZUb1RJS2ozbUtqdTVYK21k?= =?utf-8?B?UTV1SEF4SzJqZkhMU1dueEhnOEgzdjdOR3M3VHFKTm82UzJjTXFXUEEwNVdk?= =?utf-8?B?L1huUDlPbE8zOWNYQktkSDIwc2pEOE1JeVo3enZYTHhONzFOV0N3ZjlzNE5y?= =?utf-8?B?bnptSzd5VzJ3anNLbjlMZEhXZ2ZhQVpzNnQxc3YvVlVuMDhIQm8vR1h2MWF6?= =?utf-8?B?SjFlYnVoRHVNcVZYdEV0cHhUWTVhUExMcThVYisrR0RCeTRONlNSd1Z1amRT?= =?utf-8?B?dGpMNUs0QlFrRVVQZW5Vb1ZKUkVmNVJDOVJBS1RjVzJFMThBc28rYkI5WkZk?= =?utf-8?B?dVVaOTJwS2doanBlMS9PY1dNQW80SXhRY3dqS2pNRTNUY3o2TVpWQllaZWpq?= =?utf-8?B?cFJ2SjR1WmJhcTZmSGxxd2lyRjBNL0loZzFUZUQ4WktMcTh4RUwwMzNQTDVs?= =?utf-8?B?aFIrYi91SDZkVk5OUC92L1FkMWRaOUpVd2Z5M01LYnA2UEJ3OVl3OUh2amVq?= =?utf-8?B?Yk8rc2U5Z2FrTVAxbEFqMmpOWXNzM3FWZUd0QkZJaGxDVHVja1Z2R1gxbXZ0?= =?utf-8?B?Y3h5bkYvem85SkxHMjF1clE3ZE9Tb0MwMTZnanVmbGxyRUNUQmpKdDJBWjNq?= =?utf-8?B?Z1Nya2RNRlZURGo5SkFtbjlhSGhPVUVCV09zbmtZS1EwS3grTmJJN0ZTUUc5?= =?utf-8?B?dkRWQURPR2tiekYvcCt0YTh2dS9kRUg3YzBwQlRsS0hFS2lxT0VCVGU1YlFM?= =?utf-8?B?QW5pMnl5RU41V002NzVmZEhkKy9tUWg1MlhVWW1DS3BEZHAyOFkyR3Q0SnJa?= =?utf-8?B?TGNYb3B0VWtZSXNmQjRGN0pML1NYdmU1b2hJNGI0NE1hZVpsMzNGUnJkUXNX?= =?utf-8?B?VmVyS29NU1ZxS2xPTnNidnFvUkh6WmRQSzA2eWprcHFERDNZdHZ4YnArMC9n?= =?utf-8?B?YU5URHJlRHNQRUJoa3RCMnBqMzA0czBDR09kZUx1SG1GbHlnUnAwbnJIekNZ?= =?utf-8?B?elV1Wnd4ZVZKOHhFOEJyMkl0T3AxYmc2THErL3UzeW5pR3VCYUhSOEtSRi9O?= =?utf-8?B?d2czT1FnS3JDZ3A4WTNUdlp3S0c5dEoyNTNVN1lQdTdlb3JLd3VzTThIUlNV?= =?utf-8?B?YmhYYWpBeGlIU2RPb3Fkb0s1Z3JCekh2Q1hnVE96UHlHb2Z1Uzl6V1hic3ov?= =?utf-8?B?N0l3RURMZFNnY1VJOUJCRjVnaC9QZVBvYVkvUTg5eE00UVp6SUt5NXJTUm84?= =?utf-8?B?YmtuSFlBQkwxdm5VNDFyb2FkZUhUSWYzUk9wUjdLbUd2U3dhcTFya1RIc3M2?= =?utf-8?B?WFZFUUo0TnBxSndvbk1nb0tveFM5VnlvemtqMUlOc05EUEg3a2JnRGppUEtB?= =?utf-8?B?R0gvN2RGTlMxdEUvSCtkRnU1cUtFOGlnOVkrQWJtaFJaTEdtVUlRNU90T3hn?= =?utf-8?B?dkI3QU5TUHhtYjhTRHZMR0Z4RlhWTGV6cWgrVlY5V3k2NFdYOTJLV25XRWpr?= =?utf-8?B?Q0F3ZGtyUzBRRWZhV0VvdzhqelFWbjFsa1cwSE8zQU5hTk54YzU0TUNFdUMx?= =?utf-8?B?VWhvSEY0TFdYdTlEOHFmT1IxNk5SVERWZVZnQXhLdUYwMlBJSFhXWVJpL2pn?= =?utf-8?B?c04wRTN5VHJVTDNYaFZpRlJmdnJ1RXd2cVpsLzFVdnFrMzFQYWVvU0JUTEpq?= =?utf-8?B?bHVMdXhDeGUycmNVU0hzelRIYXpBdHV4WVpvM1h6aXhGcGJxazNqTlR2SE5L?= =?utf-8?B?RzlSZTRWWXoxRmtCNXpGbDI5ZEtzUmpmZnJ5N2hzTFcweWx5aGJsUzQzcXAr?= =?utf-8?Q?+ERDjWKRlIIigoKXVlUSVplWD?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e77566e-41b8-4dda-2774-08db1e22a124 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2023 09:10:28.8007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OpnjZls5amzXPWw5QpTYK0UwBS3sVLJs1bGVCtvBtc2WdPqkDfe5l0/gFGvhEgDP X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5952 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 3/6/2023 1:41 AM, fengchengwen wrote: >> What if application is not interested in recovery modes at all and not >> registered any callback for the recover> > There's probably race-condition which may lead to crash, because DPDK worker > threads runs busyloop and located on isolated core, and also PMDs add delay time, > the actual probability of occurence is very very low, at least for HNS3 pmd it > has not run out for at least four years. > I understand the problem and why application needs to involve, but the question is what will happen if application is not aware of this and not handled this event, or ported from different NIC etc. Do you want to make handling this event mandatory for each DPDK application? Btw, what about my suggestion [1] to use different version of burst ops update function in PMDs to prevent crash? [1] https://inbox.dpdk.org/dev/20230220060839.1267349-1-ashok.k.kaladi@intel.com/T/#m876b5c5312391557c952198561e6823473bce151