From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4651D1B2DB; Thu, 21 Dec 2017 20:30:39 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Dec 2017 11:30:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,437,1508828400"; d="scan'208";a="13705163" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.153]) ([10.241.224.153]) by FMSMGA003.fm.intel.com with ESMTP; 21 Dec 2017 11:30:38 -0800 To: Andrew Rybchenko , dev@dpdk.org Cc: Olivier MATZ , Igor Ryzhov , Laurent Hardy , Ivan Malov , stable@dpdk.org References: <1513763534-32279-1-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: Date: Thu, 21 Dec 2017 11:30:38 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1513763534-32279-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix main MAC address handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2017 19:30:40 -0000 On 12/20/2017 1:52 AM, Andrew Rybchenko wrote: > From: Ivan Malov > > There is a school of thought that rte_eth_dev_default_mac_addr_set() > must call the PMD callback first and then save the new MAC address > in dev->data->mac_addrs[0]. :) > If this concept gets approved, it will > break the current approach used in sfc driver as the latter relies > on the assumption that the new MAC address is already contained in > dev->data->mac_addrs[0], and, if adapter restart is needed to make > the HW apply the new address, the outdated value will be retrieved > from dev->data. In order to preclude any possible bugs, this patch > adds device private storage for the up-to-date copy of the address. Thank you for taking care of this. > > Fixes: c100fd464bb7 ("net/sfc: support main MAC address change") > Cc: stable@dpdk.org > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks.