From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80BDE425A7; Fri, 15 Sep 2023 19:30:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA23D402DE; Fri, 15 Sep 2023 19:29:59 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2043.outbound.protection.outlook.com [40.107.244.43]) by mails.dpdk.org (Postfix) with ESMTP id B006C402B8 for ; Fri, 15 Sep 2023 19:29:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nXAEwjX01WNhxTQXWSNPhtds8SQushRuzb0DZYYgVU79p6LFNMzRhATcDFwoEKf+NsK3NUInQm3CjDAxJaaXP96l9hRJG96KeWHbkHk//sb8cN6iWJsWPqM3EooKWWoh8suopR1B/O9bh3ETmI08WiBkquFq7LjiVu3B4UtdBGj49Jj9OIV2/q3sIW/qkQApSilP+6ZSUZnVL8fA+bFPh3BvD5UDzfqTM2NkPIWBK1rsaGSecktpyw5lMRVPXqs4sHnzraSEmnj6tYjGekVpSxmR6VcrLoflJgh3YSCSbciYmMD4IBgXhWQ3Ip3yovJ9zsNoyYO09Mj7I/s7wshDvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ekEctf4XlwRSnVZiwD0pr7b3xISTAc/s0+yoNRp/114=; b=UVBe+d6Gd/JXjcZ7m5sCodYAuYCg7FxzbxAPbj0FU/bifnon/5vDwPHdf9KTbb1EpwkTbBindDOyyHS4hwaD7gwZZvvPGGLAJavqTFIVLx8V/x38ntSxYHAb8B+iZaBUNENs36ZIM5JCOhyzfWenbvnbAtbczKixotuG6vuAI9uCm3CPUl68caSu51wyVsRPlTbyNFxHcVrmIyIeX5BXyT+8NH+fHaeBfH2mnDRqX4T1E9IRoEsVjB6EYYOgyNsVxCO9DtDTQiZdAT7llZtGAjh0JUzyteKa9ywxsV/8uMlOjel+2rJuIMM2cOpII3lv2aieA2PrkZ69mKcNqozZNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ekEctf4XlwRSnVZiwD0pr7b3xISTAc/s0+yoNRp/114=; b=FRu8pcB34cjPH7sfUOApZb0pgRjXRrcTlCgfca1xWdCR/wd48xZbvI7m3bw956mGGVeTMH0CKKQjM8QO7B/3byEdi0w7H6rQIQq0haC6zXGFizsM5SgH03Ayf3P4PnFgNfmAKDrAIdU59F39IDzSusY+gsI5gGFEdozvhLpvfRM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB8790.namprd12.prod.outlook.com (2603:10b6:806:34b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.20; Fri, 15 Sep 2023 17:29:55 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.021; Fri, 15 Sep 2023 17:29:55 +0000 Message-ID: Date: Fri, 15 Sep 2023 18:29:48 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] examples/ptpclient: add the check for PTP capability Content-Language: en-US To: Huisong Li , dev@dpdk.org, Gagandeep Singh , Hemant Agrawal Cc: thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, liuyonglong@huawei.com References: <20220628133959.21381-1-liudongdong3@huawei.com> <20230817084226.55327-1-lihuisong@huawei.com> <20230817084226.55327-2-lihuisong@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230817084226.55327-2-lihuisong@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0336.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB8790:EE_ X-MS-Office365-Filtering-Correlation-Id: f46eec18-3e58-4db7-24f0-08dbb6116056 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hMqVzjjZXuDmnfRGJx6ZoB99usaNxB7izt+ADnGv6Td7k4PaOcovjOadR1Dv5b20lGTX5GxYmoQB35WN48kwP1Z3K2sUp1LSlV6QW7nY2fg6ZutrhWcUaO+g+DYLPIj9SII2Lto4NgjemZ/XH42wjw7vX16eOByAQGe8Tcnv6Uwc81Dd6OPB5sz4V/FujNZmvYyCvoLRyOs34gN697+jbzmuRCHcSzbHiP4B+Xc7gJBvcIEGcC1c0gf9KN3u9oTNl9P+HMbvPi4jwjKVi+S3V+PMS/ll+yQ96XawIMuNjZREeR010aZWuaoG/4+mXzHoxOFzS1IqGA756MEk6zSh1D4wOfq34jQt+ENGslcmZM4QsO/VShK8KEMRz0gzrSPVGkwf6FXl7DjRZlgbaDUrrfe0+p7G0YDcwYY1RGdnAtLyHnsimZBLjd81XjE8w9g+JPYW9q83gBnlvrHggPjDE4h+GRfxrAclUyIFx6wwGFaWdN4xxepldLC4MvUou7q+L9I/d7len4GJUiq3qVQt4aMRDuSNmXwKXYCcDKvYnut6LcGVwem+RuFBRMWiUywtvSIq0U/o8jnVeXsNEnAHkA7wt1kIraY6zxJPVkhUWSsVonEw8cdLceCop7Pdi7/ux75ASFkfI7hGCU9MhU366A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(366004)(136003)(376002)(396003)(346002)(186009)(451199024)(1800799009)(38100700002)(26005)(478600001)(53546011)(6666004)(36756003)(6512007)(6486002)(6506007)(66556008)(66946007)(110136005)(41300700001)(66476007)(316002)(31686004)(2616005)(5660300002)(44832011)(2906002)(4326008)(8676002)(8936002)(31696002)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blFNLytjYUk2K09lcWlBMUJuNm5xUldFcTFyWHhJNTRzdkhRRVJxUS9WeG9r?= =?utf-8?B?ZjB0VXFucGZGTUpkY1hMdTEvWjBMUWZrS28yMGYxeVdjaWdDOHB3eWcybUts?= =?utf-8?B?ZllPcEEyTS96RCtxbzdxZlNZRFNWMitvY0RVUVpoV2JZb1cwdTh4Q1JRZkF1?= =?utf-8?B?bDFhTWplS2htYkJEdmFDSmFrTjExTG82Y25JOHRadGxBdjRWcEs0M2FYZCtI?= =?utf-8?B?QUVFZkZWdHNySlViM1MwSnBqblhDRDM5Vjl0bTVMdHNUK3JGZ2tNemh0M1lm?= =?utf-8?B?UGVqcmFUWGZIVmN4cjliR2k3d0oyTTM2S0NuUWdCajV4WGZLVTRYVk44OXE3?= =?utf-8?B?SkdSMVpiTjZPMDJEaUloeEp6VjFJZUZIc1I4N1lBaDJhOXlNbHdHZ1hQT3Fj?= =?utf-8?B?cjdHc2ZjNnBtYVVzYXp2dVJ5ZnZ6empxL0FucFNTZlpwcTBPY1pFVHFYWVh0?= =?utf-8?B?Tmc3SkQ4TVF1YithV0dNZUdDSXhWVFJwdGQ2SnhpTmtzemovWXFSQVlNRXFZ?= =?utf-8?B?YXIvaXdBSHg0bXZSYlVLWUR1S2VnR2N0OXVKdjk1TFFyN0NGNFQ4azZTcit2?= =?utf-8?B?UnZuQWlWZCt1U3RiNUJ1RCtia2FScTFoTUc5cVoxT3RXZDMwTUt5RXpWRGNa?= =?utf-8?B?RENkTVJHOFdwTERkOWhaME5JdFBNZzhCdUhvZjFKUkZRQ2M4ZEI4QlA2Y20z?= =?utf-8?B?bm9MS0tLUE1KTi9nQWdNT1Q0RWxWZVd5M2JXdU9VSnkrZVFaUXA4Q1BSa01S?= =?utf-8?B?RjRvRUtYWXJDaW96dWRYbEhJcXE5NldqOHVQNWk2cXYxU0Y1YXdEbXVjcmI2?= =?utf-8?B?cjlqM0VGdWtBQzZsdGt2UzVXQUE0a2F2VXpFTEtKUDlMVzF5OEQwam4xSXIr?= =?utf-8?B?VXZScnc2MmU2RWhSbGpDZkhqOURrQ1ZjTDB5U3I1OWtLeTMwbm5FWWNIckly?= =?utf-8?B?cVlQVW5SVmRacEozSFB6eVovSGpkUmwvUzJNckNscnMwekpFOFpoYUNqTDRx?= =?utf-8?B?TCt5N3ZvSE4weE15RHFxRlh6ZFNzOFVqSU15Vm1JYkVFbGgyZDk3aUh4NG9T?= =?utf-8?B?WEVPT0ZXYmFmamwvdkNVK2tjZUIrdjNlK1JXRythWDBXSVcxdzJEVjZnUGVi?= =?utf-8?B?RzNyd2JRVnhWaDU2alJhb3NOUnZTZC96OGJ2K0RoL3dQSjhRTlB1UmR1eVk1?= =?utf-8?B?SHFkWTByZ2JlZDlrMnZwR2RyS2xQZGxNQi9RSVhWTlpVc2NlRHh0VTNDckVI?= =?utf-8?B?bmRnMUhxc1FkR3hoL2llUk9YK0loeVBJK1pQUm9PMDhBWEF6dVZ2NlByYzgw?= =?utf-8?B?aXZqa2kxK0ZlaDZjejZ4bmc2WHdOVnpydU9lMGthRXdJSXhnV1FEeFpVOFRj?= =?utf-8?B?MXlyQUNLTFExRk43aVBZZUVMeEVPRTdkTnVhOUIvM2dRWmJVQ2VBTkdzMzJ5?= =?utf-8?B?WG8rNWZQbnJoa1Bwa3FxSGJWRUl2Q2xOUW5DN2VWUzhtNVA3MGVkMnlMc1pF?= =?utf-8?B?WWg0cWZBUkVXU0JTY2FlYXVVbmQvZWJaeG5HN1N6blliTHEvcXpIb2VTT0ZK?= =?utf-8?B?dHdFK1Q2bTh4bFRaYmZhZnlaN2NVWU5yRzUyTE9KWit4T05RV2FaRldkUnoy?= =?utf-8?B?SVNVUXNwQ041UzVJNnBucXBEWUlDeXJvVG4rb20yRUtzbFBLZklpUHdWckZX?= =?utf-8?B?dENaK3d2TUg3NStmbEJNK09hSXdlak94dzArT2N2dHBHSzljR2trUUlIN0ZI?= =?utf-8?B?aGpUZWV0ZjJwTE8yRzlTYk5GZXZDSFNBSE5RT0FoNHVIVkU4TVV2aG0wREdD?= =?utf-8?B?K0NDTU5LZGxNSHFUbXpNeU53RUZ5Rk1GWmRYT2RGSlVBS2xrR2kvVmFRV2RJ?= =?utf-8?B?SjRQU1MrMzRvNllnK2dJM0xzMVpUUzlXdVpPQTE5ajI0ZldjSUhuM0ZMUStD?= =?utf-8?B?WXRuTmZvdWY2Y2VMdGR6Tng4eWNhVlZieWRKM3ZyU1h6aWxzSWV5V2hvYy9J?= =?utf-8?B?QWgzNXhXR2JCTHY3cjV2SjFCcjJHd1h4b1lHSmZxUmR1YzJta1NzSStLdlVP?= =?utf-8?B?Q0FJakdjcnNJVzRLOGFmWUpsRlNacGpkN3oyRGVuM055V1JBZEJFUHk5ZDh1?= =?utf-8?Q?97TyvqxZN7w8Lt7Allt0hgN8D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f46eec18-3e58-4db7-24f0-08dbb6116056 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 17:29:55.2749 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q1V296056I9EXKYcxnLy0FQypTgvKTCuxaXERQomNMSjxFNAp61HQvC90grn5xK2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8790 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/17/2023 9:42 AM, Huisong Li wrote: > If a port doesn't support PTP, there is no need to keep running > app. So this patch adds the check for PTP capability. > > Fixes: 7a04a4f67dca ("examples/ptpclient: enable Rx timestamp offload") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Dongdong Liu > --- > examples/ptpclient/ptpclient.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c > index cdf2da64df..181d8fb357 100644 > --- a/examples/ptpclient/ptpclient.c > +++ b/examples/ptpclient/ptpclient.c > @@ -196,6 +196,11 @@ port_init(uint16_t port, struct rte_mempool *mbuf_pool) > > if (dev_info.rx_offload_capa & RTE_ETH_RX_OFFLOAD_TIMESTAMP) > port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_TIMESTAMP; > + else { > + printf("port(%u) doesn't support PTP: %s\n", port, > + strerror(-retval)); > + return -ENOTSUP; > + } > I am not sure why TIMESTAMP offload is required for PTP, I think there is a confusion. Gagandeep, Hemant, Can you please clarify why TIMESTAMP offload is enabled?