From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10577A0C41; Thu, 7 Oct 2021 19:33:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96434411DB; Thu, 7 Oct 2021 19:32:59 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id B165741155 for ; Thu, 7 Oct 2021 19:32:58 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="226218922" X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="226218922" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 10:32:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="524750047" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP; 07 Oct 2021 10:32:57 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 7 Oct 2021 10:32:57 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 7 Oct 2021 10:32:56 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 7 Oct 2021 10:32:56 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 7 Oct 2021 10:32:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YTpYVVGNGwsrQJsYZpuYFQWMvmDfmwgOsjDy2XZ3xy9ePdw2yw1MA3Th35oG3cGXDgFr+08A4BZ7WLIvqG655tq3l2U9iFLxtfhE2waHVUgYrUCYFJllQbGRpPmfJ/797og21W2Umm5oVOE0tnzIGPBjyDsn4a3ocDLAoc1LfY85oF5N91kWNdOiLM+Q1GNQV5iXbwSmN+4sVgOBK0rqRxK5h9WUvYX5SzblEEiAhMlUa71nPqcXe8WmGMe0l7tYoeG0WeeIVS5Cxy4iriPlxlUe/uOt280QBHhTe8C3PEJjBeEsM52dYiaPN3+I+jK1mtmWmcH9NkLA3kUkCwHO1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ymb0d2gLfeaR73vNopOWXm79UrA/OeHEhzk9hogN2Yw=; b=YUJOR3ND9Zz3FctuOXOBhGI6HqtB6S67m3jdzHlfRkB3T+1I41IlSJMIaTTG/X/r4haVBk2oEK3MgIm+bKfLrYAJEJ2rAmbN4nvOif6lUypkbPrFfFEakbkQgU4LPRePX/9HB43mORpJIIGRe7wVe2UMFoei7SLjbofJ9n7gp8bWo4gTm7QKfSwtkwdm8+xH1wVgbRWzsGMp2Ff9SeYJLfZcKnk73YUe2MEmF3iHPgK4OAjzZyzYfvDJKNc1DgS8gMffjCkGfmfUBQ/9tMwNFwC7l+r4G7p5JoolxBgn+Rk2jaFOGUME9hy3dWYBIcfFrU4jJmFOTh/42YWz/hWkZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ymb0d2gLfeaR73vNopOWXm79UrA/OeHEhzk9hogN2Yw=; b=w9EA3joJmj3/F7CWDwJ3CDYMN0fenVh+6Pe+OEet1MgQ58IVvOZv7dbTzDZpq9Bby5Ol9BJkoJdUNPtfpGsd0DhJmfucB3ljLKVEERRuuvycPk7E5RGn7f/fmUseu2Te9WuCnvSCt4X3qLdIrWcFQ7xGstdIEa39w5bxpkdQ40Y= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 7 Oct 2021 17:32:55 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::cd8e:780f:5a1c:298a]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::cd8e:780f:5a1c:298a%8]) with mapi id 15.20.4587.019; Thu, 7 Oct 2021 17:32:55 +0000 Message-ID: Date: Thu, 7 Oct 2021 18:32:49 +0100 Content-Language: en-US To: Thomas Monjalon , CC: Andrew Rybchenko , Ori Kam References: <20210915210444.3126008-1-thomas@monjalon.net> <20211007154847.864237-1-thomas@monjalon.net> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211007154847.864237-1-thomas@monjalon.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0501CA0014.eurprd05.prod.outlook.com (2603:10a6:4:8f::24) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0501CA0014.eurprd05.prod.outlook.com (2603:10a6:4:8f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Thu, 7 Oct 2021 17:32:54 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f835c5cc-bd9e-4de6-e003-08d989b87f35 X-MS-TrafficTypeDiagnostic: SJ0PR11MB5005: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HGlApd8iDgMG+XnNClQ4GMd/yXz0xxWKL5NA9Xn0FY0zlbZRTkIyBXgxRkaj5iEf69240GEUb5W9f0eR/xc9hj7Ss6FUSZNJAXQN3qMRo9Yz8BmuT2LAHrXIrEFU+rR4NTaqH6/6nt2nnQpP6VgtCagAiZHMinkMWynB05QP2xIUnYqyiiFbebs0IFqnRqSsg4W581a90aBC1wj3ZYq+5OaD7EI3B7zDLOGeuAxEj/704776SEwdJFjqcz9uLqYjNbqMOyzO4RtT7SQuNV/jeKxEtCcHJLQrwujU/3vOpLkRvPKMwnIjHsHvXZzEN/FaRlRIG4pghI/LGhI0B9DhbaPTwdrvTXResOwmhFG/S2C/QZU4LTfW8+E+DAak004mRy/mBFUZPEjD4yjNv47MhnQBMIOun0YFzPSZX7SU7w+FtFgc1ObKn6iOJKMixxvbor+BxnuUQ+1BX1zvwexJtTMht8xgFlLZpzg7LlNzAyS940jO0MOV68u7+tNjjNC2021B94QcO4T+N4bC+caUIySretVoKMfM+C8pg3bP+g+4npPhtnP2ucy2AL/aJ0gGTbZ9VIFbL9hv4DEmzmN3+0BoXWC0Tcv0fFUMlSATCIhj7GLc97ZNRi1Tju1AwgAXv+F/qdDG7jrOh/UpGfb6uxTGTXlPPa5zMUb2L59CtRH4RgepT79nxKlJ5xBDO9d/woGqLtFWmck8gbDs8IFDHA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(4326008)(44832011)(2616005)(16576012)(4744005)(83380400001)(2906002)(38100700002)(8676002)(508600001)(36756003)(8936002)(66946007)(186003)(66556008)(66476007)(53546011)(5660300002)(6666004)(6486002)(86362001)(26005)(31686004)(54906003)(316002)(956004)(31696002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUlqTW82T05NZ1B6RjlrL1dzT0hJQkdkbHdJMlFMckFxY2NQQ1UwK0lCZlhj?= =?utf-8?B?YUNhZFZDYmJaZGtkZk14SlVoaVBpQ21uQUVjZDlsaU1lM0ptczM4eHhUSUZK?= =?utf-8?B?aGpBcUdDR1U2NVRXQ2NCejU2TWtJZ3VldXRLZHdYUTRZTXRCQVd2M3RqeXNx?= =?utf-8?B?V3RZb05OVms1Qm1PQW9weHhhMHZ3K2VzTUlNWEd3aVMxRE8zSDdDSXZacGlj?= =?utf-8?B?anhVd1VQQ3lkY0hXMGp4VERqVEUzb2V2ZmFicFhnUzR0OFNZNU5KMUhzekRn?= =?utf-8?B?TWduMHNZSWQzOG9Ha1poOXJ3TDdhbmdJamN2S3dvakRVdk5MTVVLbnI4eTVq?= =?utf-8?B?am5SMGlzbzNaS2Fhb3Boa2xPWElOTm14UExJMFJlQnZNUzdIZTN4UWJBTER1?= =?utf-8?B?NkZTS3VTR2J5NkI3UDF5WGZoUEYxZTJRWFA2c2d5TXh4S00wTVdYOUFnaXVl?= =?utf-8?B?Z0NZZWxTTVN4UXlKNHk5TXZ5TEowUnBvbGtUdHo1b2pRa0tneUVZd2EvQnFh?= =?utf-8?B?cjhtL2tKSG9NOEhIWWlGeUFrWDNHR2NDK1pxMGV0cTA0Y204VytzK3lqcU10?= =?utf-8?B?WitRYldRR2xkUW14TTVUY3Y3dWdNR085R3RTUTlZR0dBUXpqaE10WU55bEN6?= =?utf-8?B?dVpjdlpXaU1aK2VXaHE5VlB6RCtNTUM2bjZ4V2U0bGFwaUVHRTNuZm5kemhO?= =?utf-8?B?Y3Y5Qk1UU0pCU1dUNTlFL3c5TUdVQXFoOUl3Nnp4MHAvYnczNDdMeTVaWnhL?= =?utf-8?B?QXQrVHpjSkdCZHZEdTMzdnZrT0ZpeWZlRFAyUDlTMWZoUTFTSmdObTNQQmQ2?= =?utf-8?B?K2c4NXVtQytZWU4ydTZ5ZjBFeGJEbFNIWFhoNk1pWlI4UmdrcHRSbVhpYVA5?= =?utf-8?B?TUdJeEdISmdmNFdvYWJ2NHRPZndsTmw5SzFiWGExeHpwNmxpMjlWTTFsdTJX?= =?utf-8?B?V0Ewam1qM1o0eDQ5U3dJcE53eVQ3SVdoRkh1SUxkK2c2T2lkSWxKajlhZnVF?= =?utf-8?B?UFM2cGpWbnR6cWZVU2hTaS9oK0JGUjB4d1diZzdvRStsK1cxT1hOSUhaUHlh?= =?utf-8?B?ZFY2OHFsUGdsanNPbVA1WG85L3M4cENWTFpueFBFalBBaXhiNDFNc1dnRjQ2?= =?utf-8?B?TTAxRHlmTjAraENkNVpZbEFBcjdqR3o5ZHRJOGp6UklWWjQyT3RQYVJZUThO?= =?utf-8?B?MUlPYlYzL3U3TGxUL1ovMWFaNVB0T2hnZ1hNYktXTHlEU0h1SndUT0Vvb21K?= =?utf-8?B?dFlMOVkrSkZWTXBzNW5FdmhPcldSZXBCUUJZbzJsYmtVQXYrYW1WdWdPUGIz?= =?utf-8?B?QXd3RWhsa3pKbWRGTEZKZXZ5cHRBaVVjUXh5bXk1SkJlQjZqci8yODJnTkta?= =?utf-8?B?MkoxV0JYbk8yUit5bVNLVFNMMjNOQ2RIa0xuUDJ3Wlk2THUxbE5DY1g1Z1RU?= =?utf-8?B?eERlT29pbUJpUEdwQS9Ub0IrbGc1OG1tQW94TkZGKzNzRHovZWIyYzFEZmJD?= =?utf-8?B?VHl0OU5yUkMvekdjYmRYZUg3elhSZDMrMDNvUmtLYkpSdnhpVC9DTU5JcGZy?= =?utf-8?B?KzZOV3hMRkY5SXJMdnc2RW92TGtVMEJWMStRSnUvQnNHb2RFRjJ5UUFnOHN5?= =?utf-8?B?S1Z4Ym5BUWpudVRYaUNPNEY5UHlOY1BDZUp0MGg1ZUJlZVc0ODg0dXNiSVFK?= =?utf-8?B?SHdQWjNqTDUzQnRBbVJPUy9ENDJOUlVLZXFRWm13elNJZ2pqdEVwNFFCZDYz?= =?utf-8?Q?kGmEwK70/GU6M62+7Ig0dFtYh0q0LqUHiw/qQcX?= X-MS-Exchange-CrossTenant-Network-Message-Id: f835c5cc-bd9e-4de6-e003-08d989b87f35 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 17:32:55.3339 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8Lmd0+e9EfyKxI7Vwe5T6CSqz2XsRk9mBlUHjlboFmlV3yorufX9Kqw/X9fIDnPHhc6bNUy3XkV5Qp+nvRpQmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5005 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] ethdev: replace bit shifts with macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/7/2021 4:48 PM, Thomas Monjalon wrote: > The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. > The macro UINT64C is also used to replace remaining occurrences of ULL. > > The bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. > > The API of rte_mtr and rte_tm is using enums for 64-bit variables. > As they are enums, unsigned bit cannot be used. > > Signed-off-by: Thomas Monjalon > Reviewed-by: Andrew Rybchenko > --- > v2: use RTE_BIT32 in enums > v3: rebase on main > v4: keep enums untouched > --- > lib/ethdev/rte_ethdev.c | 16 ++--- > lib/ethdev/rte_ethdev.h | 129 ++++++++++++++++++++-------------------- > lib/ethdev/rte_flow.c | 4 +- > lib/ethdev/rte_flow.h | 6 +- > 4 files changed, 78 insertions(+), 77 deletions(-) > Is 'ETH_RSS_L4_CHKSUM' left unchanged intentionally? #define ETH_RSS_L4_CHKSUM (1ULL << 35)