From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8B3621B1F9 for ; Thu, 5 Oct 2017 23:33:43 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2017 14:33:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,482,1500966000"; d="scan'208";a="907182094" Received: from unknown (HELO [10.241.225.33]) ([10.241.225.33]) by FMSMGA003.fm.intel.com with ESMTP; 05 Oct 2017 14:33:40 -0700 From: Ferruh Yigit To: Pascal Mazon , Matan Azrad Cc: dev@dpdk.org References: <1507042556-9839-1-git-send-email-matan@mellanox.com> <551c25bb-5888-00d0-30a5-0d3a0964132d@intel.com> <28a38c08-efac-3a4f-24d8-028dd35749db@intel.com> Message-ID: Date: Thu, 5 Oct 2017 22:33:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <28a38c08-efac-3a4f-24d8-028dd35749db@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 21:33:43 -0000 On 10/4/2017 6:26 PM, Ferruh Yigit wrote: > On 10/4/2017 9:15 AM, Pascal Mazon wrote: >> Hi, >> >> I'm surprised there's only one place in the file with indent problem, >> but I'm ok with the patch otherwise. >> >> Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in >> patch 2/2, right? > > I wasn't sure about getting the patch that fixes only syntax in one place. > Good to have proper syntax but a commit for this looked like overkill to > me. So I was suggesting keep it as it is and fix syntax when that piece > of code updated later. > > But you are the maintainer of the driver, if you have strong opinion to > get it, sure I can. What has been fixed is still in next-net, so I can squash this. <...> >>>> Missed 4 spaces were added after break if line. >>>> >>>> Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands") >>> What do you think fixing this when that code has been touched next time? >>> >>>> Signed-off-by: Matan Azrad Squashed into relevant commit in next-net, thanks.