From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AD2EA00D7; Thu, 31 Oct 2019 18:11:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 255551D127; Thu, 31 Oct 2019 18:11:55 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 8F0BE1C2F1 for ; Thu, 31 Oct 2019 18:11:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2019 10:11:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,252,1569308400"; d="scan'208";a="375308736" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.9]) ([10.237.221.9]) by orsmga005.jf.intel.com with ESMTP; 31 Oct 2019 10:11:49 -0700 To: Ori Kam , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger Cc: dev@dpdk.org, stephen@networkplumber.org References: <1569479349-36962-1-git-send-email-orika@mellanox.com> <1572479604-178752-1-git-send-email-orika@mellanox.com> <1572479604-178752-9-git-send-email-orika@mellanox.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Thu, 31 Oct 2019 17:11:48 +0000 MIME-Version: 1.0 In-Reply-To: <1572479604-178752-9-git-send-email-orika@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v7 08/14] app/testpmd: add hairpin support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/30/2019 11:53 PM, Ori Kam wrote: > This commit introduce the hairpin queues to the testpmd. > the hairpin queue is configured using --hairpinq= > the hairpin queue adds n queue objects for both the total number > of TX queues and RX queues. > The connection between the queues are 1 to 1, first Rx hairpin queue > will be connected to the first Tx hairpin queue > > Signed-off-by: Ori Kam > Acked-by: Viacheslav Ovsiienko > --- > app/test-pmd/parameters.c | 28 ++++++++++++ > app/test-pmd/testpmd.c | 109 +++++++++++++++++++++++++++++++++++++++++++++- > app/test-pmd/testpmd.h | 3 ++ New parameter should be documented in 'doc/guides/testpmd_app_ug/run_app.rst', can you please describe befiefly how it works, what the mapping will like by default etc.. <...> > @@ -2028,6 +2076,11 @@ struct extmem_param { > queueid_t qi; > struct rte_port *port; > struct rte_ether_addr mac_addr; > + struct rte_eth_hairpin_conf hairpin_conf = { > + .peer_count = 1, > + }; > + int i; > + struct rte_eth_hairpin_cap cap; > > if (port_id_is_invalid(pid, ENABLED_WARN)) > return 0; > @@ -2060,9 +2113,16 @@ struct extmem_param { > configure_rxtx_dump_callbacks(0); > printf("Configuring Port %d (socket %u)\n", pi, > port->socket_id); > + if (nb_hairpinq > 0 && > + rte_eth_dev_hairpin_capability_get(pi, &cap)) { > + printf("Port %d doesn't support hairpin " > + "queues\n", pi); > + return -1; > + } > /* configure port */ > - diag = rte_eth_dev_configure(pi, nb_rxq, nb_txq, > - &(port->dev_conf)); > + diag = rte_eth_dev_configure(pi, nb_rxq + nb_hairpinq, > + nb_txq + nb_hairpinq, > + &(port->dev_conf)); > if (diag != 0) { > if (rte_atomic16_cmpset(&(port->port_status), > RTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0) > @@ -2155,6 +2215,51 @@ struct extmem_param { > port->need_reconfig_queues = 1; > return -1; > } > + /* setup hairpin queues */ > + i = 0; > + for (qi = nb_txq; qi < nb_hairpinq + nb_txq; qi++) { > + hairpin_conf.peers[0].port = pi; > + hairpin_conf.peers[0].queue = i + nb_rxq; > + diag = rte_eth_tx_hairpin_queue_setup > + (pi, qi, nb_txd, &hairpin_conf); > + i++; > + if (diag == 0) > + continue; > + > + /* Fail to setup rx queue, return */ > + if (rte_atomic16_cmpset(&(port->port_status), > + RTE_PORT_HANDLING, > + RTE_PORT_STOPPED) == 0) > + printf("Port %d can not be set back " > + "to stopped\n", pi); > + printf("Fail to configure port %d hairpin " > + "queues\n", pi); > + /* try to reconfigure queues next time */ > + port->need_reconfig_queues = 1; > + return -1; > + } > + i = 0; > + for (qi = nb_rxq; qi < nb_hairpinq + nb_rxq; qi++) { > + hairpin_conf.peers[0].port = pi; > + hairpin_conf.peers[0].queue = i + nb_txq; > + diag = rte_eth_rx_hairpin_queue_setup > + (pi, qi, nb_rxd, &hairpin_conf); > + i++; > + if (diag == 0) > + continue; > + > + /* Fail to setup rx queue, return */ > + if (rte_atomic16_cmpset(&(port->port_status), > + RTE_PORT_HANDLING, > + RTE_PORT_STOPPED) == 0) > + printf("Port %d can not be set back " > + "to stopped\n", pi); > + printf("Fail to configure port %d hairpin " > + "queues\n", pi); > + /* try to reconfigure queues next time */ > + port->need_reconfig_queues = 1; > + return -1; > + } 'start_port()' function is already huge, what do you think moving hairpin related setup into a specific function and call it when "nb_hairpinq > 0" only? This makes the hairpin related config more clear and 'start_port()' function simpler. I think all hairpin related operations can be extracted, like capability check, 'rte_eth_dev_configure' & hairpin queue setup.