From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C62BAA0547; Fri, 12 Mar 2021 11:02:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4149D160833; Fri, 12 Mar 2021 11:02:55 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 9E2394067E for ; Fri, 12 Mar 2021 11:02:53 +0100 (CET) IronPort-SDR: RvkEFbShS7++GhTXcARiH7bFLRY7k9+J5tz7ZrUdg7tiIbggS4k9u5PJnQ7lma6JC23LiqsijY WsJT/h9Nmcxg== X-IronPort-AV: E=McAfee;i="6000,8403,9920"; a="273855662" X-IronPort-AV: E=Sophos;i="5.81,243,1610438400"; d="scan'208";a="273855662" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 02:02:52 -0800 IronPort-SDR: slwtRBiW4potMXGamXz26/i36HpD8nOjFczMgwJJWLEclMipAz1a1YUiLeovwNVEL7BJmjR7oL fob0foXkAwKA== X-IronPort-AV: E=Sophos;i="5.81,243,1610438400"; d="scan'208";a="510288834" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.11.60]) ([10.252.11.60]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2021 02:02:51 -0800 To: "Min Hu (Connor)" , dev@dpdk.org References: <1615356985-24722-1-git-send-email-humin29@huawei.com> <1615356985-24722-5-git-send-email-humin29@huawei.com> <773749fe-6420-0729-6cf0-e8aea4c5095c@intel.com> <9b2df798-6f9b-018e-30bd-0bed86d336cd@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 12 Mar 2021 10:02:47 +0000 MIME-Version: 1.0 In-Reply-To: <9b2df798-6f9b-018e-30bd-0bed86d336cd@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 4/9] net/hns3: adjust the format of RAS related structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/12/2021 1:51 AM, Min Hu (Connor) wrote: > > > 在 2021/3/12 2:25, Ferruh Yigit 写道: >> On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: >>> From: Hongbo Zheng >>> >>> Adjust the format of hns3 RAS related structures to resolve >>> the static check warnings of reviewbot_c.This patch has no >>> impact on function. >>> >>> The correspond warnings of reviewbot_c: >>> When struct and union members are initialized, each member >>> is initialized on a separate line. >>> >>> Signed-off-by: Hongbo Zheng >>> Signed-off-by: Min Hu (Connor) >> >> <...> >> >>>   static const struct hns3_hw_error ppu_mpf_abnormal_int_st1[] = { >>> -    { .int_msk = 0xFFFFFFFF, >>> -      .msg = "rpu_rx_pkt_ecc_mbit_err", >>> -      .reset_level = HNS3_GLOBAL_RESET }, >>> -    { .int_msk = 0, >>> -      .msg = NULL, >>> -      .reset_level = HNS3_NONE_RESET} >>> +    { >>> +        .int_msk = 0xFFFFFFFF, >>> +        .msg = "rpu_rx_pkt_ecc_mbit_err", >>> +        .reset_level = HNS3_GLOBAL_RESET >>> +    }, { >>> +        .int_msk = 0, >>> +        .msg = NULL, >>> +        .reset_level = HNS3_NONE_RESET >>> +    } >>>   }; >> >> Hi Connor, >> >> This looks like just a syntax change, I wonder what is mentioned >> 'reviewbot_c' that generates a warning? > Hi, Ferruh, the description of 'reviewbot_c' may be misleading, > actually, it means "Huawei General Coding Specification". code from > Our company should follow that, thanks Got it, you can remove the reference it if it is not publicly accessible, otherwise it doesn't add any values and it may be confusing.