From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAD01A034F; Mon, 22 Mar 2021 10:12:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A974240040; Mon, 22 Mar 2021 10:12:17 +0100 (CET) Received: from dal2relay106.mxroute.com (dal2relay106.mxroute.com [64.40.26.106]) by mails.dpdk.org (Postfix) with ESMTP id 788304003D for ; Mon, 22 Mar 2021 10:12:16 +0100 (CET) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by dal2relay106.mxroute.com (ZoneMTA) with ESMTPSA id 1785934cac0000362f.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Mon, 22 Mar 2021 09:12:15 +0000 X-Zone-Loop: f872e86bd58bb1d08e65364c902ac7e1065a11256ee5 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NWquSF1ZlMnWuPgjXx+vfM0yMLm7dkJpaVuMQ9FYC+I=; b=mzop/35H3YdJnyYp6Z5tJ8xM9y NNDx4Ba2d1pwPq1b2QgNeeO1wrjfB/psfy+bZMDpH/T72YsK3pGJW5rVdiPslDBPlpdRDf9XOQGD6 J32r6OHlkPPMfihA48OQ25XweZJkc1BIzbfLsNu3Fk2m1gK/qoLU4QhndZAle4XIy840P+CIpPPz1 tItZ7ZOErrsrnjAv6cTVduXaVT1UDGhOxEGVCeusOVz44oUJvYIGcKBQydpzqlgZOcCM+8S1fhmvC QUtklQdJXjcfXCH1B7Vq92mkWn2Ua8UzKvoymZAKQV9A6SjwtYpTcjNeYC3jsGYnHOrRSvuy3ygU1 7GV6kFzQ==; To: pbhagavatula@marvell.com, jerinj@marvell.com, jay.jayatheerthan@intel.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com, timothy.mcdaniel@intel.com, hemant.agrawal@nxp.com, harry.van.haaren@intel.com, mattias.ronnblom@ericsson.com, liang.j.ma@intel.com, Neil Horman Cc: dev@dpdk.org References: <20210316200156.252-1-pbhagavatula@marvell.com> <20210319205718.1436-1-pbhagavatula@marvell.com> <20210319205718.1436-3-pbhagavatula@marvell.com> From: "Kinsella, Ray" Message-ID: Date: Mon, 22 Mar 2021 09:12:09 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210319205718.1436-3-pbhagavatula@marvell.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v4 2/8] eventdev: introduce event vector Rx capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 19/03/2021 20:57, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Introduce event ethernet Rx adapter event vector capability. > > If an event eth Rx adapter has the capability of > RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx queue > can be configured to enable event vectorization by passing the > flag RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR to > rte_event_eth_rx_adapter_queue_conf::rx_queue_flags while configuring > Rx adapter through rte_event_eth_rx_adapter_queue_add. > > The max vector size, vector timeout define the vector size and > mempool used for allocating vector event are configured through > rte_event_eth_rx_adapter_queue_add. The element size of the element > in the vector pool should be equal to > sizeof(struct rte_event_vector) + (vector_sz * sizeof(uintptr_t)) > > Application can use `rte_event_vector_pool_create` to create the > vector mempool used for > rte_event_eth_rx_adapter_queue_conf::vector_mp. > > The Rx adapter would be responsible for vectorizing the mbufs > based on the flow, the vector limits configured by the application > and add the vector event of mbufs to the event queue set via > rte_event_eth_rx_adapter_queue_conf::ev::queue_id. > It should also mark rte_event_vector::union_valid and fill > rte_event_vector::port, rte_event_vector::queue. > > Signed-off-by: Pavan Nikhilesh > --- > .../prog_guide/event_ethernet_rx_adapter.rst | 38 ++++++++ > .../rte_event_eth_rx_adapter.h | 95 +++++++++++++++++++ > lib/librte_eventdev/rte_eventdev.h | 30 +++++- > lib/librte_eventdev/version.map | 2 + > 4 files changed, 163 insertions(+), 2 deletions(-) > Seems strange that you add the forward declaration of the symbol, and you also detail the symbol in the map file, indicating how the symbol should be treated. But the patch is missing the symbol implementation itself, it should be here right?