From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D2244558A; Fri, 5 Jul 2024 00:46:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68E344027E; Fri, 5 Jul 2024 00:46:13 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2073.outbound.protection.outlook.com [40.107.223.73]) by mails.dpdk.org (Postfix) with ESMTP id A201440275 for ; Fri, 5 Jul 2024 00:46:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oTYaIA0DvGB3dqtJCPmkDmBecTRNMwLGWsb6Y0ACECg+FhER3Z0Uh11opuM7Q7thFvopcyrZMS6V6HtvsDZCIXQUregDJYIUnjGQtAPFu+TstBEax3SPX/XjvvpySugtdg8wnxOXURsZUZd2VJBbhOSBvaCK3LBYzmtxDdckOYgYxoV4BPAPuaOuTejyCYGVCODt/11paaBvLwiq3AlpVX06xIZydJgNm5EFXjIwquP4R9/KgMgdNjdwRrmd63l4kgUgqubEFGC5rnbSDy51nOxE3H6nI1x/UtD/jcVD8a3gi7buk27lUIlVPmczIDmVbRuZ5NPxga5hcAYaTSKugg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jlHuYViGHG1O/dDZqwtjVWkWmAwve+HgEScg3rXwhyA=; b=d0Y/vg1bV58r9/K169/j+tVhjAjPtvBG1MfZ8bv7GlBJ6p8btfIh/FSM8CHMDwT8EkNT/74tcIr0BkLtSEOwOx/s+y+iRDH+ijdojwpEf3ETchI4QAzr8nfasME3I5ssqljlbhKqWsdscSFRBUFX+dF5/OTCwp0aZa0OFla+aQOyXXu4zegw799Hzwc5kCCdNs0KCQ2djQKO/+2bNWoVhEQOfr/4vzpTGhSdA804Mu0enylFB33Pjt/GTcxD2mjv7DZazIukCvP1kmIKdHaaDYuFCV7XxrP+hV9CmRisE+ZJeGFxAn/1TfmMIqhFguCPQgduRL6CC/DhupBo0nXI0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jlHuYViGHG1O/dDZqwtjVWkWmAwve+HgEScg3rXwhyA=; b=cDBQl82Rtkjh6NaeYVMzPmV98wIwCopjSN+YBzbgcHcMRWXuPEFptdzFwInAOUVFJNCdLlWKTfQyOVc0beAY4vQWggezlYraTKCswzUtRdVyZYEhfAAeUucYlKsbmoMaUes7vVqPcnGjh6ictA6skv22O+d0jNAAXoPyFGHNYAk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB9101.namprd12.prod.outlook.com (2603:10b6:510:2f9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.33; Thu, 4 Jul 2024 22:46:08 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7741.017; Thu, 4 Jul 2024 22:46:08 +0000 Message-ID: Date: Thu, 4 Jul 2024 23:46:03 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 06/23] net/ntnic: add NT NIC driver dependencies To: Serhii Iliushyk , dev@dpdk.org Cc: mko-plv@napatech.com, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru References: <20240530144929.4127931-1-sil-plv@napatech.com> <20240627073918.2039719-1-sil-plv@napatech.com> <20240627073918.2039719-6-sil-plv@napatech.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240627073918.2039719-6-sil-plv@napatech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0023.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::35) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB9101:EE_ X-MS-Office365-Filtering-Correlation-Id: 94cabc51-d62a-4d82-a157-08dc9c7b1848 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UGNFSjhVUVBxWFpUekUySXkreUc5ZkNwQzJIa296NjVGWERJZ3FZT1RqbGdH?= =?utf-8?B?MEk4TXpjQ1V1QTRHa2pyVXpRcVExVW1xQ1d5UGw2aGM2ZHA1MHIwNDNkckI3?= =?utf-8?B?U0NHeDRFdnhQakdSSFpIa3pra0s5cjZmYnNoY2RvcmNLOFpSZjBxUnVyYmMw?= =?utf-8?B?S296dWFCb282RWZXOVNST3k2bGRHQlNKUXgyYVpRckpuYmhoR1ZwOERPdi9H?= =?utf-8?B?d3JXNmVHUURLWHV4TDdJc0Y5bGFkaGtqSks5S0VKQUVyb09ML1NsRndSRlpV?= =?utf-8?B?ak9NTHZSR3hJazRyb3NlRExwSUxJZlpqalNzOHBWbjErYTNCRTBBdm5TZHZ0?= =?utf-8?B?aU1ab3JuZzhwZ3JtYjB2cG9QM2hVSDdhZUt5VC9FMzRGcndZVmNkY09mWlhY?= =?utf-8?B?aUN1U0daK1pvUjhSNGNoV0FRMWpnRU1SV0FzbVlJQjU4bDRaZVhEbjhyV1Jy?= =?utf-8?B?ZDVhUko2WTUyaURsbnFxcmhzMkpMYmNibjk5MEN4QXY0bzcyT2ZXL2dlVlVj?= =?utf-8?B?TWZ2bUZxUzBIZ1NqNWNxemI1a3M5NTJRYnkwT1JBOFVVTkdiUWp4OHIxV2Fn?= =?utf-8?B?c0h6KzhuWUdOZ3VRbWVxU3JUc3B3enlhNXdIMWtPMFFDVjMweUY4TXRsWUhS?= =?utf-8?B?MnRZQUM3SlhTaWx3YzcyMXFscm9DYkVuOUV1ZWluNDN2SjRGNEVqT0Q1emdp?= =?utf-8?B?MTFpMW1wS1BzSVVNcVdzVW1ZVVFUYjRsR0F5SWhPTlhTZER5eDYrVkFodFNx?= =?utf-8?B?MmYrQXBVNzlXYm5HN2hHZkJpTDd6QWdlcjFBejhNYlUvaHFWT2lCVHlDV2pG?= =?utf-8?B?WmNqRFkyUTZEdW1DVDF6TUY4OUVjRjdlSGpHU3o5Z1NTS3Nud25oUGxPYXZG?= =?utf-8?B?MkhhbFp6QXdZcFNnVTB6Rm54V2ZwUkgzcVR2eHZmcFNFbmxiamUyRDZ1UDVF?= =?utf-8?B?WDYxV0Y1TnpqclZmenc0bG1aK2NrbnBGVU95dXVFRWNhdE92bUJ6bDVaT2cz?= =?utf-8?B?Y21tclNGaDlxUFBtQitMS2wvUndTZU91T3RCM0FSR3o1aStSNUVIdkM1VnRF?= =?utf-8?B?S2laaGN2bk96QlJTdHl0TFZLT0JXL2RtcTZIM1dMREgvTHRLeTVibElFSmVl?= =?utf-8?B?dE9GOWwwZ2dFYTIrYjBoTDFjYkZFSlNucmoxaVNnUDlGc1ZnUEhRa0xIWTMr?= =?utf-8?B?SmtWdVNsVVkybzJFd1k5blR4SFJibTMrcTRiTE4wQ3RrU0RyTHhOMWo0Rkkx?= =?utf-8?B?VnQ0ZGQvaXhLMHRpQzcvdnZ2ekJ2SDV4RmIrZjJQdmN2Mkt2aGJnY3ZKVzBY?= =?utf-8?B?SmZnbTV6clJFeWxjQ3JVOUc3NkJEOHo5YmpiZFpqbW5TdDVxWUZ6bjNHdW9t?= =?utf-8?B?NFVRems1S1krWU9YVHlMNTVMdk1wcTR3TEtscHhGa05YMTNDTWxhOGdNd05M?= =?utf-8?B?cmpGRFNZejZudWIweGV6Z2hZRmxUV2VlbFJEbUdJWnBvOWpwV09FOG5PWldu?= =?utf-8?B?dHRMd1Jjb2RzVnNWbjZXUmo1U3FsQnJhY0cwMjFaL2ZrY3pQdWdSbjVzc2Jl?= =?utf-8?B?YjIwZU04cldnRnFUbllYaXM5ZHdOSEEwYXZORWdFV2l3aHVMT2tsZzVkUXFj?= =?utf-8?B?QXo5dGpzSGtBbkhoaU4vaTdGd0RCWVJZSkRyQkx0T2hsQ3RqNU9RSlg5bExm?= =?utf-8?B?UlRjTk5aNlRpYXZMTVV1bWlRcFFGbUhSYWFDczdhbFN5UU9rRWhNQTQ0WStk?= =?utf-8?B?dERTUkw1MEpxa2doYkVJZVhNYXNqWlFSL3hZT2NzbVdIVkc4TDB6bUd2ckVE?= =?utf-8?B?UVpPNVRKTDBpbWlDVXJWUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWxIUCtBMXJKcXFmTkNrM0tUbnM5OWYvQnB3SVN0dGs4YVJ5TVoxK1ZlVUpM?= =?utf-8?B?ekkwY2dGTDRPbmRyWTU1Z05KVThEK05WcHBjRFpUTkRBZnpOODVCdmpqK1NX?= =?utf-8?B?bEM0ZE15Z29LaEVYaUp0NHZnYTRmVXExNWFIYjdUS1pIMG02SkR4QVBYSUVN?= =?utf-8?B?OVhhRzVGSHVFdVlpYlEvTi9RSldPbzMwek9UdzNsV29RTDdwSERGMUtxRnZa?= =?utf-8?B?VmhacndWRGtNTkN2UlNDdjBUUE5TUi9yWTBGTitMQ3JzVm1GMHJpUWpha2hH?= =?utf-8?B?OFBZUS8yN1JmNC9iUTlWYlRaSEFiQWQ5V1l0TWY1YVhab2R6ZUNVdHBoT3ll?= =?utf-8?B?Z1JDVGZodE9Eb1d5ZGdrNlVoVUlXTGFHck4yamlySjdJV3FaQWc5VTd0cHY4?= =?utf-8?B?VEdSclR3aUFvMnNLWnVzK1JpL2JzY0xJWHdnMHVXNDZTcTZkNmZGeXl3TVk3?= =?utf-8?B?N1Zka016bnFJVGNIUzNNenRNYVdHOTlZS2xYRGVGOGZFWlgxbWVlTS9DR25G?= =?utf-8?B?dk0zY2YybGw1SG0xWkhDSFRERFRTdzUrNmxwRUxXZWhyd0tSRXZDSlR1SXB0?= =?utf-8?B?K3M4OU1tZ3luZW5HNXdGNVQ2VmhOU1RHVjBmOHVQTkVYdEZLZ05rQjhyM2JE?= =?utf-8?B?QVJQSnZnSVJPT1JIWUtwUElScVVXeGRLS2JzNi9iVWdDWTBUcDJsbTBrR2Fp?= =?utf-8?B?YnhWZXhKWUV5cEpRa0dwVlZzMzJsNFdnUWs2KzZoaHNxQnZsMEZ2RDN6RThl?= =?utf-8?B?aFh3bDNSVXpKSnZoR055OHB6dG9OckpNcUpPZExsdHJka01BRmgrRUtVdUpT?= =?utf-8?B?Mm1WQit4UkFKaHA1czZCMzNMbVFDRE5oM3JnVGsvU3Jnd01ScWJVU2FNZDN3?= =?utf-8?B?S2greFRVWE5WK2ZiR3kvUUJkZ1JSQXRldTZicWppTFZVckJYWS95SERiKzNO?= =?utf-8?B?UTlxYWROZlZ3V1FhSEhaa1ptSlJaQkROeFM2c1YzT3VXcTRTVzNva0NlMXVY?= =?utf-8?B?NUtyWnFaLytSdktGdGdGN0ZJL0paM2N0ZjNyQk1od3NNY0lrWWIwSHZ2dGRh?= =?utf-8?B?NUVYa2pMS2dvTlRkdlh3T2I0MTNKNGNnb1UvYVJlRUZSN052azh3SmxpK0xx?= =?utf-8?B?VzlGOVA5S2JEWEVqS1F2SGwvUFRacW5LZFRKcXhLVURxVisyYmpkMitjOVVU?= =?utf-8?B?cnc0MjFjY21YYVFjVEJtMEwya0kwM05nUzR4ejNsZE9SV0ZaSkJMSk0wb0xR?= =?utf-8?B?d1Bubk9jSkFrRGRZSzR2eWRsalAwV2F5S1J3K2ZkY0VjNGJlVkttNHBvMTU3?= =?utf-8?B?aGtaSkpjcjRYQy80V0ZMU05neXRXZHExNnh6N2czWGpkMUNIczZKQzdwSUFQ?= =?utf-8?B?RS9WNWpqU1pUc3BSVzhROFBKdW9NZ2hjd013UllBdzB4V3RHemszM2R3a3Zx?= =?utf-8?B?TG90ZE9SL3lTNU1JbldvK3VrNHlMdEpQT0dGT2F5TzlkblpjbkR3ZzJCTW5k?= =?utf-8?B?azBra055Mk5CV0xaVTBiUXB0eGszb0M0ZC9Ba2FFY0R1QjlSbGNJREFOZTZ3?= =?utf-8?B?amEvWUp6QkJiSEtJYnNsUXM4SHYzdmZ4b1hIcUdXZzhqNVdyOFBGd1UwQU9J?= =?utf-8?B?ajJYaVpWY2xUZFN5elR3K3BwanJNdlJRMG1ObVhrTUgxT2hnemZhRisyMldB?= =?utf-8?B?dWlPZGlHTndYVEhqQ2pGTVY2NUNIcHNHUlRMeVdlUVRURkdodFo5cWFMdjVs?= =?utf-8?B?b1ZtcTZrOXlBZmsyVHQxeHhjM2ZSeXJqdllXVTl3ZG9JUkhqZ1VVVS9XT3Qr?= =?utf-8?B?TnlGTzEzd3FGM2RLWGNqRHppRWNFSG1oaVN3UlFzREhGWnhSWlNLQlAvUnJo?= =?utf-8?B?MzlZVmc2Q3VXLzV1RUlVazB2V0VHTWpFY1hCVEFENmlaNHVqWjNQcncxMFRN?= =?utf-8?B?ZW9pSjNzY3dBbnpZOGpJa2tkdjVrc1JGNjg4MEd4eG9SWEtncE1VN05hSDlE?= =?utf-8?B?dnM4NGw0NXI5ZjR1UitCdmsyMDlDcGl3Ulp2NFZURVZxaTBqT1RXOHpnT1Qr?= =?utf-8?B?NzVGbXlEUWZuY3JVVldpWFI2NFFjaTFKKytUSkZCR3JZZS9KL0dlUGxDRWpp?= =?utf-8?Q?nHDMgpUGObjgC5V8L6mMmpTIZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94cabc51-d62a-4d82-a157-08dc9c7b1848 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2024 22:46:08.3707 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WyVO4vg5yEQZtkfDFt3ygQj9ARUn630ZL4lU/By1dve2Ne+0HNZjNUu/hKSjzNM1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9101 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/27/2024 8:38 AM, Serhii Iliushyk wrote: > Add structures and interfaces specific for NT smartNiC > The commit log is not really descriptive, I can see patch improves driver with struct eth_dev_ops. And patch adds global 'struct drv_s' structure, I assume, as one pci device can have multiple ethdev, this struct is common state for all these ethdevs. But can you please describe it more. And it is better if you can escape from a global variable state, and keep state per device specific data if possible, and if make sense for your specific usecase. Also can you please describe what are the driver dependencies mentioned in the patch title? <...> > +static int > +eth_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *dev_info) > +{ > + struct pmd_internals *internals = (struct pmd_internals *)eth_dev->data->dev_private; > + > + dev_info->if_index = internals->if_index; > if_index is used wrong, I commented same before. As a physical driver, you can ignore if_index, it is used for virtual drivers that has backed by linux interface. > + dev_info->driver_name = internals->name; > + > + return 0; > +} > + > +static int > +eth_dev_configure(struct rte_eth_dev *eth_dev) > +{ > + struct pmd_internals *internals = (struct pmd_internals *)eth_dev->data->dev_private; > + struct drv_s *p_drv = internals->p_drv; > + > + NT_LOG_DBGX(DEBUG, NTNIC, "Called for eth_dev %p\n", eth_dev); > + > + p_drv->probe_finished = 1; > Why setting 'p_drv->probe_finished' in 'eth_dev_configure()'? And won't multiple ethdev can share same 'p_drv', if so why updating it per ethdev? > + > + /* The device is ALWAYS running promiscuous mode. */ > + eth_dev->data->promiscuous ^= ~eth_dev->data->promiscuous; > + return 0; > +} > + > +static int > +eth_dev_start(struct rte_eth_dev *eth_dev) > +{ > + struct pmd_internals *internals = (struct pmd_internals *)eth_dev->data->dev_private; > + > + NT_LOG_DBGX(DEBUG, NTNIC, "Port %u, %u\n", internals->n_intf_no, internals->if_index); > + > + return 0; > +} > + > +static int > +eth_dev_stop(struct rte_eth_dev *eth_dev) > +{ > + struct pmd_internals *internals = (struct pmd_internals *)eth_dev->data->dev_private; > + > + NT_LOG_DBGX(DEBUG, NTNIC, "Port %u, %u\n", > + internals->n_intf_no, internals->if_index); > + > + eth_dev->data->dev_link.link_status = RTE_ETH_LINK_DOWN; > + return 0; > +} > + > +static void > +drv_deinit(struct drv_s *p_drv) > +{ > + if (p_drv == NULL) > + return; > + /* > + * Mark the global pdrv for cleared. Used by some threads to terminate. > + * 1 second to give the threads a chance to see the termonation. > typo termonation. > + */ > + clear_pdrv(p_drv); > + nt_os_wait_usec(1000000); > + > + /* clean memory */ > + rte_free(p_drv); > + p_drv = NULL; > Clearing local variable? > +} > + > +static int > +eth_dev_close(struct rte_eth_dev *eth_dev) > +{ > + struct pmd_internals *internals = (struct pmd_internals *)eth_dev->data->dev_private; > + struct drv_s *p_drv = internals->p_drv; > + > + internals->p_drv = NULL; > + > + rte_free(internals); > + internals = NULL; > + eth_dev->data->dev_private = NULL; > + eth_dev->data->mac_addrs = NULL; > + > + rte_eth_dev_release_port(eth_dev); > 'rte_eth_dev_release_port()' clears dev_private and mac_addrs, and more. It is common to close() free driver specific resources, and remove() does call close() and 'rte_eth_dev_release_port()' later to free common resources. > + > + /* decrease initialized ethernet devices */ > + p_drv->n_eth_dev_init_count--; > + > + /* > + * rte_pci_dev has no private member for p_drv > + * wait until all rte_eth_dev's are closed - then close adapters via p_drv > + */ > + if (!p_drv->n_eth_dev_init_count && p_drv) > + drv_deinit(p_drv); > + > + return 0; > +} > + > +static struct eth_dev_ops nthw_eth_dev_ops = { > + .dev_configure = eth_dev_configure, > + .dev_start = eth_dev_start, > + .dev_stop = eth_dev_stop, > + .dev_close = eth_dev_close, > + .dev_infos_get = eth_dev_infos_get, > +}; > > static int > nthw_pci_dev_init(struct rte_pci_device *pci_dev) > { > nt_vfio_init(); > > + struct drv_s *p_drv; > + ntdrv_4ga_t *p_nt_drv; > uint32_t n_port_mask = -1; /* All ports enabled by default */ > + uint32_t nb_rx_queues = 1; > + uint32_t nb_tx_queues = 1; > int n_phy_ports; > NT_LOG_DBGX(DEBUG, NTNIC, "Dev %s PF #%i Init : %02x:%02x:%i\n", pci_dev->name, > pci_dev->addr.function, pci_dev->addr.bus, pci_dev->addr.devid, > pci_dev->addr.function); > > > + /* alloc */ > + p_drv = rte_zmalloc_socket(pci_dev->name, sizeof(struct drv_s), RTE_CACHE_LINE_SIZE, > + pci_dev->device.numa_node); > + > + if (!p_drv) { > + NT_LOG_DBGX(ERR, NTNIC, "%s: error %d\n", > + (pci_dev->name[0] ? pci_dev->name : "NA"), -1); > + return -1; > + } > + > /* Setup VFIO context */ > int vfio = nt_vfio_setup(pci_dev); > > if (vfio < 0) { > NT_LOG_DBGX(ERR, TNIC, "%s: vfio_setup error %d\n", > (pci_dev->name[0] ? pci_dev->name : "NA"), -1); > + rte_free(p_drv); > return -1; > } > > + /* context */ > + p_nt_drv = &p_drv->ntdrv; > + > + p_drv->p_dev = pci_dev; > + > + /* Set context for NtDrv */ > + p_nt_drv->pciident = BDF_TO_PCIIDENT(pci_dev->addr.domain, pci_dev->addr.bus, > + pci_dev->addr.devid, pci_dev->addr.function); > + > + > + p_nt_drv->b_shutdown = false; > + > + /* store context */ > + store_pdrv(p_drv); > + > n_phy_ports = 0; > > for (int n_intf_no = 0; n_intf_no < n_phy_ports; n_intf_no++) { > + struct pmd_internals *internals = NULL; > struct rte_eth_dev *eth_dev = NULL; > char name[32]; > > @@ -50,6 +253,33 @@ nthw_pci_dev_init(struct rte_pci_device *pci_dev) > > snprintf(name, sizeof(name), "ntnic%d", n_intf_no); > > + internals = rte_zmalloc_socket(name, sizeof(struct pmd_internals), > + RTE_CACHE_LINE_SIZE, pci_dev->device.numa_node); > + > + if (!internals) { > + NT_LOG_DBGX(ERR, NTNIC, "%s: %s: error=%d\n", > + (pci_dev->name[0] ? pci_dev->name : "NA"), name, -1); > + return -1; > + } > + > + internals->pci_dev = pci_dev; > + internals->n_intf_no = n_intf_no; > + internals->if_index = n_intf_no; > + > + > + /* Setup queue_ids */ > + if (nb_rx_queues > 1) { > + NT_LOG(DBG, NTNIC, > + "(%i) NTNIC configured with Rx multi queues. %i queues\n", > + 0 /*port*/, nb_rx_queues); > + } > + > + if (nb_tx_queues > 1) { > + NT_LOG(DBG, NTNIC, > + "(%i) NTNIC configured with Tx multi queues. %i queues\n", > + 0 /*port*/, nb_tx_queues); > + } > + > eth_dev = rte_eth_dev_allocate(name); /* TODO: name */ > > if (!eth_dev) { > @@ -61,6 +291,11 @@ nthw_pci_dev_init(struct rte_pci_device *pci_dev) > NT_LOG_DBGX(DEBUG, NTNIC, "eth_dev %p, port_id %u, if_index %u\n", > eth_dev, eth_dev->data->port_id, n_intf_no); > > + /* connect structs */ > + internals->p_drv = p_drv; > + eth_dev->data->dev_private = internals; > + > + internals->port_id = eth_dev->data->port_id; > > struct rte_eth_link pmd_link; > pmd_link.link_speed = RTE_ETH_SPEED_NUM_NONE; > @@ -71,7 +306,7 @@ nthw_pci_dev_init(struct rte_pci_device *pci_dev) > eth_dev->device = &pci_dev->device; > eth_dev->data->dev_link = pmd_link; > eth_dev->data->numa_node = pci_dev->device.numa_node; > - eth_dev->dev_ops = NULL; > + eth_dev->dev_ops = &nthw_eth_dev_ops; > eth_dev->state = RTE_ETH_DEV_ATTACHED; > > rte_eth_copy_pci_info(eth_dev, pci_dev); > @@ -79,8 +314,11 @@ nthw_pci_dev_init(struct rte_pci_device *pci_dev) > eth_dev_pci_specific_init(eth_dev, pci_dev); > > /* increase initialized ethernet devices - PF */ > + p_drv->n_eth_dev_init_count++; > } > > + p_drv->setup_finished = 1; > + > return 0; > } > > @@ -156,6 +394,9 @@ nthw_pci_remove(struct rte_pci_device *pci_dev) > { > NT_LOG_DBGX(DEBUG, NTNIC); > > + struct drv_s *p_drv = get_pdrv_from_pci(pci_dev->addr); > + drv_deinit(p_drv); > + > You are not really removing the ethdevs, which should be done at this stage. As one pci device has multiple ethdevs, need to figure them out in this stage. Normally it is possible to get ethdev via "rte_eth_dev_allocated(pci_dev->device.name)", but for your case this is not possible. octeontx (octeontx_ethdev.c) has similar usage, please check it. It does iterates on names, for you this is "ntnic%d", and frees the valid ones. <...>