From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 05D9F1B1AB for ; Sat, 7 Oct 2017 01:26:31 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Oct 2017 16:26:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,486,1500966000"; d="scan'208";a="159817842" Received: from unknown (HELO [10.241.225.2]) ([10.241.225.2]) by fmsmga005.fm.intel.com with ESMTP; 06 Oct 2017 16:26:22 -0700 From: Ferruh Yigit To: "Yao, Lei A" , "Hu, Jiayu" , "dev@dpdk.org" Cc: "Tan, Jianfeng" , "Ananyev, Konstantin" , "thomas@monjalon.net" , "Wu, Jingjing" References: <1504420216-3258-1-git-send-email-jiayu.hu@intel.com> <1506407202-29843-1-git-send-email-jiayu.hu@intel.com> <2DBBFF226F7CF64BAFCA79B681719D953A2965D1@shsmsx102.ccr.corp.intel.com> Message-ID: Date: Sat, 7 Oct 2017 00:26:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: enable the heavyweight mode TCP/IPv4 GRO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 23:26:32 -0000 On 10/7/2017 12:04 AM, Ferruh Yigit wrote: > On 9/27/2017 8:23 AM, Yao, Lei A wrote: > <...> > >>> The GRO library provides two modes to reassemble packets. Currently, the >>> csum forwarding engine has supported to use the lightweight mode to >>> reassemble TCP/IPv4 packets. This patch introduces the heavyweight mode >>> for TCP/IPv4 GRO in the csum forwarding engine. >>> >>> With the command "set port gro on|off", users can enable >>> TCP/IPv4 GRO for a given port. With the command "set gro flush ", >>> users can determine when the GROed TCP/IPv4 packets are flushed from >>> reassembly tables. With the command "show port gro", users can >>> display GRO configuration. >>> >>> The GRO library doesn't re-calculate checksums for merged packets. If >>> users want the merged packets to have correct IP and TCP checksums, >>> please select HW IP checksum calculation and HW TCP checksum calculation >>> for the port which the merged packets are transmitted to. >>> >>> Signed-off-by: Jiayu Hu >>> Reviewed-by: Ferruh Yigit > >> Tested-by: Yao Lei > > Applied to dpdk-next-net/master, thanks. nope, removing it out back. There are "uint8_t port_id" usage a few places, now port_id is uint16_t, this is new in the repo. For testpmd you can prefer "portid_t" storage type as well. Can you please send a new version?