From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53192A0C55; Fri, 5 Nov 2021 17:24:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C623740E5A; Fri, 5 Nov 2021 17:24:38 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 26B2540689 for ; Fri, 5 Nov 2021 17:24:36 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10159"; a="232185411" X-IronPort-AV: E=Sophos;i="5.87,212,1631602800"; d="scan'208";a="232185411" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2021 09:24:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,212,1631602800"; d="scan'208";a="542857190" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 05 Nov 2021 09:24:36 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 5 Nov 2021 09:24:35 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 5 Nov 2021 09:24:35 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 5 Nov 2021 09:24:35 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 5 Nov 2021 09:24:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQtLUdgeqAnY9GEGRxf7teT/9Xq+v5AIkxmiizx4kcmneWOf8gOsV+eNWVQZ9W9FEoH8clE9FLbFLyaNsHB50ytsjRfzyPBkaHhC0VJjxk8WYNEtRZXp3RzP78MNIRNsw3W6u3xX2HguKhdw5oQ4RtckYWth5ptVV1UREFSIhiwctmj8kF9gr1X5kuSlro/fbRQCqxKyhowz+IjHFuDPqiJV3yYjfl5JEmbqD9fX68gPwWHRsIxuVR49MBtDtP94H9T4R3mGjZeiDjClpDyTtdNHMl7rHgXJN8GGtjeBz70I13jExSoUcYnA+mlvitGTMOvEWh8g4HVWn3cnu7B9Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dZ1oNvqbBzFsh8cXitelurOSQSaCDCpI5nGpuXyzSfE=; b=TEzktgZgO3XvIfZplzbehHvuIPGlEoLL0pcw/fxNO1uAYvPNd/oEACiEGATJF4XNO9g8rnun8cT9iOC10zMnsd+gvWdNQGLeM80x4X0N1NUqCSabkuO9oW6jHoIhXXVJCnQMQcpYwHg3ASwFqvXzEXDfBN+yr/PHs67tzKeYXlu3piBK5g2oq6JyL7ulZwdINKlCrTjmaJUUzZSe73sSeZaFrwvLVl0MaHN18f3irq0T320WrDLkmpfQ0CSdOhdBggENE/aUH0Kj7dfZc70dkcJu/87Uu8D/SR6eX1FDUZlsXkGpogkvW13cPE/Yf/1Q6JvZCtD5wVhR3be/oJwfLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dZ1oNvqbBzFsh8cXitelurOSQSaCDCpI5nGpuXyzSfE=; b=aSDw1ghIySclrNAkT9l3xhS3hJAaGuAoWNDGSqTSCEa7h3zDidAhxTzcaz+VRcKfba1HfSYHwAwqZ6n1WIPkzBzPmP2wZEnO29NGc47btqIrbgiT6GfRZJXp8A+tlGjq1ch575+NrbfNN1X2xVnrg0MaOsgorYrt41cwsC44Iw4= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5189.namprd11.prod.outlook.com (2603:10b6:510:3d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Fri, 5 Nov 2021 16:24:33 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%7]) with mapi id 15.20.4669.011; Fri, 5 Nov 2021 16:24:33 +0000 Message-ID: Date: Fri, 5 Nov 2021 16:24:26 +0000 Content-Language: en-US To: Jie Wang , CC: , , , , References: <20211103030705.211093-1-jie1x.wang@intel.com> <20211104092947.244962-1-jie1x.wang@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211104092947.244962-1-jie1x.wang@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0177.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO2P265CA0177.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Fri, 5 Nov 2021 16:24:30 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fac903f4-7106-4445-495e-08d9a078bfd4 X-MS-TrafficTypeDiagnostic: PH0PR11MB5189: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rmHC9hiCe5nIbbTP6H+BbspheMgW5cm5qwXOiTTVV9Nd3r4MNe4tZHY2a4PXDiv38x0p0ouBdGoo/9nsofMBc2HT9YP8Gy6n/RrruIwqVCgIiMoBIAz/3GbyTWsrgm2VYui8yvvb5rmVUBIMZg8GRypSHUVYcq31nPkTFRuS5kMW+HGVbbKcx8CEJxxv2lyrZVFg7qY6GX4ZVl9Vyfd+JflWsYOtzMfcjGqq6NYbU6sEDITFiUv9bR3bqDJUvCPbs3VUf0uS3PF//VbJY2C79QDy16KLfGR+xoDzhflZFYHE28fYWSOnX4+Eto9JIydG+OOL6faexCjha/XMMOr/7gJcj9RxTzbeiZQ4l7yN5VHiqI2RPXOK23PtGNYqUuqrfZ0K/ff26heA076NNgQtANTDf/9dG5e49/JKplhCEquov9FmYvKa8LUox9xtxqLqelSsB8QyvYjPTCagaKiiKuCnsidAdTJHUdEztlkCWgdpp5U6bCR8AnaWkoWO3Z32CuwsO7cnuk0vdCoN++4meZsPgPK04pJE/neo0WzhHMRrEYfOwvSu8Oe0PPaDeAgiWz3sROvvZV2rUc6sf5V1VUi5sO/jFYhBU8eWlchWMErYaCCj2+lLG8KQ6AqFc2DEtP/vTxysrqCU4pIbaoovfPHl+GZ7IiEwC90xVnsME8Az0K2ltA0ciqlv3Ep5HSLTm++MDryvlqbjTTDlBRSeXw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(36756003)(38100700002)(31686004)(66946007)(83380400001)(6486002)(82960400001)(66476007)(66556008)(508600001)(86362001)(107886003)(2906002)(5660300002)(6666004)(8676002)(4326008)(44832011)(2616005)(26005)(31696002)(16576012)(8936002)(956004)(53546011)(316002)(186003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHFQVEpBQ3oyck44L2ZOdzExMitaaUhkS1JsZ3FpaEs1bE44bDhaZ3ptb0pV?= =?utf-8?B?enZHSDlZNmxDSVBXYlh6V2lBL1YvaG1LYm9rTnZsaTV4WW55bCtscUNEQURE?= =?utf-8?B?L3h3SUVSakU5NGVvZ1FFbWREMVV4ektYQnlFWVJnaDVhMklKdEVZbmdPWkw2?= =?utf-8?B?RGtJeHNOS3hmSk9ZUmFpbUlUVnlsSnMxVFVSVjFpdnZHRG0rd0YzYTR6WHF5?= =?utf-8?B?VlhDckxkcVFwd1hJMSt6dENORUQ3UjdZd3pnZVZNWTNXQy91SHlZdzl0VlRq?= =?utf-8?B?ckdiKzNpV1BDckt3MDlBRHNJTW56RnM0N21kNERabnRTVUdWU1FRY3FZOUtX?= =?utf-8?B?OURMQmtRZSt2Ylh1RHROWlFLd1lNdnVQcy90K3NBS3hxbTBlRnZZTVpCaXBK?= =?utf-8?B?d29NVmxtUWJ5MjlDcHlFNUw5eUVUSVAzbkx1aXJwTVB6ZVArdnpvRVVCS2xF?= =?utf-8?B?QmZPNXpIRUIxaHZMWkk3cUVZVzZwa1ZWVGl5Z21tdjFWN0Uvb3pCZGxBcis2?= =?utf-8?B?ZjJSNXlqRXNMZm9JRXUvQXM3Q2hJSm9jRzZ2WENVeTVXVnYxaEV4N2ZQUzg0?= =?utf-8?B?MUtNQlRnUExBTWVqaHhHMXlXZVd3QXVQZ0ZRY2tDVXU1MkZuMkpGM05ZUzIr?= =?utf-8?B?ZE9MdEVaSFBueFZMdHd6am1oeTd5ZlRuRTc0alFaMHhsT1RmbXhYd0QvNXh5?= =?utf-8?B?QUlWNUJUbGZ4OENXYzhSVDVIZS9NaGVyUHZQMHNLRlo5S09wblhNU2Nha2RW?= =?utf-8?B?TUhvUFhsdXBkbGZkN3VSenVTVVhrdTh4NDJ3S2tqZ3JJVUhaSzBJbWJodEc2?= =?utf-8?B?TmkyQWoyT0EvVmhiRTJwcnhIZkpEbmFmUkhiNlJCSVZjM1A1ZjE5UzNKV21n?= =?utf-8?B?cmJzVURJdFVKUWIwWURTYktld3dRYmI5dHBBQlZjaXFrNFJIZURRbFBQQ3Q0?= =?utf-8?B?RExxN0VQR21reFdvSnNKZ09XU3BVaUdiT2JzRzRVNlpCRGFMQXY1YWVKcC81?= =?utf-8?B?VjRsSTg3QVZxNmlLNDY1ZDgxK0hTTHJyM1pqSnc4UGtHOVUxSTNIajQ3SE02?= =?utf-8?B?NlJTZlJyZTZGNnRkekRNck5HampDN2x3YktFTUJpdDB2bXZ3MU5lOW8yeFMr?= =?utf-8?B?bHpDL1M3QUszc3VUQ29iQkw1RjB4ZFBkVG1BSGsvbkpBQkVjT1NmYVcrODZJ?= =?utf-8?B?cnhYelZGQkh3WXVzYU5JOEhST3BwS1NMdmRrZ3VlSUdWd2MwRkY0ZEI1eU9m?= =?utf-8?B?TFE0U2Rxd3gxcjRuTVhYQUtuZHhmdUJJM0R2WEd0aWIzTjQ1d0lTREw0aEN5?= =?utf-8?B?dGx1cEsxUE9wMnE0eG5WMUsxTTJZd1MvbWpQWGRQNmZDakN2ZTVkZlZBWmdq?= =?utf-8?B?ZklXMVFuelNiYzRvZTNZdDFmWmo2MEJ2d2NCYXp1cHlWaXVGU3pKSWdBWk1t?= =?utf-8?B?aHMrNHJkdEp4MURrc1FCSG9uOThKZGlYS1pJU2N5ekpUMzNmUElIWnM4dU1R?= =?utf-8?B?TkNUZTk1TTF4eElHN0t4STlBQWlDeDNXTUFQT3RRdnowS0xJekc2eUUyL2tq?= =?utf-8?B?U3JOQXIxOUlkSXhPeG1FRVhkVG5uNjFMeEp6VHhESlpoaHd3NW4xcnVlRDNm?= =?utf-8?B?ck04SGhWeUJNL1h3YUNkaHppV28yZFMwT0tmSEJqWUlSZmJ5NlVYb1JkOUYx?= =?utf-8?B?MUJXam1lMW8vLzBRK0l5c1BTZjU4NW54ckY3YXVZZnVNaEFxZ0VoOUF1Z1NF?= =?utf-8?B?MmpnRjdGUnJwY1VmNEdmZURDT3p6QUhXWlJHdDVCZ2owd1lQOWc4TmgxVi9M?= =?utf-8?B?RkRtVFVWYVZFUUVzRkdKSEVNTWNZRm1UUFZPUTV4S3YzVWhqT0dseFZiTnhI?= =?utf-8?B?UkRiVWRDejZkUEcwTGs2VE5YVDNUMHo3MDV1d0loZmVhMmlHSWw2d3VJc0Zo?= =?utf-8?B?U0xqNmxvb3pzN00wVi8yQzFaU043eUVLSFYwMXpTOXdaUzI3MEo0RXdrY0pR?= =?utf-8?B?VEY4MFJOVklpTk1obTRwQi8zcHA0SjZ3R294S2tYTlJ2elJSSG9wOGhOWHZO?= =?utf-8?B?NDFGQUptQWlZdU85VDNscjMxRXl6QStmbnVGK1JzT01nOHJna3pUZkFOZkZU?= =?utf-8?B?UXBSV1dVODFYTldwQ0UwMWN0bWhZNGQ0aXV1eVl3NHprNW56ZVFrZXNXL29M?= =?utf-8?Q?S7NDMft2aCov+70el+iFqhA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: fac903f4-7106-4445-495e-08d9a078bfd4 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 16:24:32.8010 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0wQOzUTx8njCUFoiG2zp901IMOBCrRrDhpeQGdWM1dfcgAat8R01UsjBKFgm99HTkRITAcHCXTMGlM85YsVhWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5189 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix set Rx offloads RSS hash off X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/4/2021 9:29 AM, Jie Wang wrote: > When we set Rx offloads RSS hash off in cmdline, then we start > port, if dev->data->dev_conf.rxmode.mq_mode RSS enable(multiple > queues mode), it will load RSS hash in driver and sync to port. > > After setting Rx offloads RSS hash off, this patch removes > RTE_ETH_MQ_RX_RSS in port->dev_conf.rxmode.mq_mode to fix this issue. > > And after setting Rx offloads RSS hash on, this patch also adds > RTE_ETH_MQ_RX_RSS in port->dev_conf.rxmode.mq_mode. > > Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") > > Signed-off-by: Jie Wang > --- > app/test-pmd/cmdline.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index d08a1c9777..f8277e4443 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -16176,10 +16176,16 @@ cmd_config_per_port_rx_offload_parsed(void *parsed_result, > port->dev_conf.rxmode.offloads |= single_offload; > for (q = 0; q < nb_rx_queues; q++) > port->rx_conf[q].offloads |= single_offload; > + > + if (single_offload & 0x80000) I don't why you used immediate value, but you mean 'RTE_ETH_RX_OFFLOAD_RSS_HASH' here. > + port->dev_conf.rxmode.mq_mode |= RTE_ETH_MQ_RX_RSS; Why enabling RSS when 'RSS HASH' offload is enabled? In this case if RSS is disabled I think it should fail. Can you please describe again what problem you are solving? > } else { > port->dev_conf.rxmode.offloads &= ~single_offload; > for (q = 0; q < nb_rx_queues; q++) > port->rx_conf[q].offloads &= ~single_offload; > + > + if (single_offload & 0x80000) > + port->dev_conf.rxmode.mq_mode &= ~RTE_ETH_MQ_RX_RSS; > } > > cmd_reconfig_device_queue(port_id, 1, 1); >