From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 377B2A00BE; Mon, 16 May 2022 15:29:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 200DF40E03; Mon, 16 May 2022 15:29:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D1FFB40A7A for ; Mon, 16 May 2022 15:29:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652707748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LCUxU7NLEGTiMhBSMTHGQ6MmP64pGZofZ1b5Ot+JNuM=; b=Vi9NKOOdqe0u3hBO7IIM2oBB5YEuVts8y3BoiccZCNA8oTu8xCpG6MXxpgarj+gcUhaXC0 NXYhB6mlSd4dDfylBuQCzfnOnUNC69x6mH47/ovxnfr4AoGOY49OjNl3IF8Zz0vKPx6sKG WOvV0bZ5oGbaeLdL68nGdzITRUWemZM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-eH3bCBlCNeyfZhX0Cn7qoQ-1; Mon, 16 May 2022 09:29:05 -0400 X-MC-Unique: eH3bCBlCNeyfZhX0Cn7qoQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D101780418F; Mon, 16 May 2022 13:29:04 +0000 (UTC) Received: from [10.39.208.38] (unknown [10.39.208.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D4982026D64; Mon, 16 May 2022 13:29:00 +0000 (UTC) Message-ID: Date: Mon, 16 May 2022 15:28:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH 3/6] net/vhost: enable compliant offloading mode To: "Xia, Chenbo" , "dev@dpdk.org" , "jasowang@redhat.com" , "david.marchand@redhat.com" , "olivier.matz@6wind.com" Cc: "stable@dpdk.org" References: <20220505102729.821075-1-maxime.coquelin@redhat.com> <20220505102729.821075-4-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, On 5/16/22 15:26, Xia, Chenbo wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Thursday, May 5, 2022 6:27 PM >> To: dev@dpdk.org; jasowang@redhat.com; Xia, Chenbo ; >> david.marchand@redhat.com; olivier.matz@6wind.com >> Cc: stable@dpdk.org; Maxime Coquelin >> Subject: [PATCH 3/6] net/vhost: enable compliant offloading mode >> >> This patch enables the compliant offloading flags mode by >> default, which prevents the Rx path to set Tx offload flags, >> which is illegal. A new legacy-ol-flags devarg is introduced >> to enable the legacy behaviour. >> >> Signed-off-by: Maxime Coquelin >> --- >> doc/guides/nics/vhost.rst | 6 ++++++ >> drivers/net/vhost/rte_eth_vhost.c | 19 ++++++++++++++++--- >> 2 files changed, 22 insertions(+), 3 deletions(-) >> >> diff --git a/doc/guides/nics/vhost.rst b/doc/guides/nics/vhost.rst >> index ee802ec4a8..d7c0e2ade8 100644 >> --- a/doc/guides/nics/vhost.rst >> +++ b/doc/guides/nics/vhost.rst >> @@ -64,6 +64,12 @@ The user can specify below arguments in `--vdev` option. >> It is used to enable external buffer support in vhost library. >> (Default: 0 (disabled)) >> >> +#. ``legacy-ol-flags``: >> + >> + It is used to restore legacy behavior for offloading that was not >> + compliant with offloading API. >> + (Default: 0 (disabled)) >> + >> Vhost PMD event handling >> ------------------------ >> >> diff --git a/drivers/net/vhost/rte_eth_vhost.c >> b/drivers/net/vhost/rte_eth_vhost.c >> index 070f0e6dfd..0a2e8d9b29 100644 >> --- a/drivers/net/vhost/rte_eth_vhost.c >> +++ b/drivers/net/vhost/rte_eth_vhost.c >> @@ -31,9 +31,10 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM}; >> #define ETH_VHOST_CLIENT_ARG "client" >> #define ETH_VHOST_IOMMU_SUPPORT "iommu-support" >> #define ETH_VHOST_POSTCOPY_SUPPORT "postcopy-support" >> -#define ETH_VHOST_VIRTIO_NET_F_HOST_TSO "tso" >> -#define ETH_VHOST_LINEAR_BUF "linear-buffer" >> -#define ETH_VHOST_EXT_BUF "ext-buffer" >> +#define ETH_VHOST_VIRTIO_NET_F_HOST_TSO "tso" >> +#define ETH_VHOST_LINEAR_BUF "linear-buffer" >> +#define ETH_VHOST_EXT_BUF "ext-buffer" >> +#define ETH_VHOST_LEGACY_OL_FLAGS "legacy-ol-flags" >> #define VHOST_MAX_PKT_BURST 32 >> >> static const char *valid_arguments[] = { >> @@ -1563,6 +1564,7 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) >> int tso = 0; >> int linear_buf = 0; >> int ext_buf = 0; >> + int legacy_ol_flags = 0; >> struct rte_eth_dev *eth_dev; >> const char *name = rte_vdev_device_name(dev); >> >> @@ -1672,6 +1674,17 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) >> flags |= RTE_VHOST_USER_EXTBUF_SUPPORT; >> } >> >> + if (rte_kvargs_count(kvlist, ETH_VHOST_LEGACY_OL_FLAGS) == 1) { >> + ret = rte_kvargs_process(kvlist, >> + ETH_VHOST_LEGACY_OL_FLAGS, >> + &open_int, &legacy_ol_flags); >> + if (ret < 0) >> + goto out_free; >> + } >> + >> + if (legacy_ol_flags == 0) >> + flags |= RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS; > > Putting this check into above '{}' like other option does, will look better. Actually, it would change the behavior because we want to set the flag even if legacy devrarg is not passed. Regards, Maxime > Thanks, > Chenbo > >> + >> if (dev->device.numa_node == SOCKET_ID_ANY) >> dev->device.numa_node = rte_socket_id(); >> >> -- >> 2.35.1 >