From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Charles (Chas) Williams" <ciwillia@brocade.com>, dev@dpdk.org
Cc: wenzhuo.lu@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/e1000: always enable receive and transmit
Date: Tue, 18 Jul 2017 12:50:11 +0100 [thread overview]
Message-ID: <b84a728c-e562-e08f-84cf-543010a3236e@intel.com> (raw)
In-Reply-To: <1500319133-16815-1-git-send-email-ciwillia@brocade.com>
On 7/17/2017 8:18 PM, Charles (Chas) Williams wrote:
> The transmit and receive controller state machines are only enabled after
> receiving an interrupt and the link status is now valid. If an adapter
> is being used in conjuction with NC-SI, network controller sideband
> interface, the adapter may never get a link state change interrupt since
> the adapter's PHY is always link up and never changes state.
>
> To fix this, always enable and disable the transmit and receive with
> .dev_start and .dev_stop. This is a better match for what is typically
> done with the other PMD's. Since we may never get an interrupt to check
> the link state, we also poll once at the end of .dev_start to get the
> current link status.
Hi Charles,
Is this patch target 17.08-rc2?
Since this is not a fix, can this be postponed to 17.11?
>
> Signed-off-by: Chas Williams <ciwillia@brocade.com>
<...>
next prev parent reply other threads:[~2017-07-18 11:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 19:18 Charles (Chas) Williams
2017-07-18 11:50 ` Ferruh Yigit [this message]
2017-10-20 3:23 ` [dpdk-dev] [PATCH v2] " Chas Williams
2018-01-11 8:22 ` [dpdk-dev] [dpdk-dev, " Wenzhuo Lu
2018-01-13 6:33 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b84a728c-e562-e08f-84cf-543010a3236e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ciwillia@brocade.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).