From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 36F993253 for ; Tue, 18 Jul 2017 13:50:17 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2017 04:50:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,377,1496127600"; d="scan'208";a="126429345" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.255.134.81]) ([10.255.134.81]) by orsmga005.jf.intel.com with ESMTP; 18 Jul 2017 04:50:13 -0700 To: "Charles (Chas) Williams" , dev@dpdk.org Cc: wenzhuo.lu@intel.com References: <1500319133-16815-1-git-send-email-ciwillia@brocade.com> From: Ferruh Yigit Message-ID: Date: Tue, 18 Jul 2017 12:50:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1500319133-16815-1-git-send-email-ciwillia@brocade.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/e1000: always enable receive and transmit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2017 11:50:19 -0000 On 7/17/2017 8:18 PM, Charles (Chas) Williams wrote: > The transmit and receive controller state machines are only enabled after > receiving an interrupt and the link status is now valid. If an adapter > is being used in conjuction with NC-SI, network controller sideband > interface, the adapter may never get a link state change interrupt since > the adapter's PHY is always link up and never changes state. > > To fix this, always enable and disable the transmit and receive with > .dev_start and .dev_stop. This is a better match for what is typically > done with the other PMD's. Since we may never get an interrupt to check > the link state, we also poll once at the end of .dev_start to get the > current link status. Hi Charles, Is this patch target 17.08-rc2? Since this is not a fix, can this be postponed to 17.11? > > Signed-off-by: Chas Williams <...>